From: Josef Bacik <josef@toxicpanda.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>,
James Smart <james.smart@broadcom.com>,
Ming Lei <ming.lei@redhat.com>, Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH v3 6/8] nbd: quiesce request queues to make sure no submissions are inflight
Date: Wed, 5 Jul 2017 14:08:28 -0400 [thread overview]
Message-ID: <20170705180827.GA18539@destiny> (raw)
In-Reply-To: <1499274037-17438-7-git-send-email-sagi@grimberg.me>
On Wed, Jul 05, 2017 at 08:00:35PM +0300, Sagi Grimberg wrote:
> Unlike blk_mq_stop_hw_queues, blk_mq_quiesce_queue respects the
> submission path rcu grace. quiesce the queue before iterating
> on live tags.
>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>
> Cc: Josef Bacik <jbacik@fb.com>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Sounds fine by me, you can add
Acked-by: Josef Bacik <jbacik@fb.com>
Thanks,
Josef
WARNING: multiple messages have this Message-ID (diff)
From: josef@toxicpanda.com (Josef Bacik)
Subject: [PATCH v3 6/8] nbd: quiesce request queues to make sure no submissions are inflight
Date: Wed, 5 Jul 2017 14:08:28 -0400 [thread overview]
Message-ID: <20170705180827.GA18539@destiny> (raw)
In-Reply-To: <1499274037-17438-7-git-send-email-sagi@grimberg.me>
On Wed, Jul 05, 2017@08:00:35PM +0300, Sagi Grimberg wrote:
> Unlike blk_mq_stop_hw_queues, blk_mq_quiesce_queue respects the
> submission path rcu grace. quiesce the queue before iterating
> on live tags.
>
> Reviewed-by: Ming Lei <ming.lei at redhat.com>
> Cc: Josef Bacik <jbacik at fb.com>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
Sounds fine by me, you can add
Acked-by: Josef Bacik <jbacik at fb.com>
Thanks,
Josef
next prev parent reply other threads:[~2017-07-05 18:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 17:00 [PATCH v3 0/8] correct quiescing in several block drivers Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 17:00 ` [PATCH v3 1/8] nvme-rdma: quiesce/unquiesce admin_q instead of start/stop its hw queues Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 22:44 ` Ming Lei
2017-07-05 22:44 ` Ming Lei
2017-07-05 17:00 ` [PATCH v3 2/8] nvme-fc: " Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 22:49 ` Ming Lei
2017-07-05 22:49 ` Ming Lei
2017-07-05 17:00 ` [PATCH v3 3/8] nvme-loop: " Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 17:00 ` [PATCH v3 4/8] nvme-pci: " Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 22:50 ` Ming Lei
2017-07-05 22:50 ` Ming Lei
2017-07-05 17:00 ` [PATCH v3 5/8] nvme: kick requeue list when requeueing a request instead of when starting the queues Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 22:58 ` Ming Lei
2017-07-05 22:58 ` Ming Lei
2017-07-05 23:06 ` Christoph Hellwig
2017-07-05 23:06 ` Christoph Hellwig
2017-07-05 23:23 ` Ming Lei
2017-07-05 23:23 ` Ming Lei
2017-07-05 17:00 ` [PATCH v3 6/8] nbd: quiesce request queues to make sure no submissions are inflight Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 18:08 ` Josef Bacik [this message]
2017-07-05 18:08 ` Josef Bacik
2017-07-05 17:00 ` [PATCH v3 7/8] mtip32xx: " Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 17:00 ` [PATCH v3 8/8] virtio_blk: quiesce/unquiesce live IO when entering PM states Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705180827.GA18539@destiny \
--to=josef@toxicpanda.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=jbacik@fb.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.