From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>,
James Smart <james.smart@broadcom.com>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH v3 5/8] nvme: kick requeue list when requeueing a request instead of when starting the queues
Date: Thu, 6 Jul 2017 01:06:21 +0200 [thread overview]
Message-ID: <20170705230621.GA12043@lst.de> (raw)
In-Reply-To: <1499274037-17438-6-git-send-email-sagi@grimberg.me>
I wonder if we should simply always kick the list and remove the
parameter and blk_mq_kick_requeue_list. It seems like this split
has caused a lot more harm then good, and the other drivers using
it that way are probably having issues as well.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v3 5/8] nvme: kick requeue list when requeueing a request instead of when starting the queues
Date: Thu, 6 Jul 2017 01:06:21 +0200 [thread overview]
Message-ID: <20170705230621.GA12043@lst.de> (raw)
In-Reply-To: <1499274037-17438-6-git-send-email-sagi@grimberg.me>
I wonder if we should simply always kick the list and remove the
parameter and blk_mq_kick_requeue_list. It seems like this split
has caused a lot more harm then good, and the other drivers using
it that way are probably having issues as well.
next prev parent reply other threads:[~2017-07-05 23:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 17:00 [PATCH v3 0/8] correct quiescing in several block drivers Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 17:00 ` [PATCH v3 1/8] nvme-rdma: quiesce/unquiesce admin_q instead of start/stop its hw queues Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 22:44 ` Ming Lei
2017-07-05 22:44 ` Ming Lei
2017-07-05 17:00 ` [PATCH v3 2/8] nvme-fc: " Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 22:49 ` Ming Lei
2017-07-05 22:49 ` Ming Lei
2017-07-05 17:00 ` [PATCH v3 3/8] nvme-loop: " Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 17:00 ` [PATCH v3 4/8] nvme-pci: " Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 22:50 ` Ming Lei
2017-07-05 22:50 ` Ming Lei
2017-07-05 17:00 ` [PATCH v3 5/8] nvme: kick requeue list when requeueing a request instead of when starting the queues Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 22:58 ` Ming Lei
2017-07-05 22:58 ` Ming Lei
2017-07-05 23:06 ` Christoph Hellwig [this message]
2017-07-05 23:06 ` Christoph Hellwig
2017-07-05 23:23 ` Ming Lei
2017-07-05 23:23 ` Ming Lei
2017-07-05 17:00 ` [PATCH v3 6/8] nbd: quiesce request queues to make sure no submissions are inflight Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 18:08 ` Josef Bacik
2017-07-05 18:08 ` Josef Bacik
2017-07-05 17:00 ` [PATCH v3 7/8] mtip32xx: " Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
2017-07-05 17:00 ` [PATCH v3 8/8] virtio_blk: quiesce/unquiesce live IO when entering PM states Sagi Grimberg
2017-07-05 17:00 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705230621.GA12043@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=james.smart@broadcom.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.