All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Glisse <jglisse@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	John Hubbard <jhubbard@nvidia.com>,
	David Nellans <dnellans@nvidia.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Balbir Singh <bsingharora@gmail.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	cgroups@vger.kernel.org
Subject: Re: [PATCH 4/5] mm/memcontrol: allow to uncharge page without using page->lru field
Date: Mon, 10 Jul 2017 12:54:21 -0400	[thread overview]
Message-ID: <20170710165420.GC4964@redhat.com> (raw)
In-Reply-To: <20170710163651.GD7071@dhcp22.suse.cz>

On Mon, Jul 10, 2017 at 06:36:52PM +0200, Michal Hocko wrote:
> On Mon 10-07-17 12:25:42, Jerome Glisse wrote:
> [...]
> > Bottom line is that we can always free and uncharge device memory
> > page just like any regular page.
> 
> OK, this answers my earlier question. Then it should be feasible to
> charge this memory. There are still some things to handle. E.g. how do
> we consider this memory during oom victim selection (this is not
> accounted as an anonymous memory in get_mm_counter, right?), maybe others.
> But the primary point is that nobody pins the memory outside of the
> mapping.

At this point it is accounted as a regular page would be (anonymous, file
or share memory). I wanted mm_counters to reflect memcg but i can untie
that. Like i said at this point we are unsure how usage of such memory
will impact thing so i wanted to keep all thing as if it was regular
memory to avoid anuything to behave too much differently.

Jérôme

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Jerome Glisse <jglisse@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	John Hubbard <jhubbard@nvidia.com>,
	David Nellans <dnellans@nvidia.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Balbir Singh <bsingharora@gmail.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	cgroups@vger.kernel.org
Subject: Re: [PATCH 4/5] mm/memcontrol: allow to uncharge page without using page->lru field
Date: Mon, 10 Jul 2017 12:54:21 -0400	[thread overview]
Message-ID: <20170710165420.GC4964@redhat.com> (raw)
In-Reply-To: <20170710163651.GD7071@dhcp22.suse.cz>

On Mon, Jul 10, 2017 at 06:36:52PM +0200, Michal Hocko wrote:
> On Mon 10-07-17 12:25:42, Jerome Glisse wrote:
> [...]
> > Bottom line is that we can always free and uncharge device memory
> > page just like any regular page.
> 
> OK, this answers my earlier question. Then it should be feasible to
> charge this memory. There are still some things to handle. E.g. how do
> we consider this memory during oom victim selection (this is not
> accounted as an anonymous memory in get_mm_counter, right?), maybe others.
> But the primary point is that nobody pins the memory outside of the
> mapping.

At this point it is accounted as a regular page would be (anonymous, file
or share memory). I wanted mm_counters to reflect memcg but i can untie
that. Like i said at this point we are unsure how usage of such memory
will impact thing so i wanted to keep all thing as if it was regular
memory to avoid anuything to behave too much differently.

Jerome

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Jerome Glisse <jglisse@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	John Hubbard <jhubbard@nvidia.com>,
	David Nellans <dnellans@nvidia.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Balbir Singh <bsingharora@gmail.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	cgroups@vger.kernel.org
Subject: Re: [PATCH 4/5] mm/memcontrol: allow to uncharge page without using page->lru field
Date: Mon, 10 Jul 2017 12:54:21 -0400	[thread overview]
Message-ID: <20170710165420.GC4964@redhat.com> (raw)
In-Reply-To: <20170710163651.GD7071@dhcp22.suse.cz>

On Mon, Jul 10, 2017 at 06:36:52PM +0200, Michal Hocko wrote:
> On Mon 10-07-17 12:25:42, Jerome Glisse wrote:
> [...]
> > Bottom line is that we can always free and uncharge device memory
> > page just like any regular page.
> 
> OK, this answers my earlier question. Then it should be feasible to
> charge this memory. There are still some things to handle. E.g. how do
> we consider this memory during oom victim selection (this is not
> accounted as an anonymous memory in get_mm_counter, right?), maybe others.
> But the primary point is that nobody pins the memory outside of the
> mapping.

At this point it is accounted as a regular page would be (anonymous, file
or share memory). I wanted mm_counters to reflect memcg but i can untie
that. Like i said at this point we are unsure how usage of such memory
will impact thing so i wanted to keep all thing as if it was regular
memory to avoid anuything to behave too much differently.

Jérôme

  reply	other threads:[~2017-07-10 16:54 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03 21:14 [PATCH 0/5] Cache coherent device memory (CDM) with HMM v3 Jérôme Glisse
2017-07-03 21:14 ` Jérôme Glisse
2017-07-03 21:14 ` [PATCH 1/5] mm/persistent-memory: match IORES_DESC name and enum memory_type one Jérôme Glisse
2017-07-03 21:14   ` Jérôme Glisse
2017-07-03 23:49   ` Dan Williams
2017-07-03 23:49     ` Dan Williams
2017-07-05 14:25     ` Jerome Glisse
2017-07-05 14:25       ` Jerome Glisse
2017-07-05 16:15       ` Dan Williams
2017-07-05 16:15         ` Dan Williams
2017-07-05 18:49         ` Jerome Glisse
2017-07-05 18:49           ` Jerome Glisse
2017-07-11  3:48           ` Balbir Singh
2017-07-11  3:48             ` Balbir Singh
2017-07-11  7:31           ` Dan Williams
2017-07-11  7:31             ` Dan Williams
2017-07-11 15:05             ` Jerome Glisse
2017-07-11 15:05               ` Jerome Glisse
2017-07-11 16:49               ` Dan Williams
2017-07-11 16:49                 ` Dan Williams
2017-07-03 21:14 ` [PATCH 2/5] mm/device-public-memory: device memory cache coherent with CPU v2 Jérôme Glisse
2017-07-03 21:14   ` Jérôme Glisse
2017-07-11  4:12   ` Balbir Singh
2017-07-11  4:12     ` Balbir Singh
2017-07-11 14:57     ` Jerome Glisse
2017-07-11 14:57       ` Jerome Glisse
2017-07-12  5:50       ` Balbir Singh
2017-07-12  5:50         ` Balbir Singh
2017-07-03 21:14 ` [PATCH 3/5] mm/hmm: add new helper to hotplug CDM memory region Jérôme Glisse
2017-07-03 21:14   ` Jérôme Glisse
2017-07-03 21:14 ` [PATCH 4/5] mm/memcontrol: allow to uncharge page without using page->lru field Jérôme Glisse
2017-07-03 21:14   ` Jérôme Glisse
2017-07-03 21:14   ` Jérôme Glisse
2017-07-04 12:51   ` Michal Hocko
2017-07-04 12:51     ` Michal Hocko
2017-07-04 12:51     ` Michal Hocko
     [not found]     ` <20170704125113.GC14727-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-07-05  3:18       ` Balbir Singh
2017-07-05  3:18         ` Balbir Singh
2017-07-05  3:18         ` Balbir Singh
2017-07-05  6:38         ` Michal Hocko
2017-07-05  6:38           ` Michal Hocko
2017-07-05  6:38           ` Michal Hocko
     [not found]           ` <20170705063813.GB10354-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-07-05 10:22             ` Balbir Singh
2017-07-05 10:22               ` Balbir Singh
2017-07-05 10:22               ` Balbir Singh
2017-07-05 14:35     ` Jerome Glisse
2017-07-05 14:35       ` Jerome Glisse
2017-07-10  8:28       ` Michal Hocko
2017-07-10  8:28         ` Michal Hocko
2017-07-10  8:28         ` Michal Hocko
     [not found]         ` <20170710082805.GD19185-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-07-10 15:32           ` Jerome Glisse
2017-07-10 15:32             ` Jerome Glisse
2017-07-10 15:32             ` Jerome Glisse
2017-07-10 16:04             ` Michal Hocko
2017-07-10 16:04               ` Michal Hocko
2017-07-10 16:04               ` Michal Hocko
     [not found]               ` <20170710160444.GB7071-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-07-10 16:25                 ` Jerome Glisse
2017-07-10 16:25                   ` Jerome Glisse
2017-07-10 16:25                   ` Jerome Glisse
     [not found]                   ` <20170710162542.GB4964-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-07-10 16:36                     ` Michal Hocko
2017-07-10 16:36                       ` Michal Hocko
2017-07-10 16:36                       ` Michal Hocko
2017-07-10 16:54                       ` Jerome Glisse [this message]
2017-07-10 16:54                         ` Jerome Glisse
2017-07-10 16:54                         ` Jerome Glisse
2017-07-10 17:48                         ` Michal Hocko
2017-07-10 17:48                           ` Michal Hocko
     [not found]                           ` <20170710174857.GF7071-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-07-10 18:10                             ` Jerome Glisse
2017-07-10 18:10                               ` Jerome Glisse
2017-07-10 18:10                               ` Jerome Glisse
2017-07-03 21:14 ` [PATCH 5/5] mm/memcontrol: support MEMORY_DEVICE_PRIVATE and MEMORY_DEVICE_PUBLIC Jérôme Glisse
2017-07-03 21:14   ` Jérôme Glisse
2017-07-03 21:14   ` Jérôme Glisse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170710165420.GC4964@redhat.com \
    --to=jglisse@redhat.com \
    --cc=bsingharora@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dnellans@nvidia.com \
    --cc=hannes@cmpxchg.org \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=vdavydov.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.