From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Colin King <colin.king@canonical.com>
Cc: Helmut Schaa <helmut.schaa@googlemail.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] rt2x00: make const array glrt_table static
Date: Wed, 12 Jul 2017 06:49:12 +0000 [thread overview]
Message-ID: <20170712064911.GA2769@redhat.com> (raw)
In-Reply-To: <20170711114733.15387-1-colin.king@canonical.com>
On Tue, Jul 11, 2017 at 12:47:33PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate array glrt_table on the stack but make it static.
> Makes the object code a smaller by over 670 bytes:
>
> Before:
> text data bss dec hex filename
> 131772 4733 0 136505 21539 rt2800lib.o
>
> After:
> text data bss dec hex filename
> 131043 4789 0 135832 21298 rt2800lib.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
I wonder why compiler do not optimize by itself since array is
const, but patch is ok.
Stanislaw
WARNING: multiple messages have this Message-ID (diff)
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Colin King <colin.king@canonical.com>
Cc: Helmut Schaa <helmut.schaa@googlemail.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] rt2x00: make const array glrt_table static
Date: Wed, 12 Jul 2017 08:49:12 +0200 [thread overview]
Message-ID: <20170712064911.GA2769@redhat.com> (raw)
In-Reply-To: <20170711114733.15387-1-colin.king@canonical.com>
On Tue, Jul 11, 2017 at 12:47:33PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate array glrt_table on the stack but make it static.
> Makes the object code a smaller by over 670 bytes:
>
> Before:
> text data bss dec hex filename
> 131772 4733 0 136505 21539 rt2800lib.o
>
> After:
> text data bss dec hex filename
> 131043 4789 0 135832 21298 rt2800lib.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
I wonder why compiler do not optimize by itself since array is
const, but patch is ok.
Stanislaw
next prev parent reply other threads:[~2017-07-12 6:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 11:47 [PATCH] rt2x00: make const array glrt_table static Colin King
2017-07-11 11:47 ` Colin King
2017-07-11 11:47 ` Colin King
2017-07-12 6:49 ` Stanislaw Gruszka [this message]
2017-07-12 6:49 ` Stanislaw Gruszka
2017-07-12 7:04 ` Colin Ian King
2017-07-12 7:04 ` Colin Ian King
2017-07-28 15:01 ` Kalle Valo
2017-07-28 15:01 ` Kalle Valo
2017-07-28 16:51 ` Kalle Valo
2017-07-28 16:51 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712064911.GA2769@redhat.com \
--to=sgruszka@redhat.com \
--cc=colin.king@canonical.com \
--cc=helmut.schaa@googlemail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.