All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
	Helmut Schaa <helmut.schaa@googlemail.com>,
	linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: rt2x00: make const array glrt_table static
Date: Fri, 28 Jul 2017 16:51:11 +0000	[thread overview]
Message-ID: <877eyswlmo.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20170728150130.336D06095E@smtp.codeaurora.org> (Kalle Valo's message of "Fri, 28 Jul 2017 15:01:30 +0000 (UTC)")

Kalle Valo <kvalo@codeaurora.org> writes:

> Colin Ian King <colin.king@canonical.com> wrote:
>
>> From: Colin Ian King <colin.king@canonical.com>
>> 
>> Don't populate array glrt_table on the stack but make it static.
>> Makes the object code a smaller by over 670 bytes:
>> 
>> Before:
>>    text	   data	    bss	    dec	    hex	filename
>>  131772	   4733	      0	 136505	  21539	rt2800lib.o
>> 
>> After:
>>    text	   data	    bss	    dec	    hex	filename
>>  131043	   4789	      0	 135832	  21298	rt2800lib.o
>> 
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
>
> Patch applied to wireless-drivers-next.git, thanks.
>
> 17830147c40a mwifiex: fix spelling mistake: "Insuffient" -> "Insufficient"

Dave had applied this earlier and my script failed to detect that. Hence
the commit above is wrong.

commit bf98bd0be1ba509c5e6d77524ffac192f1edb2dd
Author:     Colin Ian King <colin.king@canonical.com>
AuthorDate: Tue Jul 11 12:47:33 2017 +0100
Commit:     David S. Miller <davem@davemloft.net>
CommitDate: Thu Jul 13 09:23:56 2017 -0700

    rt2x00: make const array glrt_table static

-- 
Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
	Helmut Schaa <helmut.schaa@googlemail.com>,
	linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: rt2x00: make const array glrt_table static
Date: Fri, 28 Jul 2017 19:51:11 +0300	[thread overview]
Message-ID: <877eyswlmo.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20170728150130.336D06095E@smtp.codeaurora.org> (Kalle Valo's message of "Fri, 28 Jul 2017 15:01:30 +0000 (UTC)")

Kalle Valo <kvalo@codeaurora.org> writes:

> Colin Ian King <colin.king@canonical.com> wrote:
>
>> From: Colin Ian King <colin.king@canonical.com>
>> 
>> Don't populate array glrt_table on the stack but make it static.
>> Makes the object code a smaller by over 670 bytes:
>> 
>> Before:
>>    text	   data	    bss	    dec	    hex	filename
>>  131772	   4733	      0	 136505	  21539	rt2800lib.o
>> 
>> After:
>>    text	   data	    bss	    dec	    hex	filename
>>  131043	   4789	      0	 135832	  21298	rt2800lib.o
>> 
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
>
> Patch applied to wireless-drivers-next.git, thanks.
>
> 17830147c40a mwifiex: fix spelling mistake: "Insuffient" -> "Insufficient"

Dave had applied this earlier and my script failed to detect that. Hence
the commit above is wrong.

commit bf98bd0be1ba509c5e6d77524ffac192f1edb2dd
Author:     Colin Ian King <colin.king@canonical.com>
AuthorDate: Tue Jul 11 12:47:33 2017 +0100
Commit:     David S. Miller <davem@davemloft.net>
CommitDate: Thu Jul 13 09:23:56 2017 -0700

    rt2x00: make const array glrt_table static

-- 
Kalle Valo

  reply	other threads:[~2017-07-28 16:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 11:47 [PATCH] rt2x00: make const array glrt_table static Colin King
2017-07-11 11:47 ` Colin King
2017-07-11 11:47 ` Colin King
2017-07-12  6:49 ` Stanislaw Gruszka
2017-07-12  6:49   ` Stanislaw Gruszka
2017-07-12  7:04   ` Colin Ian King
2017-07-12  7:04     ` Colin Ian King
2017-07-28 15:01 ` Kalle Valo
2017-07-28 15:01   ` Kalle Valo
2017-07-28 16:51   ` Kalle Valo [this message]
2017-07-28 16:51     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877eyswlmo.fsf@purkki.adurom.net \
    --to=kvalo@codeaurora.org \
    --cc=colin.king@canonical.com \
    --cc=helmut.schaa@googlemail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.