All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvmet: preserve controller serial number between reboots
Date: Thu, 13 Jul 2017 15:06:52 +0200	[thread overview]
Message-ID: <20170713130652.GA24376@lst.de> (raw)
In-Reply-To: <d32c32f6-3f8f-c63a-f961-ee16407c2fd6@grimberg.me>

On Thu, Jul 13, 2017@03:30:39PM +0300, Sagi Grimberg wrote:
> It seems weird that a subsystem has a serial.

But that's actually how NVMe defines them.  Which mean we first
need to fix our code to generate a serial number per subsystem,
and on top of that the patch from Johannes seems perfectly reasonable.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
	Christoph Hellwig <hch@lst.de>,
	Keith Busch <keith.busch@intel.com>,
	mwilck@suse.de,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
	Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvmet: preserve controller serial number between reboots
Date: Thu, 13 Jul 2017 15:06:52 +0200	[thread overview]
Message-ID: <20170713130652.GA24376@lst.de> (raw)
In-Reply-To: <d32c32f6-3f8f-c63a-f961-ee16407c2fd6@grimberg.me>

On Thu, Jul 13, 2017 at 03:30:39PM +0300, Sagi Grimberg wrote:
> It seems weird that a subsystem has a serial.

But that's actually how NVMe defines them.  Which mean we first
need to fix our code to generate a serial number per subsystem,
and on top of that the patch from Johannes seems perfectly reasonable.

  parent reply	other threads:[~2017-07-13 13:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13 10:48 [PATCH] nvmet: preserve controller serial number between reboots Johannes Thumshirn
2017-07-13 10:48 ` Johannes Thumshirn
2017-07-13 12:30 ` Sagi Grimberg
2017-07-13 12:30   ` Sagi Grimberg
2017-07-13 12:52   ` Johannes Thumshirn
2017-07-13 12:52     ` Johannes Thumshirn
2017-07-13 13:06   ` Christoph Hellwig [this message]
2017-07-13 13:06     ` Christoph Hellwig
2017-07-13 13:11     ` Johannes Thumshirn
2017-07-13 13:11       ` Johannes Thumshirn
2017-07-13 16:38     ` Sagi Grimberg
2017-07-13 16:38       ` Sagi Grimberg
2017-07-13 17:17       ` Christoph Hellwig
2017-07-13 17:17         ` Christoph Hellwig
2017-07-13 15:08 ` Martin Wilck
2017-07-13 15:08   ` Martin Wilck
2017-07-13 15:16   ` Christoph Hellwig
2017-07-13 15:16     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170713130652.GA24376@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.