All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvmet: preserve controller serial number between reboots
Date: Thu, 13 Jul 2017 17:16:33 +0200	[thread overview]
Message-ID: <20170713151633.GA993@lst.de> (raw)
In-Reply-To: <1499958505.6432.8.camel@suse.de>

On Thu, Jul 13, 2017@05:08:25PM +0200, Martin Wilck wrote:
> I'm wondering if this should be a write-once attribute. Also,
> Once the serial number has been passed on to some host (or maybe only:
> while the device is in use by some host), the attribute should probably
> be read-only.

In practive it should.  But I don't think it's worth the extra code
just to prevent people from shooting themselves into the foot.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Martin Wilck <mwilck@suse.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Keith Busch <keith.busch@intel.com>,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
	Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvmet: preserve controller serial number between reboots
Date: Thu, 13 Jul 2017 17:16:33 +0200	[thread overview]
Message-ID: <20170713151633.GA993@lst.de> (raw)
In-Reply-To: <1499958505.6432.8.camel@suse.de>

On Thu, Jul 13, 2017 at 05:08:25PM +0200, Martin Wilck wrote:
> I'm wondering if this should be a write-once attribute. Also,
> Once the serial number has been passed on to some host (or maybe only:
> while the device is in use by some host), the attribute should probably
> be read-only.

In practive it should.  But I don't think it's worth the extra code
just to prevent people from shooting themselves into the foot.

  reply	other threads:[~2017-07-13 15:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13 10:48 [PATCH] nvmet: preserve controller serial number between reboots Johannes Thumshirn
2017-07-13 10:48 ` Johannes Thumshirn
2017-07-13 12:30 ` Sagi Grimberg
2017-07-13 12:30   ` Sagi Grimberg
2017-07-13 12:52   ` Johannes Thumshirn
2017-07-13 12:52     ` Johannes Thumshirn
2017-07-13 13:06   ` Christoph Hellwig
2017-07-13 13:06     ` Christoph Hellwig
2017-07-13 13:11     ` Johannes Thumshirn
2017-07-13 13:11       ` Johannes Thumshirn
2017-07-13 16:38     ` Sagi Grimberg
2017-07-13 16:38       ` Sagi Grimberg
2017-07-13 17:17       ` Christoph Hellwig
2017-07-13 17:17         ` Christoph Hellwig
2017-07-13 15:08 ` Martin Wilck
2017-07-13 15:08   ` Martin Wilck
2017-07-13 15:16   ` Christoph Hellwig [this message]
2017-07-13 15:16     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170713151633.GA993@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.