From: Vinod Koul <vinod.koul@intel.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Dan Williams <dan.j.williams@intel.com>,
linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support
Date: Tue, 18 Jul 2017 21:49:57 +0530 [thread overview]
Message-ID: <20170718161956.GV3053@localhost> (raw)
In-Reply-To: <1498789858-18583-1-git-send-email-okaya@codeaurora.org>
On Thu, Jun 29, 2017 at 10:30:57PM -0400, Sinan Kaya wrote:
> @@ -410,7 +410,40 @@ static int hidma_alloc_chan_resources(struct dma_chan *dmach)
> return NULL;
>
> hidma_ll_set_transfer_params(mdma->lldev, mdesc->tre_ch,
> - src, dest, len, flags);
> + src, dest, len, flags,
> + HIDMA_TRE_MEMCPY);
> +
> + /* Place descriptor in prepared list */
> + spin_lock_irqsave(&mchan->lock, irqflags);
> + list_add_tail(&mdesc->node, &mchan->prepared);
> + spin_unlock_irqrestore(&mchan->lock, irqflags);
This change looks suspicious, cna you clarify the need to do this?
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support
Date: Tue, 18 Jul 2017 21:49:57 +0530 [thread overview]
Message-ID: <20170718161956.GV3053@localhost> (raw)
In-Reply-To: <1498789858-18583-1-git-send-email-okaya@codeaurora.org>
On Thu, Jun 29, 2017 at 10:30:57PM -0400, Sinan Kaya wrote:
> @@ -410,7 +410,40 @@ static int hidma_alloc_chan_resources(struct dma_chan *dmach)
> return NULL;
>
> hidma_ll_set_transfer_params(mdma->lldev, mdesc->tre_ch,
> - src, dest, len, flags);
> + src, dest, len, flags,
> + HIDMA_TRE_MEMCPY);
> +
> + /* Place descriptor in prepared list */
> + spin_lock_irqsave(&mchan->lock, irqflags);
> + list_add_tail(&mdesc->node, &mchan->prepared);
> + spin_unlock_irqrestore(&mchan->lock, irqflags);
This change looks suspicious, cna you clarify the need to do this?
--
~Vinod
next prev parent reply other threads:[~2017-07-18 16:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 2:30 [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support Sinan Kaya
2017-06-30 2:30 ` Sinan Kaya
2017-06-30 2:30 ` [PATCH V3 2/2] dmaengine: dmatest: add support for memset test Sinan Kaya
2017-06-30 2:30 ` Sinan Kaya
2017-07-18 16:26 ` Vinod Koul
2017-07-18 16:26 ` Vinod Koul
2017-07-18 16:19 ` Vinod Koul [this message]
2017-07-18 16:19 ` [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support Vinod Koul
2017-07-18 16:26 ` Sinan Kaya
2017-07-18 16:26 ` Sinan Kaya
2017-07-18 16:47 ` Vinod Koul
2017-07-18 16:47 ` Vinod Koul
2017-07-19 4:03 ` Vinod Koul
2017-07-19 4:03 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718161956.GV3053@localhost \
--to=vinod.koul@intel.com \
--cc=andy.gross@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=david.brown@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.