All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Dennis Zhou <dennisz@fb.com>
Cc: Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
	Josef Bacik <josef@toxicpanda.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel-team@fb.com, Dennis Zhou <dennisszhou@gmail.com>
Subject: Re: [PATCH v2 02/23] percpu: introduce start_offset to pcpu_chunk
Date: Tue, 25 Jul 2017 14:04:18 -0400	[thread overview]
Message-ID: <20170725180417.GB18880@destiny> (raw)
In-Reply-To: <20170724230220.21774-3-dennisz@fb.com>

On Mon, Jul 24, 2017 at 07:01:59PM -0400, Dennis Zhou wrote:
> From: "Dennis Zhou (Facebook)" <dennisszhou@gmail.com>
> 
> The reserved chunk arithmetic uses a global variable
> pcpu_reserved_chunk_limit that is set in the first chunk init code to
> hide a portion of the area map. The bitmap allocator to come will
> eventually move the base_addr up and require both the reserved chunk
> and static chunk to maintain this offset. pcpu_reserved_chunk_limit is
> removed and start_offset is added.
> 
> The first chunk that is circulated and is pcpu_first_chunk serves the
> dynamic region, the region following the reserved region. The reserved
> chunk address check will temporarily use the first chunk to identify its
> address range. A following patch will increase the base_addr and remove
> this. If there is no reserved chunk, this will check the static region
> and return false because those values should never be passed into the
> allocator.
> 
> Lastly, when linking in the first chunk, make sure to count the right
> free region for the number of empty populated pages.
> 
> Signed-off-by: Dennis Zhou <dennisszhou@gmail.com>

Reviewed-by: Josef Bacik <jbacik@fb.com>

Thanks,

Josef

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Josef Bacik <josef@toxicpanda.com>
To: Dennis Zhou <dennisz@fb.com>
Cc: Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
	Josef Bacik <josef@toxicpanda.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel-team@fb.com, Dennis Zhou <dennisszhou@gmail.com>
Subject: Re: [PATCH v2 02/23] percpu: introduce start_offset to pcpu_chunk
Date: Tue, 25 Jul 2017 14:04:18 -0400	[thread overview]
Message-ID: <20170725180417.GB18880@destiny> (raw)
In-Reply-To: <20170724230220.21774-3-dennisz@fb.com>

On Mon, Jul 24, 2017 at 07:01:59PM -0400, Dennis Zhou wrote:
> From: "Dennis Zhou (Facebook)" <dennisszhou@gmail.com>
> 
> The reserved chunk arithmetic uses a global variable
> pcpu_reserved_chunk_limit that is set in the first chunk init code to
> hide a portion of the area map. The bitmap allocator to come will
> eventually move the base_addr up and require both the reserved chunk
> and static chunk to maintain this offset. pcpu_reserved_chunk_limit is
> removed and start_offset is added.
> 
> The first chunk that is circulated and is pcpu_first_chunk serves the
> dynamic region, the region following the reserved region. The reserved
> chunk address check will temporarily use the first chunk to identify its
> address range. A following patch will increase the base_addr and remove
> this. If there is no reserved chunk, this will check the static region
> and return false because those values should never be passed into the
> allocator.
> 
> Lastly, when linking in the first chunk, make sure to count the right
> free region for the number of empty populated pages.
> 
> Signed-off-by: Dennis Zhou <dennisszhou@gmail.com>

Reviewed-by: Josef Bacik <jbacik@fb.com>

Thanks,

Josef

  reply	other threads:[~2017-07-25 18:04 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 23:01 [PATCH v2 00/23] percpu: replace percpu area map allocator with bitmap allocator Dennis Zhou
2017-07-24 23:01 ` Dennis Zhou
2017-07-24 23:01 ` [PATCH v2 01/23] percpu: setup_first_chunk enforce dynamic region must exist Dennis Zhou
2017-07-24 23:01   ` Dennis Zhou
2017-07-25 18:03   ` Josef Bacik
2017-07-25 18:03     ` Josef Bacik
2017-07-24 23:01 ` [PATCH v2 02/23] percpu: introduce start_offset to pcpu_chunk Dennis Zhou
2017-07-24 23:01   ` Dennis Zhou
2017-07-25 18:04   ` Josef Bacik [this message]
2017-07-25 18:04     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 03/23] percpu: remove has_reserved from pcpu_chunk Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 18:05   ` Josef Bacik
2017-07-25 18:05     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 04/23] percpu: setup_first_chunk remove dyn_size and consolidate logic Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 18:07   ` Josef Bacik
2017-07-25 18:07     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 05/23] percpu: unify allocation of schunk and dchunk Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 18:10   ` Josef Bacik
2017-07-25 18:10     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 06/23] percpu: end chunk area maps page aligned for the populated bitmap Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 18:14   ` Josef Bacik
2017-07-25 18:14     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 07/23] percpu: setup_first_chunk rename schunk/dchunk to chunk Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 18:15   ` Josef Bacik
2017-07-25 18:15     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 08/23] percpu: modify base_addr to be region specific Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 18:24   ` Josef Bacik
2017-07-25 18:24     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 09/23] percpu: combine percpu address checks Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 18:25   ` Josef Bacik
2017-07-25 18:25     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 10/23] percpu: change the number of pages marked in the first_chunk pop bitmap Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 18:27   ` Josef Bacik
2017-07-25 18:27     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 11/23] percpu: introduce nr_empty_pop_pages to help empty page accounting Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 18:29   ` Josef Bacik
2017-07-25 18:29     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 12/23] percpu: increase minimum percpu allocation size and align first regions Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 18:33   ` Josef Bacik
2017-07-25 18:33     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 13/23] percpu: generalize bitmap (un)populated iterators Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 18:35   ` Josef Bacik
2017-07-25 18:35     ` Josef Bacik
2017-07-26 14:08   ` Tejun Heo
2017-07-26 14:08     ` Tejun Heo
2017-07-24 23:02 ` [PATCH v2 14/23] percpu: replace area map allocator with bitmap allocator Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 17:36   ` [percpu] ec1f2e572e: WARNING:at_lib/list_debug.c:#__list_add_valid kernel test robot
2017-07-25 17:36     ` kernel test robot
2017-07-25 19:15   ` [PATCH v2 14/23] percpu: replace area map allocator with bitmap allocator Josef Bacik
2017-07-25 19:15     ` Josef Bacik
2017-07-25 20:24   ` [PATCH updated 14/23] percpu: replace area map allocator with bitmap Dennis Zhou
2017-07-25 20:24     ` Dennis Zhou
2017-07-24 23:02 ` [PATCH v2 15/23] percpu: introduce bitmap metadata blocks Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 19:20   ` Josef Bacik
2017-07-25 19:20     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 16/23] percpu: add first_bit to keep track of the first free in the bitmap Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 19:21   ` Josef Bacik
2017-07-25 19:21     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 17/23] percpu: skip chunks if the alloc does not fit in the contig hint Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 19:25   ` Josef Bacik
2017-07-25 19:25     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 18/23] percpu: keep track of the best offset for contig hints Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 19:29   ` Josef Bacik
2017-07-25 19:29     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 19/23] percpu: update alloc path to only scan if contig hints are broken Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 19:32   ` Josef Bacik
2017-07-25 19:32     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 20/23] percpu: update free path to take advantage of contig hints Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 19:38   ` Josef Bacik
2017-07-25 19:38     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 21/23] percpu: use metadata blocks to update the chunk contig hint Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 19:40   ` Josef Bacik
2017-07-25 19:40     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 22/23] percpu: update pcpu_find_block_fit to use an iterator Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 19:47   ` Josef Bacik
2017-07-25 19:47     ` Josef Bacik
2017-07-24 23:02 ` [PATCH v2 23/23] percpu: update header to contain bitmap allocator explanation Dennis Zhou
2017-07-24 23:02   ` Dennis Zhou
2017-07-25 19:49   ` Josef Bacik
2017-07-25 19:49     ` Josef Bacik
2017-07-26 21:42   ` Tejun Heo
2017-07-26 21:42     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170725180417.GB18880@destiny \
    --to=josef@toxicpanda.com \
    --cc=cl@linux.com \
    --cc=dennisszhou@gmail.com \
    --cc=dennisz@fb.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.