From: Olaf Hering <olaf@aepfle.de>
To: Eric Blake <eblake@redhat.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Anthony Perard <anthony.perard@citrix.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
"open list:X86" <xen-devel@lists.xenproject.org>,
"open list:Block layer core" <qemu-block@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] xen-disk: use g_malloc0 to fix build
Date: Fri, 28 Jul 2017 14:48:33 +0200 [thread overview]
Message-ID: <20170728124832.GP8603@aepfle.de> (raw)
In-Reply-To: <d8aca223-4007-6524-9876-fe32fd81e893@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 233 bytes --]
On Fri, Jul 28, Eric Blake wrote:
> This version is prone to multiplication overflow (well, maybe not, but
> you have to audit for that). Wouldn't it be better to use:
What could go wrong?
qemu will die either way, I think.
Olaf
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Olaf Hering <olaf@aepfle.de>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
"open list:Block layer core" <qemu-block@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>,
Anthony Perard <anthony.perard@citrix.com>,
"open list:X86" <xen-devel@lists.xenproject.org>
Subject: Re: [Qemu-devel] [PATCH] xen-disk: use g_malloc0 to fix build
Date: Fri, 28 Jul 2017 14:48:33 +0200 [thread overview]
Message-ID: <20170728124832.GP8603@aepfle.de> (raw)
In-Reply-To: <d8aca223-4007-6524-9876-fe32fd81e893@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 233 bytes --]
On Fri, Jul 28, Eric Blake wrote:
> This version is prone to multiplication overflow (well, maybe not, but
> you have to audit for that). Wouldn't it be better to use:
What could go wrong?
qemu will die either way, I think.
Olaf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-07-28 12:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 12:31 [Qemu-devel] [PATCH] xen-disk: use g_malloc0 to fix build Olaf Hering
2017-07-28 12:31 ` Olaf Hering
2017-07-28 12:43 ` [Qemu-devel] " Eric Blake
2017-07-28 12:43 ` Eric Blake
2017-07-28 12:48 ` Olaf Hering [this message]
2017-07-28 12:48 ` Olaf Hering
2017-07-28 13:00 ` Eric Blake
2017-07-28 13:00 ` Eric Blake
2017-07-28 16:35 ` Markus Armbruster
2017-07-28 16:35 ` Markus Armbruster
2017-07-28 12:52 ` Daniel P. Berrange
2017-07-28 12:52 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728124832.GP8603@aepfle.de \
--to=olaf@aepfle.de \
--cc=anthony.perard@citrix.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.