From: Andrew Lunn <andrew@lunn.ch>
To: David Wu <david.wu@rock-chips.com>
Cc: davem@davemloft.net, heiko@sntech.de, f.fainelli@gmail.com,
robh+dt@kernel.org, mark.rutland@arm.com,
catalin.marinas@arm.com, will.deacon@arm.com, olof@lixom.net,
linux@armlinux.org.uk, arnd@arndb.de, peppe.cavallaro@st.com,
alexandre.torgue@st.com, huangtao@rock-chips.com,
hwg@rock-chips.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support
Date: Wed, 2 Aug 2017 15:21:21 +0200 [thread overview]
Message-ID: <20170802132121.GA24708@lunn.ch> (raw)
In-Reply-To: <1501654546-17292-2-git-send-email-david.wu@rock-chips.com>
> +static struct phy_driver rockchip_phy_driver[] = {
> +{
> + .phy_id = 0x1234d400,
> + .phy_id_mask = 0xfffffff0,
> + .name = "Rockchip internal EPHY",
> + .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause
> + | SUPPORTED_Asym_Pause),
Please take a look at Documentation/networking/phy.txt and
Fixes: 529ed1275263 ("net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause")
Pause frames / flow control
The PHY does not participate directly in flow control/pause frames except by
making sure that the SUPPORTED_Pause and SUPPORTED_AsymPause bits are set in
MII_ADVERTISE to indicate towards the link partner that the Ethernet MAC
controller supports such a thing. Since flow control/pause frames generation
involves the Ethernet MAC driver, it is recommended that this driver takes care
of properly indicating advertisement and support for such features by setting
the SUPPORTED_Pause and SUPPORTED_AsymPause bits accordingly. This can be done
either before or after phy_connect() and/or as a result of implementing the
ethtool::set_pauseparam feature.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 01/11] net: phy: Add rockchip phy driver support
Date: Wed, 2 Aug 2017 15:21:21 +0200 [thread overview]
Message-ID: <20170802132121.GA24708@lunn.ch> (raw)
In-Reply-To: <1501654546-17292-2-git-send-email-david.wu@rock-chips.com>
> +static struct phy_driver rockchip_phy_driver[] = {
> +{
> + .phy_id = 0x1234d400,
> + .phy_id_mask = 0xfffffff0,
> + .name = "Rockchip internal EPHY",
> + .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause
> + | SUPPORTED_Asym_Pause),
Please take a look at Documentation/networking/phy.txt and
Fixes: 529ed1275263 ("net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause")
Pause frames / flow control
The PHY does not participate directly in flow control/pause frames except by
making sure that the SUPPORTED_Pause and SUPPORTED_AsymPause bits are set in
MII_ADVERTISE to indicate towards the link partner that the Ethernet MAC
controller supports such a thing. Since flow control/pause frames generation
involves the Ethernet MAC driver, it is recommended that this driver takes care
of properly indicating advertisement and support for such features by setting
the SUPPORTED_Pause and SUPPORTED_AsymPause bits accordingly. This can be done
either before or after phy_connect() and/or as a result of implementing the
ethtool::set_pauseparam feature.
Andrew
next prev parent reply other threads:[~2017-08-02 13:21 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 6:15 [PATCH v3 00/11] Add the internal phy support David Wu
2017-08-02 6:15 ` David Wu
2017-08-02 6:15 ` David Wu
2017-08-02 6:15 ` [PATCH v3 01/11] net: phy: Add rockchip phy driver support David Wu
2017-08-02 6:15 ` David Wu
2017-08-02 6:20 ` Corentin Labbe
2017-08-02 6:20 ` Corentin Labbe
2017-08-02 13:21 ` Andrew Lunn [this message]
2017-08-02 13:21 ` Andrew Lunn
2017-08-09 7:01 ` David.Wu
2017-08-09 7:01 ` David.Wu
2017-08-02 6:15 ` [PATCH v3 02/11] multi_v7_defconfig: Make rockchip phy built-in David Wu
2017-08-02 6:15 ` David Wu
2017-08-02 6:15 ` [PATCH v3 03/11] arm64: defconfig: Enable CONFIG_ROCKCHIP_PHY David Wu
2017-08-02 6:15 ` David Wu
2017-08-02 6:15 ` [PATCH v3 04/11] net: stmmac: dwmac-rk: Remove unwanted code for rk3328_set_to_rmii() David Wu
2017-08-02 6:15 ` David Wu
[not found] ` <1501654546-17292-1-git-send-email-david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-02 6:21 ` [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support David Wu
2017-08-02 6:21 ` David Wu
2017-08-02 6:21 ` David Wu
[not found] ` <1501654888-19514-1-git-send-email-david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-02 17:38 ` Florian Fainelli
2017-08-02 17:38 ` Florian Fainelli
2017-08-02 17:38 ` Florian Fainelli
2017-08-03 11:06 ` Chen-Yu Tsai
2017-08-03 11:06 ` Chen-Yu Tsai
2017-08-03 11:06 ` Chen-Yu Tsai
2017-08-09 8:45 ` Corentin Labbe
2017-08-09 8:45 ` Corentin Labbe
2017-08-09 9:38 ` David.Wu
2017-08-09 9:38 ` David.Wu
2017-08-09 9:38 ` David.Wu
[not found] ` <a9fae87c-9df5-a250-5bc1-230be4af15cd-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-10 2:40 ` Chen-Yu Tsai
2017-08-10 2:40 ` Chen-Yu Tsai
2017-08-10 2:40 ` Chen-Yu Tsai
2017-08-10 7:48 ` David.Wu
2017-08-10 7:48 ` David.Wu
2017-08-10 7:48 ` David.Wu
2017-08-09 22:42 ` Florian Fainelli
2017-08-09 22:42 ` Florian Fainelli
2017-08-03 14:02 ` David.Wu
2017-08-03 14:02 ` David.Wu
2017-08-02 6:23 ` [PATCH v3 07/11] net: stmmac: dwmac-rk: Add internal phy supprot for rk3328 David Wu
2017-08-02 6:23 ` David Wu
2017-08-02 6:23 ` David Wu
2017-08-02 6:23 ` [PATCH v3 08/11] ARM: dts: rk322x: Add support internal phy for gmac David Wu
2017-08-02 6:23 ` David Wu
2017-08-02 6:23 ` David Wu
2017-08-02 6:24 ` [PATCH v3 10/11] ARM64: dts: rockchip: Add gmac2phy node support for rk3328 David Wu
2017-08-02 6:24 ` David Wu
2017-08-02 6:24 ` David Wu
[not found] ` <1501655097-21054-1-git-send-email-david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-02 11:49 ` Sergei Shtylyov
2017-08-02 11:49 ` Sergei Shtylyov
2017-08-02 11:49 ` Sergei Shtylyov
2017-08-02 17:40 ` Florian Fainelli
2017-08-02 17:40 ` Florian Fainelli
2017-08-02 6:26 ` [PATCH v3 11/11] ARM64: dts: rockchip: Enable gmac2phy for rk3328-evb David Wu
2017-08-02 6:26 ` David Wu
2017-08-02 6:26 ` David Wu
2017-08-02 6:22 ` [PATCH v3 06/11] net: stmmac: dwmac-rk: Add internal phy support for rk3228 David Wu
2017-08-02 6:22 ` David Wu
2017-08-02 6:24 ` [PATCH v3 09/11] ARM: dts: rk3228-evb: Enable the internal phy for gmac David Wu
2017-08-02 6:24 ` David Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802132121.GA24708@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=hwg@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.