* [PATCH] ARM: dts: i.MX25: add ranges to tscadc @ 2017-08-02 20:06 ` Martin Kaiser 0 siblings, 0 replies; 12+ messages in thread From: Martin Kaiser @ 2017-08-02 20:06 UTC (permalink / raw) To: linux-arm-kernel Add a ranges; line to the tscadc node. This creates a 1:1 mapping between the addresses used by tscadc and those in its child nodes (adc, tsc). Without such a mapping, the reg = ... lines in the tsc and adc nodes do not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc drivers will then fail since there's no IORESOURCE_MEM. Signed-off-by: Martin Kaiser <martin@kaiser.cx> --- arch/arm/boot/dts/imx25.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index 0d2f3a1..1e37bd3 100644 --- a/arch/arm/boot/dts/imx25.dtsi +++ b/arch/arm/boot/dts/imx25.dtsi @@ -297,6 +297,7 @@ #address-cells = <1>; #size-cells = <1>; status = "disabled"; + ranges; adc: adc at 50030800 { compatible = "fsl,imx25-gcq"; -- 2.1.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: i.MX25: add ranges to tscadc @ 2017-08-02 20:06 ` Martin Kaiser 0 siblings, 0 replies; 12+ messages in thread From: Martin Kaiser @ 2017-08-02 20:06 UTC (permalink / raw) To: Markus Pargmann, Shawn Guo Cc: Denis Carikli, devicetree, Rob Herring, kernel, linux-arm-kernel, linux-kernel, Martin Kaiser Add a ranges; line to the tscadc node. This creates a 1:1 mapping between the addresses used by tscadc and those in its child nodes (adc, tsc). Without such a mapping, the reg = ... lines in the tsc and adc nodes do not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc drivers will then fail since there's no IORESOURCE_MEM. Signed-off-by: Martin Kaiser <martin@kaiser.cx> --- arch/arm/boot/dts/imx25.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index 0d2f3a1..1e37bd3 100644 --- a/arch/arm/boot/dts/imx25.dtsi +++ b/arch/arm/boot/dts/imx25.dtsi @@ -297,6 +297,7 @@ #address-cells = <1>; #size-cells = <1>; status = "disabled"; + ranges; adc: adc@50030800 { compatible = "fsl,imx25-gcq"; -- 2.1.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: i.MX25: add ranges to tscadc @ 2017-08-02 20:06 ` Martin Kaiser 0 siblings, 0 replies; 12+ messages in thread From: Martin Kaiser @ 2017-08-02 20:06 UTC (permalink / raw) To: Markus Pargmann, Shawn Guo Cc: Denis Carikli, devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring, kernel-bIcnvbaLZ9MEGnE8C9+IrQ, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Martin Kaiser Add a ranges; line to the tscadc node. This creates a 1:1 mapping between the addresses used by tscadc and those in its child nodes (adc, tsc). Without such a mapping, the reg = ... lines in the tsc and adc nodes do not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc drivers will then fail since there's no IORESOURCE_MEM. Signed-off-by: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org> --- arch/arm/boot/dts/imx25.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index 0d2f3a1..1e37bd3 100644 --- a/arch/arm/boot/dts/imx25.dtsi +++ b/arch/arm/boot/dts/imx25.dtsi @@ -297,6 +297,7 @@ #address-cells = <1>; #size-cells = <1>; status = "disabled"; + ranges; adc: adc@50030800 { compatible = "fsl,imx25-gcq"; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: i.MX25: add ranges to tscadc @ 2017-08-03 2:20 ` Shawn Guo 0 siblings, 0 replies; 12+ messages in thread From: Shawn Guo @ 2017-08-03 2:20 UTC (permalink / raw) To: linux-arm-kernel On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote: > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between > the addresses used by tscadc and those in its child nodes (adc, tsc). > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc > drivers will then fail since there's no IORESOURCE_MEM. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> Do we need the following Fixes tag? Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support") @Markus, we didn't the changes when we were submitting? Shawn > --- > arch/arm/boot/dts/imx25.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > index 0d2f3a1..1e37bd3 100644 > --- a/arch/arm/boot/dts/imx25.dtsi > +++ b/arch/arm/boot/dts/imx25.dtsi > @@ -297,6 +297,7 @@ > #address-cells = <1>; > #size-cells = <1>; > status = "disabled"; > + ranges; > > adc: adc at 50030800 { > compatible = "fsl,imx25-gcq"; > -- > 2.1.4 > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc @ 2017-08-03 2:20 ` Shawn Guo 0 siblings, 0 replies; 12+ messages in thread From: Shawn Guo @ 2017-08-03 2:20 UTC (permalink / raw) To: Martin Kaiser Cc: Markus Pargmann, Denis Carikli, devicetree, Rob Herring, kernel, linux-arm-kernel, linux-kernel On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote: > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between > the addresses used by tscadc and those in its child nodes (adc, tsc). > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc > drivers will then fail since there's no IORESOURCE_MEM. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> Do we need the following Fixes tag? Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support") @Markus, we didn't the changes when we were submitting? Shawn > --- > arch/arm/boot/dts/imx25.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > index 0d2f3a1..1e37bd3 100644 > --- a/arch/arm/boot/dts/imx25.dtsi > +++ b/arch/arm/boot/dts/imx25.dtsi > @@ -297,6 +297,7 @@ > #address-cells = <1>; > #size-cells = <1>; > status = "disabled"; > + ranges; > > adc: adc@50030800 { > compatible = "fsl,imx25-gcq"; > -- > 2.1.4 > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc @ 2017-08-03 2:20 ` Shawn Guo 0 siblings, 0 replies; 12+ messages in thread From: Shawn Guo @ 2017-08-03 2:20 UTC (permalink / raw) To: Martin Kaiser Cc: Markus Pargmann, Denis Carikli, devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring, kernel-bIcnvbaLZ9MEGnE8C9+IrQ, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote: > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between > the addresses used by tscadc and those in its child nodes (adc, tsc). > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc > drivers will then fail since there's no IORESOURCE_MEM. > > Signed-off-by: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org> Do we need the following Fixes tag? Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support") @Markus, we didn't the changes when we were submitting? Shawn > --- > arch/arm/boot/dts/imx25.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > index 0d2f3a1..1e37bd3 100644 > --- a/arch/arm/boot/dts/imx25.dtsi > +++ b/arch/arm/boot/dts/imx25.dtsi > @@ -297,6 +297,7 @@ > #address-cells = <1>; > #size-cells = <1>; > status = "disabled"; > + ranges; > > adc: adc@50030800 { > compatible = "fsl,imx25-gcq"; > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: i.MX25: add ranges to tscadc 2017-08-03 2:20 ` Shawn Guo (?) @ 2017-08-03 16:29 ` Martin Kaiser -1 siblings, 0 replies; 12+ messages in thread From: Martin Kaiser @ 2017-08-03 16:29 UTC (permalink / raw) To: linux-arm-kernel Hi Shawn, Thus wrote Shawn Guo (shawnguo at kernel.org): > On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote: > > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between > > the addresses used by tscadc and those in its child nodes (adc, tsc). > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do > > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc > > drivers will then fail since there's no IORESOURCE_MEM. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > Do we need the following Fixes tag? > Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support") yes, looks like this has never worked correctly. If you're ok with the fix, I can add the tag in v2. > @Markus, we didn't the changes when we were submitting? Both Markus' and Denis' mail addresses bounced... Best regards, Martin ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc @ 2017-08-03 16:29 ` Martin Kaiser 0 siblings, 0 replies; 12+ messages in thread From: Martin Kaiser @ 2017-08-03 16:29 UTC (permalink / raw) To: Shawn Guo Cc: Markus Pargmann, Denis Carikli, devicetree, Rob Herring, kernel, linux-arm-kernel, linux-kernel Hi Shawn, Thus wrote Shawn Guo (shawnguo@kernel.org): > On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote: > > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between > > the addresses used by tscadc and those in its child nodes (adc, tsc). > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do > > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc > > drivers will then fail since there's no IORESOURCE_MEM. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > Do we need the following Fixes tag? > Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support") yes, looks like this has never worked correctly. If you're ok with the fix, I can add the tag in v2. > @Markus, we didn't the changes when we were submitting? Both Markus' and Denis' mail addresses bounced... Best regards, Martin ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc @ 2017-08-03 16:29 ` Martin Kaiser 0 siblings, 0 replies; 12+ messages in thread From: Martin Kaiser @ 2017-08-03 16:29 UTC (permalink / raw) To: Shawn Guo Cc: Markus Pargmann, Denis Carikli, devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring, kernel-bIcnvbaLZ9MEGnE8C9+IrQ, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA Hi Shawn, Thus wrote Shawn Guo (shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org): > On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote: > > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between > > the addresses used by tscadc and those in its child nodes (adc, tsc). > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do > > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc > > drivers will then fail since there's no IORESOURCE_MEM. > > Signed-off-by: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org> > Do we need the following Fixes tag? > Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support") yes, looks like this has never worked correctly. If you're ok with the fix, I can add the tag in v2. > @Markus, we didn't the changes when we were submitting? Both Markus' and Denis' mail addresses bounced... Best regards, Martin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: i.MX25: add ranges to tscadc @ 2017-08-05 5:31 ` Shawn Guo 0 siblings, 0 replies; 12+ messages in thread From: Shawn Guo @ 2017-08-05 5:31 UTC (permalink / raw) To: linux-arm-kernel On Thu, Aug 03, 2017 at 06:29:48PM +0200, Martin Kaiser wrote: > Hi Shawn, > > Thus wrote Shawn Guo (shawnguo at kernel.org): > > > On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote: > > > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between > > > the addresses used by tscadc and those in its child nodes (adc, tsc). > > > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do > > > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc > > > drivers will then fail since there's no IORESOURCE_MEM. > > > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > > > Do we need the following Fixes tag? > > > Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support") > > yes, looks like this has never worked correctly. > > If you're ok with the fix, I can add the tag in v2. I added the Fixes tag and applied the patch. Thanks. Shawn ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc @ 2017-08-05 5:31 ` Shawn Guo 0 siblings, 0 replies; 12+ messages in thread From: Shawn Guo @ 2017-08-05 5:31 UTC (permalink / raw) To: Martin Kaiser Cc: Markus Pargmann, Denis Carikli, devicetree, Rob Herring, kernel, linux-arm-kernel, linux-kernel On Thu, Aug 03, 2017 at 06:29:48PM +0200, Martin Kaiser wrote: > Hi Shawn, > > Thus wrote Shawn Guo (shawnguo@kernel.org): > > > On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote: > > > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between > > > the addresses used by tscadc and those in its child nodes (adc, tsc). > > > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do > > > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc > > > drivers will then fail since there's no IORESOURCE_MEM. > > > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > > > Do we need the following Fixes tag? > > > Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support") > > yes, looks like this has never worked correctly. > > If you're ok with the fix, I can add the tag in v2. I added the Fixes tag and applied the patch. Thanks. Shawn ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc @ 2017-08-05 5:31 ` Shawn Guo 0 siblings, 0 replies; 12+ messages in thread From: Shawn Guo @ 2017-08-05 5:31 UTC (permalink / raw) To: Martin Kaiser Cc: Markus Pargmann, Denis Carikli, devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring, kernel-bIcnvbaLZ9MEGnE8C9+IrQ, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Thu, Aug 03, 2017 at 06:29:48PM +0200, Martin Kaiser wrote: > Hi Shawn, > > Thus wrote Shawn Guo (shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org): > > > On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote: > > > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between > > > the addresses used by tscadc and those in its child nodes (adc, tsc). > > > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do > > > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc > > > drivers will then fail since there's no IORESOURCE_MEM. > > > > Signed-off-by: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org> > > > Do we need the following Fixes tag? > > > Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support") > > yes, looks like this has never worked correctly. > > If you're ok with the fix, I can add the tag in v2. I added the Fixes tag and applied the patch. Thanks. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-08-05 5:32 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-08-02 20:06 [PATCH] ARM: dts: i.MX25: add ranges to tscadc Martin Kaiser 2017-08-02 20:06 ` Martin Kaiser 2017-08-02 20:06 ` Martin Kaiser 2017-08-03 2:20 ` Shawn Guo 2017-08-03 2:20 ` Shawn Guo 2017-08-03 2:20 ` Shawn Guo 2017-08-03 16:29 ` Martin Kaiser 2017-08-03 16:29 ` Martin Kaiser 2017-08-03 16:29 ` Martin Kaiser 2017-08-05 5:31 ` Shawn Guo 2017-08-05 5:31 ` Shawn Guo 2017-08-05 5:31 ` Shawn Guo
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.