From: Will Deacon <will.deacon@arm.com>
To: Miles Chen <miles.chen@mediatek.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
wsd_upstream@mediatek.com, ard.biesheuvel@linaro.org
Subject: Re: [PATCH] arm64: correct modules range of kernel virtual memory layout
Date: Mon, 7 Aug 2017 14:16:09 +0100 [thread overview]
Message-ID: <20170807131608.GA18817@arm.com> (raw)
In-Reply-To: <1502103886-19725-1-git-send-email-miles.chen@mediatek.com>
On Mon, Aug 07, 2017 at 07:04:46PM +0800, Miles Chen wrote:
> The commit f80fb3a3d508 ("arm64: add support for kernel ASLR")
> moved module virtual address to
> [module_alloc_base, module_alloc_base + MODULES_VSIZE).
>
> Display module information of the virtual kernel
> memory layout by using module_alloc_base.
>
> testing output:
> 1) Current implementation:
> Virtual kernel memory layout:
> modules : 0xffffff8000000000 - 0xffffff8008000000 ( 128 MB)
> 2) this patch + KASLR:
> Virtual kernel memory layout:
> modules : 0xffffff8000560000 - 0xffffff8008560000 ( 128 MB)
> 3) this patch + KASLR and a dummy seed:
> Virtual kernel memory layout:
> modules : 0xffffffa7df637000 - 0xffffffa7e7637000 ( 128 MB)
>
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> ---
> arch/arm64/mm/init.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Does this mean the modules code in our pt dumper is busted
(arch/arm64/mm/dump.c)? Also, what about KASAN, which uses these addresses
too (in kasan_init)? Should we just remove MODULES_VADDR and MODULES_END
altogether?
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: correct modules range of kernel virtual memory layout
Date: Mon, 7 Aug 2017 14:16:09 +0100 [thread overview]
Message-ID: <20170807131608.GA18817@arm.com> (raw)
In-Reply-To: <1502103886-19725-1-git-send-email-miles.chen@mediatek.com>
On Mon, Aug 07, 2017 at 07:04:46PM +0800, Miles Chen wrote:
> The commit f80fb3a3d508 ("arm64: add support for kernel ASLR")
> moved module virtual address to
> [module_alloc_base, module_alloc_base + MODULES_VSIZE).
>
> Display module information of the virtual kernel
> memory layout by using module_alloc_base.
>
> testing output:
> 1) Current implementation:
> Virtual kernel memory layout:
> modules : 0xffffff8000000000 - 0xffffff8008000000 ( 128 MB)
> 2) this patch + KASLR:
> Virtual kernel memory layout:
> modules : 0xffffff8000560000 - 0xffffff8008560000 ( 128 MB)
> 3) this patch + KASLR and a dummy seed:
> Virtual kernel memory layout:
> modules : 0xffffffa7df637000 - 0xffffffa7e7637000 ( 128 MB)
>
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> ---
> arch/arm64/mm/init.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Does this mean the modules code in our pt dumper is busted
(arch/arm64/mm/dump.c)? Also, what about KASAN, which uses these addresses
too (in kasan_init)? Should we just remove MODULES_VADDR and MODULES_END
altogether?
Will
next prev parent reply other threads:[~2017-08-07 13:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 11:04 [PATCH] arm64: correct modules range of kernel virtual memory layout Miles Chen
2017-08-07 11:04 ` Miles Chen
2017-08-07 11:04 ` Miles Chen
2017-08-07 13:16 ` Will Deacon [this message]
2017-08-07 13:16 ` Will Deacon
2017-08-07 13:18 ` Ard Biesheuvel
2017-08-07 13:18 ` Ard Biesheuvel
2017-08-07 13:36 ` Miles Chen
2017-08-07 13:36 ` Miles Chen
2017-08-07 13:36 ` Miles Chen
2017-08-07 13:42 ` Ard Biesheuvel
2017-08-07 13:42 ` Ard Biesheuvel
2017-08-07 14:01 ` Will Deacon
2017-08-07 14:01 ` Will Deacon
2017-08-08 4:44 ` Miles Chen
2017-08-08 4:44 ` Miles Chen
2017-08-08 4:44 ` Miles Chen
2017-08-08 5:27 ` Miles Chen
2017-08-08 5:27 ` Miles Chen
2017-08-08 5:27 ` Miles Chen
2017-08-08 13:19 ` Will Deacon
2017-08-08 13:19 ` Will Deacon
2017-08-08 14:04 ` Ard Biesheuvel
2017-08-08 14:04 ` Ard Biesheuvel
2017-08-08 14:18 ` Will Deacon
2017-08-08 14:18 ` Will Deacon
2017-08-08 14:25 ` Ard Biesheuvel
2017-08-08 14:25 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807131608.GA18817@arm.com \
--to=will.deacon@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=miles.chen@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.