* [PATCH] v4l2-compat-ioctl32.c: add capabilities field to, v4l2_input32
@ 2017-08-04 11:25 Hans Verkuil
2017-08-11 0:17 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2017-08-04 11:25 UTC (permalink / raw)
To: Linux Media Mailing List
The v4l2_input32 struct wasn't updated when this field was added.
It didn't cause a failure in the compat code, but it is better to
keep it in sync with v4l2_input to avoid confusion.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
---
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
index 6f52970f8b54..90827073066f 100644
--- a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
+++ b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
@@ -627,7 +627,8 @@ struct v4l2_input32 {
__u32 tuner; /* Associated tuner */
compat_u64 std;
__u32 status;
- __u32 reserved[4];
+ __u32 capabilities;
+ __u32 reserved[3];
};
/* The 64-bit v4l2_input struct has extra padding at the end of the struct.
--
2.13.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] v4l2-compat-ioctl32.c: add capabilities field to, v4l2_input32
2017-08-04 11:25 [PATCH] v4l2-compat-ioctl32.c: add capabilities field to, v4l2_input32 Hans Verkuil
@ 2017-08-11 0:17 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2017-08-11 0:17 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List
Em Fri, 4 Aug 2017 13:25:06 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> The v4l2_input32 struct wasn't updated when this field was added.
> It didn't cause a failure in the compat code, but it is better to
> keep it in sync with v4l2_input to avoid confusion.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Looks good to me.
Reviewed-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> ---
> drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
> index 6f52970f8b54..90827073066f 100644
> --- a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
> +++ b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
> @@ -627,7 +627,8 @@ struct v4l2_input32 {
> __u32 tuner; /* Associated tuner */
> compat_u64 std;
> __u32 status;
> - __u32 reserved[4];
> + __u32 capabilities;
> + __u32 reserved[3];
> };
>
> /* The 64-bit v4l2_input struct has extra padding at the end of the struct.
Thanks,
Mauro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-11 0:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-04 11:25 [PATCH] v4l2-compat-ioctl32.c: add capabilities field to, v4l2_input32 Hans Verkuil
2017-08-11 0:17 ` Mauro Carvalho Chehab
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.