From: Matthias Kaehlcke <mka@chromium.org>
To: Daniel Vetter <daniel@ffwll.ch>,
Jani Nikula <jani.nikula@linux.intel.com>,
David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@intel.com>,
Manasi Navare <manasi.d.navare@intel.com>,
rodrigo.vivi@intel.com, clinton.a.taylor@intel.com
Cc: Grant Grundler <grundler@chromium.org>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V
Date: Fri, 11 Aug 2017 11:32:43 -0700 [thread overview]
Message-ID: <20170811183243.GB109008@google.com> (raw)
In-Reply-To: <20170717195854.192139-1-mka@chromium.org>
El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit:
> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
> Use the correct table.
>
> The error was pointed out by this clang warning:
>
> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
> 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
> [-Wunneeded-internal-declaration]
> static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
>
> Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> Changes in v2:
> - Added 'Fixes' tag
> - Added Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
ping, it seems this patch went under the radar.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org>
To: Daniel Vetter <daniel@ffwll.ch>,
Jani Nikula <jani.nikula@linux.intel.com>,
David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@intel.com>,
Manasi Navare <manasi.d.navare@intel.com>,
rodrigo.vivi@intel.com, clinton.a.taylor@intel.com
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel@lists.freedesktop.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Stéphane Marchesin" <stephane.marchesin@gmail.com>,
"Grant Grundler" <grundler@chromium.org>
Subject: Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V
Date: Fri, 11 Aug 2017 11:32:43 -0700 [thread overview]
Message-ID: <20170811183243.GB109008@google.com> (raw)
In-Reply-To: <20170717195854.192139-1-mka@chromium.org>
El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit:
> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
> Use the correct table.
>
> The error was pointed out by this clang warning:
>
> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
> 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
> [-Wunneeded-internal-declaration]
> static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
>
> Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> Changes in v2:
> - Added 'Fixes' tag
> - Added Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
ping, it seems this patch went under the radar.
next prev parent reply other threads:[~2017-08-11 18:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 19:58 [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V Matthias Kaehlcke
2017-07-17 19:58 ` Matthias Kaehlcke
2017-07-17 20:16 ` ✓ Fi.CI.BAT: success for drm/i915: Return correct EDP voltage swing table for 0.85V (rev2) Patchwork
2017-08-11 18:32 ` Matthias Kaehlcke [this message]
2017-08-11 18:32 ` [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V Matthias Kaehlcke
2017-08-11 18:38 ` Rodrigo Vivi
2017-08-11 18:38 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811183243.GB109008@google.com \
--to=mka@chromium.org \
--cc=airlied@linux.ie \
--cc=clinton.a.taylor@intel.com \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=grundler@chromium.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manasi.d.navare@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.