From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: jack-AlSwsSmVLrQ@public.gmane.org,
"Darrick J. Wong"
<darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hch-jcswGhMUV9g@public.gmane.org
Subject: Re: [PATCH v2 1/2] fs, xfs: perform dax_device lookup at mount
Date: Tue, 29 Aug 2017 23:26:06 +0200 [thread overview]
Message-ID: <20170829212606.GC8608@lst.de> (raw)
In-Reply-To: <150389212075.25151.17146973298430877023.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Call me nitpicky, but..
First this really should be three patches, one for the DAX code, one
for the VFS code and one for XFS. The DAX and XFS bits looks fine to
me:
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
But I'm a little worried about stuffing more DAX knowledge into the
block mount_bdev helper. For now it's probably ok as everything
else would involve a lot of refactoring and/or duplication, but
I'm generally not too happy about it.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: jack@suse.cz, "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
hch@lst.de
Subject: Re: [PATCH v2 1/2] fs, xfs: perform dax_device lookup at mount
Date: Tue, 29 Aug 2017 23:26:06 +0200 [thread overview]
Message-ID: <20170829212606.GC8608@lst.de> (raw)
In-Reply-To: <150389212075.25151.17146973298430877023.stgit@dwillia2-desk3.amr.corp.intel.com>
Call me nitpicky, but..
First this really should be three patches, one for the DAX code, one
for the VFS code and one for XFS. The DAX and XFS bits looks fine to
me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But I'm a little worried about stuffing more DAX knowledge into the
block mount_bdev helper. For now it's probably ok as everything
else would involve a lot of refactoring and/or duplication, but
I'm generally not too happy about it.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz,
linux-nvdimm@lists.01.org,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
hch@lst.de
Subject: Re: [PATCH v2 1/2] fs, xfs: perform dax_device lookup at mount
Date: Tue, 29 Aug 2017 23:26:06 +0200 [thread overview]
Message-ID: <20170829212606.GC8608@lst.de> (raw)
In-Reply-To: <150389212075.25151.17146973298430877023.stgit@dwillia2-desk3.amr.corp.intel.com>
Call me nitpicky, but..
First this really should be three patches, one for the DAX code, one
for the VFS code and one for XFS. The DAX and XFS bits looks fine to
me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But I'm a little worried about stuffing more DAX knowledge into the
block mount_bdev helper. For now it's probably ok as everything
else would involve a lot of refactoring and/or duplication, but
I'm generally not too happy about it.
next prev parent reply other threads:[~2017-08-29 21:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 3:48 [PATCH v2 0/2] fs, dax: lookup dax_device at mount time Dan Williams
2017-08-28 3:48 ` Dan Williams
[not found] ` <150389211501.25151.6477753201827914462.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-08-28 3:48 ` [PATCH v2 1/2] fs, xfs: perform dax_device lookup at mount Dan Williams
2017-08-28 3:48 ` Dan Williams
2017-08-28 3:48 ` Dan Williams
2017-08-28 16:28 ` Darrick J. Wong
2017-08-28 16:28 ` Darrick J. Wong
[not found] ` <150389212075.25151.17146973298430877023.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-08-28 8:31 ` Jan Kara
2017-08-28 8:31 ` Jan Kara
2017-08-28 8:31 ` Jan Kara
2017-08-29 21:26 ` Christoph Hellwig [this message]
2017-08-29 21:26 ` Christoph Hellwig
2017-08-29 21:26 ` Christoph Hellwig
[not found] ` <20170829212606.GC8608-jcswGhMUV9g@public.gmane.org>
2017-08-29 21:31 ` Dan Williams
2017-08-29 21:31 ` Dan Williams
2017-08-29 21:31 ` Dan Williams
[not found] ` <CAPcyv4hA_vkSdZowaJ78FPCOhY2Z_iORX0B63=_RCCGdqack_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-29 21:35 ` Dan Williams
2017-08-29 21:35 ` Dan Williams
2017-08-29 21:35 ` Dan Williams
[not found] ` <CAPcyv4i2rS0sAxiJSVxFSHirsycaYofuxp3yPxeyB8xzsryx3g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-29 21:36 ` Christoph Hellwig
2017-08-29 21:36 ` Christoph Hellwig
2017-08-29 21:36 ` Christoph Hellwig
2017-08-28 3:48 ` [PATCH v2 2/2] ext2, ext4: use the super_block dax_device Dan Williams
2017-08-28 3:48 ` Dan Williams
2017-08-28 3:48 ` Dan Williams
[not found] ` <150389212595.25151.10721705529768874001.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-08-28 8:27 ` Jan Kara
2017-08-28 8:27 ` Jan Kara
2017-08-28 8:27 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829212606.GC8608@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.