* [PATCH] nvme-cli: generate spec-compliant UUID NQNs
@ 2017-08-30 22:25 Daniel Verkamp
2017-08-31 9:14 ` Christoph Hellwig
2017-08-31 17:06 ` Keith Busch
0 siblings, 2 replies; 3+ messages in thread
From: Daniel Verkamp @ 2017-08-30 22:25 UTC (permalink / raw)
The gen-hostnqn command previously generated UUID NQNs in a format that
does not match the NVMe specification.
Signed-off-by: Daniel Verkamp <daniel.verkamp at intel.com>
---
Documentation/nvme-gen-hostnqn.txt | 2 +-
nvme.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/nvme-gen-hostnqn.txt b/Documentation/nvme-gen-hostnqn.txt
index 6d5346f..9efefb5 100644
--- a/Documentation/nvme-gen-hostnqn.txt
+++ b/Documentation/nvme-gen-hostnqn.txt
@@ -13,7 +13,7 @@ SYNOPSIS
DESCRIPTION
-----------
Generate a random host NQN in the form:
-nqn.2014-08.org.nvmexpress:NVMf:uuid:1b4e28ba-2fa1-11d2-883f-0016d3cca427
+nqn.2014-08.org.nvmexpress:uuid:1b4e28ba-2fa1-11d2-883f-0016d3cca427
and prints it to stdout.
OPTIONS
diff --git a/nvme.c b/nvme.c
index 676e8bf..f1d6d65 100644
--- a/nvme.c
+++ b/nvme.c
@@ -3217,7 +3217,7 @@ static int gen_hostnqn_cmd(int argc, char **argv, struct command *command, struc
uuid_generate_random(uuid);
uuid_unparse_lower(uuid, uuid_str);
- printf("nqn.2014-08.org.nvmexpress:NVMf:uuid:%s\n", uuid_str);
+ printf("nqn.2014-08.org.nvmexpress:uuid:%s\n", uuid_str);
return 0;
}
#else
--
2.13.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] nvme-cli: generate spec-compliant UUID NQNs
2017-08-30 22:25 [PATCH] nvme-cli: generate spec-compliant UUID NQNs Daniel Verkamp
@ 2017-08-31 9:14 ` Christoph Hellwig
2017-08-31 17:06 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-08-31 9:14 UTC (permalink / raw)
Looks good,
Reviewed-by: Christoph Hellwig <hch at lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nvme-cli: generate spec-compliant UUID NQNs
2017-08-30 22:25 [PATCH] nvme-cli: generate spec-compliant UUID NQNs Daniel Verkamp
2017-08-31 9:14 ` Christoph Hellwig
@ 2017-08-31 17:06 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2017-08-31 17:06 UTC (permalink / raw)
On Wed, Aug 30, 2017@03:25:16PM -0700, Daniel Verkamp wrote:
> The gen-hostnqn command previously generated UUID NQNs in a format that
> does not match the NVMe specification.
>
> Signed-off-by: Daniel Verkamp <daniel.verkamp at intel.com>
Applied, thanks for the fix!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-31 17:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-30 22:25 [PATCH] nvme-cli: generate spec-compliant UUID NQNs Daniel Verkamp
2017-08-31 9:14 ` Christoph Hellwig
2017-08-31 17:06 ` Keith Busch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.