From: Rocco Folino <rocco.folino@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Antony Pavlov <antonynpavlov@gmail.com>,
Alban Bedel <albeu@free.fr>, John Crispin <john@phrozen.org>
Subject: Re: [PATCH] MIPS: ath79: support devicetree selection
Date: Wed, 6 Sep 2017 14:01:44 +0200 [thread overview]
Message-ID: <20170906120144.GA20147@void> (raw)
In-Reply-To: <20170906111435.GA1856@linux-mips.org>
On Wed, Sep 06, 2017 at 01:14:35PM +0200, Ralf Baechle wrote:
> On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
>
> > Allow to choose devicetrees from Kconfig.
> >
> > Signed-off-by: Rocco Folino <rocco.folino@gmail.com>
> > ---
> > arch/mips/ath79/Kconfig | 44 +++++++++++++++++++++++++++++++++++++++++
> > arch/mips/boot/dts/qca/Makefile | 10 +++++-----
> > 2 files changed, 49 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/mips/ath79/Kconfig b/arch/mips/ath79/Kconfig
> > index dfc60209dc63..b43d116187af 100644
> > --- a/arch/mips/ath79/Kconfig
> > +++ b/arch/mips/ath79/Kconfig
> > @@ -1,5 +1,49 @@
> > if ATH79
> >
> > +menu "Atheros AR71XX/AR724X/AR913X devicetree selection"
> > +
> > +config DTB_ATH_DPT_MODULE
> > + bool "DPTechnics DPT-Module"
> > + select SOC_933X
>
> There is no symbol SOC_933X. Did you mean SOC_AR933X?
Yes, right
>
> Anyway, your patch does more than the changelog ("Allow to choose
> devicetrees from Kconfig") says, so please either fix the changelog
> or split that into multiple patches with proper changelogs.
Ok, I'll fix everything in the v2
thanks for the comments.
Rocco
WARNING: multiple messages have this Message-ID (diff)
From: Rocco Folino <rocco.folino-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Antony Pavlov
<antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Alban Bedel <albeu-GANU6spQydw@public.gmane.org>,
John Crispin <john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
Subject: Re: [PATCH] MIPS: ath79: support devicetree selection
Date: Wed, 6 Sep 2017 14:01:44 +0200 [thread overview]
Message-ID: <20170906120144.GA20147@void> (raw)
In-Reply-To: <20170906111435.GA1856-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
On Wed, Sep 06, 2017 at 01:14:35PM +0200, Ralf Baechle wrote:
> On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
>
> > Allow to choose devicetrees from Kconfig.
> >
> > Signed-off-by: Rocco Folino <rocco.folino-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> > arch/mips/ath79/Kconfig | 44 +++++++++++++++++++++++++++++++++++++++++
> > arch/mips/boot/dts/qca/Makefile | 10 +++++-----
> > 2 files changed, 49 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/mips/ath79/Kconfig b/arch/mips/ath79/Kconfig
> > index dfc60209dc63..b43d116187af 100644
> > --- a/arch/mips/ath79/Kconfig
> > +++ b/arch/mips/ath79/Kconfig
> > @@ -1,5 +1,49 @@
> > if ATH79
> >
> > +menu "Atheros AR71XX/AR724X/AR913X devicetree selection"
> > +
> > +config DTB_ATH_DPT_MODULE
> > + bool "DPTechnics DPT-Module"
> > + select SOC_933X
>
> There is no symbol SOC_933X. Did you mean SOC_AR933X?
Yes, right
>
> Anyway, your patch does more than the changelog ("Allow to choose
> devicetrees from Kconfig") says, so please either fix the changelog
> or split that into multiple patches with proper changelogs.
Ok, I'll fix everything in the v2
thanks for the comments.
Rocco
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-06 12:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 15:32 [PATCH] MIPS: ath79: support devicetree selection Rocco Folino
2017-09-06 11:14 ` Ralf Baechle
2017-09-06 11:14 ` Ralf Baechle
2017-09-06 12:01 ` Rocco Folino [this message]
2017-09-06 12:01 ` Rocco Folino
2017-09-06 12:20 ` Alban
2017-09-06 12:32 ` Rocco Folino
2017-09-06 12:32 ` Rocco Folino
2017-09-06 13:35 ` Alban
2017-09-06 13:59 ` Rocco Folino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906120144.GA20147@void \
--to=rocco.folino@gmail.com \
--cc=albeu@free.fr \
--cc=antonynpavlov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.