From: Alban <albeu@free.fr>
To: Rocco Folino <rocco.folino@gmail.com>
Cc: Alban <albeu@free.fr>, Ralf Baechle <ralf@linux-mips.org>,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Antony Pavlov <antonynpavlov@gmail.com>,
John Crispin <john@phrozen.org>
Subject: Re: [PATCH] MIPS: ath79: support devicetree selection
Date: Wed, 6 Sep 2017 15:35:43 +0200 [thread overview]
Message-ID: <20170906153543.412774d5@avionic-0141> (raw)
In-Reply-To: <20170906123200.GA21761@void>
[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]
On Wed, 6 Sep 2017 14:32:00 +0200
Rocco Folino <rocco.folino@gmail.com> wrote:
> On Wed, Sep 06, 2017 at 02:20:05PM +0200, Alban wrote:
> > On Wed, 6 Sep 2017 13:14:35 +0200
> > Ralf Baechle <ralf@linux-mips.org> wrote:
> >
> > > On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> > >
> > > > Allow to choose devicetrees from Kconfig.
> > > >
> > > > Signed-off-by: Rocco Folino <rocco.folino@gmail.com>
> >
> > I don't really see the point of this patch. Building the dtb doesn't
> > take any significant time, so why add this extra complexity?
>
> Because you need to select the SoC type in order to enable some
> drivers, for example on the AR9331 to use the serial you need the
> CONFIG_SERIAL_AR933X which depends on the CONFIG_SOC_AR933X.
Seeing as this driver is the only one that make use of CONFIG_SOC_AR933X
I would prefer removing this dependency. It would also open the way to have
the driver built in COMPILE_TEST. A few more fixes might be needed but that
would be better than such a workaround.
Alban
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-09-06 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 15:32 [PATCH] MIPS: ath79: support devicetree selection Rocco Folino
2017-09-06 11:14 ` Ralf Baechle
2017-09-06 11:14 ` Ralf Baechle
2017-09-06 12:01 ` Rocco Folino
2017-09-06 12:01 ` Rocco Folino
2017-09-06 12:20 ` Alban
2017-09-06 12:32 ` Rocco Folino
2017-09-06 12:32 ` Rocco Folino
2017-09-06 13:35 ` Alban [this message]
2017-09-06 13:59 ` Rocco Folino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906153543.412774d5@avionic-0141 \
--to=albeu@free.fr \
--cc=antonynpavlov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=rocco.folino@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.