[PATCH] MIPS: ath79: support devicetree selection

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] MIPS: ath79: support devicetree selection
@ 2017-08-18 15:32 Rocco Folino
  2017-09-06 11:14   ` Ralf Baechle
  0 siblings, 1 reply; 10+ messages in thread
From: Rocco Folino @ 2017-08-18 15:32 UTC (permalink / raw)
  To: ralf, robh+dt, mark.rutland
  Cc: linux-mips, linux-kernel, devicetree, Rocco Folino

Allow to choose devicetrees from Kconfig.

Signed-off-by: Rocco Folino <rocco.folino@gmail.com>
---
 arch/mips/ath79/Kconfig         | 44 +++++++++++++++++++++++++++++++++++++++++
 arch/mips/boot/dts/qca/Makefile | 10 +++++-----
 2 files changed, 49 insertions(+), 5 deletions(-)

diff --git a/arch/mips/ath79/Kconfig b/arch/mips/ath79/Kconfig
index dfc60209dc63..b43d116187af 100644
--- a/arch/mips/ath79/Kconfig
+++ b/arch/mips/ath79/Kconfig
@@ -1,5 +1,49 @@
 if ATH79
 
+menu "Atheros AR71XX/AR724X/AR913X devicetree selection"
+
+config DTB_ATH_DPT_MODULE
+	bool "DPTechnics DPT-Module"
+	select SOC_933X
+	select BUILTIN_DTB
+	help
+	  Say 'Y' if you want your kernel to support the
+	  DPTechnics DPT-Module board.
+
+config DTB_ATH_DRAGINO_MS14
+	bool "Dragino MS14 (Dragino 2)"
+	select SOC_AR933X
+	select BUILTIN_DTB
+	help
+	  Say 'Y' if you want your kernel to support the
+	  Dragino MS14 board.
+
+config DTB_ATH_OMEGA
+	bool "Onion Omega"
+	select SOC_AR933X
+	select BUILTIN_DTB
+	help
+	  Say 'Y' if you want your kernel to support the
+	  Onion Omega board.
+
+config DTB_ATH_TL_MR3020
+	bool "TP-Link TL-MR3020"
+	select SOC_AR933X
+	select BUILTIN_DTB
+	help
+	  Say 'Y' if you want your kernel to support the
+	  TP-Link TL-MR3020 board.
+
+config DTB_ATH_TL_WR1043ND_V1
+	bool "TP-Link TL-WR1043ND v1"
+	select SOC_AR913X
+	select BUILTIN_DTB
+	help
+	  Say 'Y' if you want your kernel to support the
+	  TP-Link TL-WR1043ND v1 board.
+
+endmenu
+
 menu "Atheros AR71XX/AR724X/AR913X machine selection"
 
 config ATH79_MACH_AP121
diff --git a/arch/mips/boot/dts/qca/Makefile b/arch/mips/boot/dts/qca/Makefile
index 63a9ddf048c9..acaf448e4516 100644
--- a/arch/mips/boot/dts/qca/Makefile
+++ b/arch/mips/boot/dts/qca/Makefile
@@ -1,9 +1,9 @@
 # All DTBs
-dtb-$(CONFIG_ATH79)			+= ar9132_tl_wr1043nd_v1.dtb
-dtb-$(CONFIG_ATH79)			+= ar9331_dpt_module.dtb
-dtb-$(CONFIG_ATH79)			+= ar9331_dragino_ms14.dtb
-dtb-$(CONFIG_ATH79)			+= ar9331_omega.dtb
-dtb-$(CONFIG_ATH79)			+= ar9331_tl_mr3020.dtb
+dtb-$(CONFIG_DTB_ATH_TL_WR1043ND_V1)	+= ar9132_tl_wr1043nd_v1.dtb
+dtb-$(CONFIG_DTB_ATH_DPT_MODULE)	+= ar9331_dpt_module.dtb
+dtb-$(CONFIG_DTB_ATH_DRAGINO_MS14)	+= ar9331_dragino_ms14.dtb
+dtb-$(CONFIG_DTB_ATH_OMEGA)		+= ar9331_omega.dtb
+dtb-$(CONFIG_DTB_ATH_TL_MR3020)		+= ar9331_tl_mr3020.dtb
 
 # Force kbuild to make empty built-in.o if necessary
 obj-				+= dummy.o
-- 
2.13.5

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] MIPS: ath79: support devicetree selection
@ 2017-09-06 11:14   ` Ralf Baechle
  0 siblings, 0 replies; 10+ messages in thread
From: Ralf Baechle @ 2017-09-06 11:14 UTC (permalink / raw)
  To: Rocco Folino
  Cc: robh+dt, mark.rutland, linux-mips, linux-kernel, devicetree,
	Antony Pavlov, Alban Bedel, John Crispin

On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:

> Allow to choose devicetrees from Kconfig.
> 
> Signed-off-by: Rocco Folino <rocco.folino@gmail.com>
> ---
>  arch/mips/ath79/Kconfig         | 44 +++++++++++++++++++++++++++++++++++++++++
>  arch/mips/boot/dts/qca/Makefile | 10 +++++-----
>  2 files changed, 49 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/mips/ath79/Kconfig b/arch/mips/ath79/Kconfig
> index dfc60209dc63..b43d116187af 100644
> --- a/arch/mips/ath79/Kconfig
> +++ b/arch/mips/ath79/Kconfig
> @@ -1,5 +1,49 @@
>  if ATH79
>  
> +menu "Atheros AR71XX/AR724X/AR913X devicetree selection"
> +
> +config DTB_ATH_DPT_MODULE
> +	bool "DPTechnics DPT-Module"
> +	select SOC_933X

There is no symbol SOC_933X.  Did you mean SOC_AR933X?

Anyway, your patch does more than the changelog ("Allow to choose
devicetrees from Kconfig") says, so please either fix the changelog
or split that into multiple patches with proper changelogs.

  Ralf

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MIPS: ath79: support devicetree selection
@ 2017-09-06 11:14   ` Ralf Baechle
  0 siblings, 0 replies; 10+ messages in thread
From: Ralf Baechle @ 2017-09-06 11:14 UTC (permalink / raw)
  To: Rocco Folino
  Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
	linux-mips-6z/3iImG2C8G8FEW9MqTrA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Antony Pavlov, Alban Bedel,
	John Crispin

On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:

> Allow to choose devicetrees from Kconfig.
> 
> Signed-off-by: Rocco Folino <rocco.folino-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/mips/ath79/Kconfig         | 44 +++++++++++++++++++++++++++++++++++++++++
>  arch/mips/boot/dts/qca/Makefile | 10 +++++-----
>  2 files changed, 49 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/mips/ath79/Kconfig b/arch/mips/ath79/Kconfig
> index dfc60209dc63..b43d116187af 100644
> --- a/arch/mips/ath79/Kconfig
> +++ b/arch/mips/ath79/Kconfig
> @@ -1,5 +1,49 @@
>  if ATH79
>  
> +menu "Atheros AR71XX/AR724X/AR913X devicetree selection"
> +
> +config DTB_ATH_DPT_MODULE
> +	bool "DPTechnics DPT-Module"
> +	select SOC_933X

There is no symbol SOC_933X.  Did you mean SOC_AR933X?

Anyway, your patch does more than the changelog ("Allow to choose
devicetrees from Kconfig") says, so please either fix the changelog
or split that into multiple patches with proper changelogs.

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MIPS: ath79: support devicetree selection
@ 2017-09-06 12:01     ` Rocco Folino
  0 siblings, 0 replies; 10+ messages in thread
From: Rocco Folino @ 2017-09-06 12:01 UTC (permalink / raw)
  To: Ralf Baechle
  Cc: robh+dt, mark.rutland, linux-mips, linux-kernel, devicetree,
	Antony Pavlov, Alban Bedel, John Crispin

On Wed, Sep 06, 2017 at 01:14:35PM +0200, Ralf Baechle wrote:
> On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> 
> > Allow to choose devicetrees from Kconfig.
> > 
> > Signed-off-by: Rocco Folino <rocco.folino@gmail.com>
> > ---
> >  arch/mips/ath79/Kconfig         | 44 +++++++++++++++++++++++++++++++++++++++++
> >  arch/mips/boot/dts/qca/Makefile | 10 +++++-----
> >  2 files changed, 49 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/mips/ath79/Kconfig b/arch/mips/ath79/Kconfig
> > index dfc60209dc63..b43d116187af 100644
> > --- a/arch/mips/ath79/Kconfig
> > +++ b/arch/mips/ath79/Kconfig
> > @@ -1,5 +1,49 @@
> >  if ATH79
> >  
> > +menu "Atheros AR71XX/AR724X/AR913X devicetree selection"
> > +
> > +config DTB_ATH_DPT_MODULE
> > +	bool "DPTechnics DPT-Module"
> > +	select SOC_933X
> 
> There is no symbol SOC_933X.  Did you mean SOC_AR933X?

Yes, right

> 
> Anyway, your patch does more than the changelog ("Allow to choose
> devicetrees from Kconfig") says, so please either fix the changelog
> or split that into multiple patches with proper changelogs.

Ok, I'll fix everything in the v2

thanks for the comments.

Rocco

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MIPS: ath79: support devicetree selection
@ 2017-09-06 12:01     ` Rocco Folino
  0 siblings, 0 replies; 10+ messages in thread
From: Rocco Folino @ 2017-09-06 12:01 UTC (permalink / raw)
  To: Ralf Baechle
  Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
	linux-mips-6z/3iImG2C8G8FEW9MqTrA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Antony Pavlov, Alban Bedel,
	John Crispin

On Wed, Sep 06, 2017 at 01:14:35PM +0200, Ralf Baechle wrote:
> On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> 
> > Allow to choose devicetrees from Kconfig.
> > 
> > Signed-off-by: Rocco Folino <rocco.folino-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> >  arch/mips/ath79/Kconfig         | 44 +++++++++++++++++++++++++++++++++++++++++
> >  arch/mips/boot/dts/qca/Makefile | 10 +++++-----
> >  2 files changed, 49 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/mips/ath79/Kconfig b/arch/mips/ath79/Kconfig
> > index dfc60209dc63..b43d116187af 100644
> > --- a/arch/mips/ath79/Kconfig
> > +++ b/arch/mips/ath79/Kconfig
> > @@ -1,5 +1,49 @@
> >  if ATH79
> >  
> > +menu "Atheros AR71XX/AR724X/AR913X devicetree selection"
> > +
> > +config DTB_ATH_DPT_MODULE
> > +	bool "DPTechnics DPT-Module"
> > +	select SOC_933X
> 
> There is no symbol SOC_933X.  Did you mean SOC_AR933X?

Yes, right

> 
> Anyway, your patch does more than the changelog ("Allow to choose
> devicetrees from Kconfig") says, so please either fix the changelog
> or split that into multiple patches with proper changelogs.

Ok, I'll fix everything in the v2

thanks for the comments.

Rocco
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MIPS: ath79: support devicetree selection
  2017-09-06 11:14   ` Ralf Baechle
  (?)
  (?)
@ 2017-09-06 12:20   ` Alban
  2017-09-06 12:32       ` Rocco Folino
  -1 siblings, 1 reply; 10+ messages in thread
From: Alban @ 2017-09-06 12:20 UTC (permalink / raw)
  To: Ralf Baechle
  Cc: Rocco Folino, robh+dt, mark.rutland, linux-mips, linux-kernel,
	devicetree, Antony Pavlov, John Crispin

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

On Wed, 6 Sep 2017 13:14:35 +0200
Ralf Baechle <ralf@linux-mips.org> wrote:

> On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> 
> > Allow to choose devicetrees from Kconfig.
> > 
> > Signed-off-by: Rocco Folino <rocco.folino@gmail.com>

I don't really see the point of this patch. Building the dtb doesn't
take any significant time, so why add this extra complexity?

Alban

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MIPS: ath79: support devicetree selection
  2017-09-06 12:20   ` Alban
@ 2017-09-06 12:32       ` Rocco Folino
  0 siblings, 0 replies; 10+ messages in thread
From: Rocco Folino @ 2017-09-06 12:32 UTC (permalink / raw)
  To: Alban
  Cc: Ralf Baechle, robh+dt, mark.rutland, linux-mips, linux-kernel,
	devicetree, Antony Pavlov, John Crispin

On Wed, Sep 06, 2017 at 02:20:05PM +0200, Alban wrote:
> On Wed, 6 Sep 2017 13:14:35 +0200
> Ralf Baechle <ralf@linux-mips.org> wrote:
> 
> > On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> > 
> > > Allow to choose devicetrees from Kconfig.
> > > 
> > > Signed-off-by: Rocco Folino <rocco.folino@gmail.com>
> 
> I don't really see the point of this patch. Building the dtb doesn't
> take any significant time, so why add this extra complexity?

Because you need to select the SoC type in order to enable some drivers, for
example on the AR9331 to use the serial you need the CONFIG_SERIAL_AR933X
which depends on the CONFIG_SOC_AR933X.

Rocco

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MIPS: ath79: support devicetree selection
@ 2017-09-06 12:32       ` Rocco Folino
  0 siblings, 0 replies; 10+ messages in thread
From: Rocco Folino @ 2017-09-06 12:32 UTC (permalink / raw)
  To: Alban
  Cc: Ralf Baechle, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
	mark.rutland-5wv7dgnIgG8, linux-mips-6z/3iImG2C8G8FEW9MqTrA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Antony Pavlov, John Crispin

On Wed, Sep 06, 2017 at 02:20:05PM +0200, Alban wrote:
> On Wed, 6 Sep 2017 13:14:35 +0200
> Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org> wrote:
> 
> > On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> > 
> > > Allow to choose devicetrees from Kconfig.
> > > 
> > > Signed-off-by: Rocco Folino <rocco.folino-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> I don't really see the point of this patch. Building the dtb doesn't
> take any significant time, so why add this extra complexity?

Because you need to select the SoC type in order to enable some drivers, for
example on the AR9331 to use the serial you need the CONFIG_SERIAL_AR933X
which depends on the CONFIG_SOC_AR933X.

Rocco
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MIPS: ath79: support devicetree selection
  2017-09-06 12:32       ` Rocco Folino
  (?)
@ 2017-09-06 13:35       ` Alban
  2017-09-06 13:59         ` Rocco Folino
  -1 siblings, 1 reply; 10+ messages in thread
From: Alban @ 2017-09-06 13:35 UTC (permalink / raw)
  To: Rocco Folino
  Cc: Alban, Ralf Baechle, robh+dt, mark.rutland, linux-mips,
	linux-kernel, devicetree, Antony Pavlov, John Crispin

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

On Wed, 6 Sep 2017 14:32:00 +0200
Rocco Folino <rocco.folino@gmail.com> wrote:

> On Wed, Sep 06, 2017 at 02:20:05PM +0200, Alban wrote:
> > On Wed, 6 Sep 2017 13:14:35 +0200
> > Ralf Baechle <ralf@linux-mips.org> wrote:
> >   
> > > On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> > >   
> > > > Allow to choose devicetrees from Kconfig.
> > > > 
> > > > Signed-off-by: Rocco Folino <rocco.folino@gmail.com>  
> > 
> > I don't really see the point of this patch. Building the dtb doesn't
> > take any significant time, so why add this extra complexity?  
> 
> Because you need to select the SoC type in order to enable some
> drivers, for example on the AR9331 to use the serial you need the
> CONFIG_SERIAL_AR933X which depends on the CONFIG_SOC_AR933X.

Seeing as this driver is the only one that make use of CONFIG_SOC_AR933X
I would prefer removing this dependency. It would also open the way to have
the driver built in COMPILE_TEST. A few more fixes might be needed but that
would be better than such a workaround.

Alban

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MIPS: ath79: support devicetree selection
  2017-09-06 13:35       ` Alban
@ 2017-09-06 13:59         ` Rocco Folino
  0 siblings, 0 replies; 10+ messages in thread
From: Rocco Folino @ 2017-09-06 13:59 UTC (permalink / raw)
  To: Alban
  Cc: Ralf Baechle, robh+dt, mark.rutland, linux-mips, linux-kernel,
	devicetree, Antony Pavlov, John Crispin

On Wed, Sep 06, 2017 at 03:35:43PM +0200, Alban wrote:
> On Wed, 6 Sep 2017 14:32:00 +0200
> Rocco Folino <rocco.folino@gmail.com> wrote:
> 
> > On Wed, Sep 06, 2017 at 02:20:05PM +0200, Alban wrote:
> > > On Wed, 6 Sep 2017 13:14:35 +0200
> > > Ralf Baechle <ralf@linux-mips.org> wrote:
> > >   
> > > > On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> > > >   
> > > > > Allow to choose devicetrees from Kconfig.
> > > > > 
> > > > > Signed-off-by: Rocco Folino <rocco.folino@gmail.com>  
> > > 
> > > I don't really see the point of this patch. Building the dtb doesn't
> > > take any significant time, so why add this extra complexity?  
> > 
> > Because you need to select the SoC type in order to enable some
> > drivers, for example on the AR9331 to use the serial you need the
> > CONFIG_SERIAL_AR933X which depends on the CONFIG_SOC_AR933X.
> 
> Seeing as this driver is the only one that make use of CONFIG_SOC_AR933X
> I would prefer removing this dependency. It would also open the way to have
> the driver built in COMPILE_TEST. A few more fixes might be needed but that
> would be better than such a workaround.

Yes, I agree!

Thanks,

Rocco

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2017-09-06 14:00 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-18 15:32 [PATCH] MIPS: ath79: support devicetree selection Rocco Folino
2017-09-06 11:14 ` Ralf Baechle
2017-09-06 11:14   ` Ralf Baechle
2017-09-06 12:01   ` Rocco Folino
2017-09-06 12:01     ` Rocco Folino
2017-09-06 12:20   ` Alban
2017-09-06 12:32     ` Rocco Folino
2017-09-06 12:32       ` Rocco Folino
2017-09-06 13:35       ` Alban
2017-09-06 13:59         ` Rocco Folino

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.