From: Eduardo Habkost <ehabkost@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Jeff Cody <jcody@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
dgilbert@redhat.com, peterx@redhat.com, mrezanin@redhat.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] block-jobs: Optionally unregister live block operations
Date: Wed, 6 Sep 2017 12:02:21 -0300 [thread overview]
Message-ID: <20170906150221.GB7570@localhost.localdomain> (raw)
In-Reply-To: <20170906130041.GI3753@dhcp-200-186.str.redhat.com>
On Wed, Sep 06, 2017 at 03:00:41PM +0200, Kevin Wolf wrote:
> Am 30.08.2017 um 19:01 hat Jeff Cody geschrieben:
> > From: Jeffrey Cody <jcody@redhat.com>
> >
> > If configured without live block operations enabled, unregister the
> > live block operation commands.
> >
> > Signed-off-by: Jeff Cody <jcody@redhat.com>
>
> How sure are we that libvirt will like a qemu that advertises these
> commands in the schema, but doesn't actually provide them?
If libvirt wants to know if a command is available, it uses
'query-commands', not 'query-qmp-schema'.
The only query-qmp-schema elements used by latest libvirt are
gluster-related blockdev-add options (see
libvirt/src/qemu/qemu_capabilities.c:virQEMUCapsQMPSchemaQueries]]).
--
Eduardo
next prev parent reply other threads:[~2017-09-06 15:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 17:01 [Qemu-devel] [PATCH v2 0/3] Live block optional disable Jeff Cody
2017-08-30 17:01 ` [Qemu-devel] [PATCH v2 1/3] configure: Add option in configure to disable live block ops Jeff Cody
2017-08-30 17:01 ` [Qemu-devel] [PATCH v2 2/3] block-jobs: Optionally unregister live block operations Jeff Cody
2017-08-30 17:24 ` Eduardo Habkost
2017-08-30 19:23 ` Eric Blake
2017-08-31 6:45 ` Markus Armbruster
2017-09-06 13:00 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2017-09-06 15:02 ` Eduardo Habkost [this message]
2017-09-06 16:42 ` Eric Blake
2017-08-30 17:01 ` [Qemu-devel] [PATCH v2 3/3] hmp: Optionally disable live block operations in HMP monitor Jeff Cody
2017-09-05 14:01 ` Dr. David Alan Gilbert
2017-08-30 19:17 ` [Qemu-devel] [PATCH v2 0/3] Live block optional disable Eric Blake
2017-08-30 19:26 ` Eric Blake
2017-09-06 12:58 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906150221.GB7570@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mrezanin@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.