[PATCH] Staging: media: atomisp: pci: Fix style issues

[PATCH] Staging: media: atomisp: pci: Fix style issues

[Georgiana Chelu]

Improve the coding style by fixing the following warnings/errors:
	* Space prohibited before that ','
	* Missing a blank line after declarations
	* Prefer 'unsigned int' to bare use of 'unsigned'
	* Open brace '{' following function definitions
	  go on the next line
	* Comparisons should place the constant on the
	  right side of the test

Issues found by checkpatch.pl.

Signed-off-by: Georgiana Chelu <georgiana.chelu93@example.com>
---
 .../atomisp/pci/atomisp2/atomisp_compat_css20.c    | 30 +++++++++++++++-------
 1 file changed, 21 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c
index 05897b747349..f0d7edb91721 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c
@@ -155,20 +155,20 @@ static void atomisp_css2_hw_store(hrt_address addr,
 				  const void *from, uint32_t n)
 {
 	unsigned long flags;
-	unsigned i;
+	unsigned int i;
 	unsigned int _to = (unsigned int)addr;
 	const char *_from = (const char *)from;
 
 	spin_lock_irqsave(&mmio_lock, flags);
 	for (i = 0; i < n; i++, _to++, _from++)
-		_hrt_master_port_store_8(_to , *_from);
+		_hrt_master_port_store_8(_to, *_from);
 	spin_unlock_irqrestore(&mmio_lock, flags);
 }
 
 static void atomisp_css2_hw_load(hrt_address addr, void *to, uint32_t n)
 {
 	unsigned long flags;
-	unsigned i;
+	unsigned int i;
 	char *_to = (char *)to;
 	unsigned int _from = (unsigned int)addr;
 
@@ -232,9 +232,11 @@ static void __dump_pipe_config(struct atomisp_sub_device *asd,
 			       unsigned int pipe_id)
 {
 	struct atomisp_device *isp = asd->isp;
+
 	if (stream_env->pipes[pipe_id]) {
 		struct ia_css_pipe_config *p_config;
 		struct ia_css_pipe_extra_config *pe_config;
+
 		p_config = &stream_env->pipe_configs[pipe_id];
 		pe_config = &stream_env->pipe_extra_configs[pipe_id];
 		dev_dbg(isp->dev, "dumping pipe[%d] config:\n", pipe_id);
@@ -507,6 +509,7 @@ static int __destroy_stream(struct atomisp_sub_device *asd,
 static int __destroy_streams(struct atomisp_sub_device *asd, bool force)
 {
 	int ret, i;
+
 	for (i = 0; i < ATOMISP_INPUT_STREAM_NUM; i++) {
 		ret = __destroy_stream(asd, &asd->stream_env[i], force);
 		if (ret)
@@ -573,6 +576,7 @@ static int __destroy_stream_pipes(struct atomisp_sub_device *asd,
 	struct atomisp_device *isp = asd->isp;
 	int ret = 0;
 	int i;
+
 	for (i = 0; i < IA_CSS_PIPE_ID_NUM; i++) {
 		if (!stream_env->pipes[i] ||
 		    !(force || stream_env->update_pipe[i]))
@@ -892,12 +896,12 @@ static inline int __set_css_print_env(struct atomisp_device *isp, int opt)
 {
 	int ret = 0;
 
-	if (0 == opt)
+	if (opt == 0)
 		isp->css_env.isp_css_env.print_env.debug_print = NULL;
-	else if (1 == opt)
+	else if (opt == 1)
 		isp->css_env.isp_css_env.print_env.debug_print =
 			atomisp_css2_dbg_ftrace_print;
-	else if (2 == opt)
+	else if (opt == 1)
 		isp->css_env.isp_css_env.print_env.debug_print =
 			atomisp_css2_dbg_print;
 	else
@@ -1051,6 +1055,7 @@ int atomisp_css_irq_enable(struct atomisp_device *isp,
 void atomisp_css_init_struct(struct atomisp_sub_device *asd)
 {
 	int i, j;
+
 	for (i = 0; i < ATOMISP_INPUT_STREAM_NUM; i++) {
 		asd->stream_env[i].stream = NULL;
 		for (j = 0; j < IA_CSS_PIPE_MODE_NUM; j++) {
@@ -1189,6 +1194,7 @@ int atomisp_css_start(struct atomisp_sub_device *asd,
 	struct atomisp_device *isp = asd->isp;
 	bool sp_is_started = false;
 	int ret = 0, i = 0;
+
 	if (in_reset) {
 		if (__destroy_streams(asd, true))
 			dev_warn(isp->dev, "destroy stream failed.\n");
@@ -1976,6 +1982,7 @@ void atomisp_css_enable_raw_binning(struct atomisp_sub_device *asd,
 void atomisp_css_enable_dz(struct atomisp_sub_device *asd, bool enable)
 {
 	int i;
+
 	for (i = 0; i < IA_CSS_PIPE_ID_NUM; i++)
 		asd->stream_env[ATOMISP_INPUT_STREAM_GENERAL]
 			.pipe_configs[i].enable_dz = enable;
@@ -2002,6 +2009,7 @@ void atomisp_css_input_set_mode(struct atomisp_sub_device *asd,
 	int i;
 	struct atomisp_device *isp = asd->isp;
 	unsigned int size_mem_words;
+
 	for (i = 0; i < ATOMISP_INPUT_STREAM_NUM; i++)
 		asd->stream_env[i].stream_config.mode = mode;
 
@@ -2275,6 +2283,7 @@ int atomisp_css_stop(struct atomisp_sub_device *asd,
 	if (!in_reset) {
 		struct atomisp_stream_env *stream_env;
 		int i, j;
+
 		for (i = 0; i < ATOMISP_INPUT_STREAM_NUM; i++) {
 			stream_env = &asd->stream_env[i];
 			for (j = 0; j < IA_CSS_PIPE_ID_NUM; j++) {
@@ -2777,6 +2786,7 @@ static void __configure_vf_output(struct atomisp_sub_device *asd,
 	struct atomisp_device *isp = asd->isp;
 	struct atomisp_stream_env *stream_env =
 		&asd->stream_env[ATOMISP_INPUT_STREAM_GENERAL];
+
 	stream_env->pipe_configs[pipe_id].mode =
 		__pipe_id_to_pipe_mode(asd, pipe_id);
 	stream_env->update_pipe[pipe_id] = true;
@@ -2801,6 +2811,7 @@ static void __configure_video_vf_output(struct atomisp_sub_device *asd,
 	struct atomisp_stream_env *stream_env =
 		&asd->stream_env[ATOMISP_INPUT_STREAM_GENERAL];
 	struct ia_css_frame_info *css_output_info;
+
 	stream_env->pipe_configs[pipe_id].mode =
 					__pipe_id_to_pipe_mode(asd, pipe_id);
 	stream_env->update_pipe[pipe_id] = true;
@@ -4464,7 +4475,8 @@ int atomisp_css_load_acc_binary(struct atomisp_sub_device *asd,
 static struct atomisp_sub_device *__get_atomisp_subdev(
 					struct ia_css_pipe *css_pipe,
 					struct atomisp_device *isp,
-					enum atomisp_input_stream_id *stream_id) {
+					enum atomisp_input_stream_id *stream_id)
+{
 	int i, j, k;
 	struct atomisp_sub_device *asd;
 	struct atomisp_stream_env *stream_env;
@@ -4659,7 +4671,7 @@ int atomisp_css_dump_sp_raw_copy_linecount(bool reduced)
 int atomisp_css_dump_blob_infor(void)
 {
 	struct ia_css_blob_descr *bd = sh_css_blob_info;
-	unsigned i, nm = sh_css_num_binaries;
+	unsigned int i, nm = sh_css_num_binaries;
 
 	if (nm == 0)
 		return -EPERM;
@@ -4695,7 +4707,7 @@ int atomisp_set_css_dbgfunc(struct atomisp_device *isp, int opt)
 	int ret;
 
 	ret = __set_css_print_env(isp, opt);
-	if (0 == ret)
+	if (ret == 0)
 		dbg_func = opt;
 
 	return ret;
-- 
2.11.0

Re: [PATCH] Staging: media: atomisp: pci: Fix style issues

[Greg KH]

On Mon, Sep 18, 2017 at 11:06:49PM +0300, Georgiana Chelu wrote:
> Improve the coding style by fixing the following warnings/errors:
> 	* Space prohibited before that ','
> 	* Missing a blank line after declarations
> 	* Prefer 'unsigned int' to bare use of 'unsigned'
> 	* Open brace '{' following function definitions
> 	  go on the next line
> 	* Comparisons should place the constant on the
> 	  right side of the test

That's a lot of different "things" to be doing all in one patch.  I
don't normally accept patches like this, please break it up into "only
do one type of thing" per patch, just like the rest of the patches on
this mailing list.

thanks,

greg k-h

Re: [PATCH] Staging: media: atomisp: pci: Fix style issues

[Georgiana Chelu]

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

Thank you for reviewing it! I am thinking to resend it as a
patch set because all the fixes are related to a single file.
Is it OK?


Regards,
Georgiana

On 19 September 2017 at 09:10, Greg KH <gregkh@linuxfoundation.org> wrote:

> On Mon, Sep 18, 2017 at 11:06:49PM +0300, Georgiana Chelu wrote:
> > Improve the coding style by fixing the following warnings/errors:
> >       * Space prohibited before that ','
> >       * Missing a blank line after declarations
> >       * Prefer 'unsigned int' to bare use of 'unsigned'
> >       * Open brace '{' following function definitions
> >         go on the next line
> >       * Comparisons should place the constant on the
> >         right side of the test
>
> That's a lot of different "things" to be doing all in one patch.  I
> don't normally accept patches like this, please break it up into "only
> do one type of thing" per patch, just like the rest of the patches on
> this mailing list.
>
> thanks,
>
> greg k-h
>

[-- Attachment #2: Type: text/html, Size: 1549 bytes --]

Re: [PATCH] Staging: media: atomisp: pci: Fix style issues

[Greg KH]

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Tue, Sep 19, 2017 at 09:29:18AM +0300, Georgiana Chelu wrote:
> Thank you for reviewing it! I am thinking to resend it as a
> patch set because all the fixes are related to a single file.
> Is it OK?

Yes, a patchset would be great, and the correct thing to do here.

thanks,

greg k-h

Re: [PATCH] Staging: media: atomisp: pci: Fix style issues

[Georgiana Chelu]

On 19 September 2017 at 09:35, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>

I see what you did here. I will keep this advice in mind!

> http://daringfireball.net/2007/07/on_top
>
> On Tue, Sep 19, 2017 at 09:29:18AM +0300, Georgiana Chelu wrote:
>> Thank you for reviewing it! I am thinking to resend it as a
>> patch set because all the fixes are related to a single file.
>> Is it OK?
>
> Yes, a patchset would be great, and the correct thing to do here.
>
> thanks,
>
> greg k-h


Best regards,
Georgiana