From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] i40e: make const array patterns static, reduces object code size
Date: Fri, 22 Sep 2017 09:44:02 -0700 [thread overview]
Message-ID: <20170922094402.00001ad2@intel.com> (raw)
In-Reply-To: <20170922141138.13038-1-colin.king@canonical.com>
On Fri, 22 Sep 2017 15:11:38 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const array patterns on the stack, instead make it
> static. Makes the object code smaller by over 60 bytes:
>
> Before:
> text data bss dec hex filename
> 1953 496 0 2449 991 i40e_diag.o
>
> After:
> text data bss dec hex filename
> 1798 584 0 2382 94e i40e_diag.o
>
> (gcc 6.3.0, x86-64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks good, thanks Colin!
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
jesse.brandeburg@intel.com
Subject: Re: [Intel-wired-lan] [PATCH] i40e: make const array patterns static, reduces object code size
Date: Fri, 22 Sep 2017 16:44:02 +0000 [thread overview]
Message-ID: <20170922094402.00001ad2@intel.com> (raw)
In-Reply-To: <20170922141138.13038-1-colin.king@canonical.com>
On Fri, 22 Sep 2017 15:11:38 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const array patterns on the stack, instead make it
> static. Makes the object code smaller by over 60 bytes:
>
> Before:
> text data bss dec hex filename
> 1953 496 0 2449 991 i40e_diag.o
>
> After:
> text data bss dec hex filename
> 1798 584 0 2382 94e i40e_diag.o
>
> (gcc 6.3.0, x86-64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks good, thanks Colin!
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
jesse.brandeburg@intel.com
Subject: Re: [Intel-wired-lan] [PATCH] i40e: make const array patterns static, reduces object code size
Date: Fri, 22 Sep 2017 09:44:02 -0700 [thread overview]
Message-ID: <20170922094402.00001ad2@intel.com> (raw)
In-Reply-To: <20170922141138.13038-1-colin.king@canonical.com>
On Fri, 22 Sep 2017 15:11:38 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const array patterns on the stack, instead make it
> static. Makes the object code smaller by over 60 bytes:
>
> Before:
> text data bss dec hex filename
> 1953 496 0 2449 991 i40e_diag.o
>
> After:
> text data bss dec hex filename
> 1798 584 0 2382 94e i40e_diag.o
>
> (gcc 6.3.0, x86-64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks good, thanks Colin!
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2017-09-22 16:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 14:11 [Intel-wired-lan] [PATCH] i40e: make const array patterns static, reduces object code size Colin King
2017-09-22 14:11 ` Colin King
2017-09-22 14:11 ` Colin King
2017-09-22 16:44 ` Jesse Brandeburg [this message]
2017-09-22 16:44 ` [Intel-wired-lan] " Jesse Brandeburg
2017-09-22 16:44 ` Jesse Brandeburg
2017-10-03 22:17 ` Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922094402.00001ad2@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.