* [PATCH] staging: rtl8188eu: remove unneeded conversions to bool @ 2017-09-22 9:40 Aishwarya Pant 2017-09-22 9:47 ` [Outreachy kernel] " Julia Lawall 0 siblings, 1 reply; 4+ messages in thread From: Aishwarya Pant @ 2017-09-22 9:40 UTC (permalink / raw) To: Greg Kroah-Hartman, devel; +Cc: outreachy-kernel Patch suppresses the following warning issued by coccicheck: WARNING: conversion to bool not needed here Signed-off-by: Aishwarya Pant <aishpant@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c index 52f31c7..2db2ca6 100644 --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c @@ -707,7 +707,7 @@ static int issue_probereq_ex(struct adapter *padapter, unsigned long start = jiffies; do { - ret = issue_probereq(padapter, pssid, da, wait_ms > 0 ? true : false); + ret = issue_probereq(padapter, pssid, da, wait_ms > 0); i++; @@ -1283,7 +1283,7 @@ int issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned int pow da = pnetwork->MacAddress; do { - ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0 ? true : false); + ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0); i++; @@ -1410,7 +1410,7 @@ int issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 tid, int da = pnetwork->MacAddress; do { - ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0 ? true : false); + ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0); i++; @@ -1517,7 +1517,7 @@ static int issue_deauth_ex(struct adapter *padapter, u8 *da, unsigned long start = jiffies; do { - ret = _issue_deauth(padapter, da, reason, wait_ms > 0 ? true : false); + ret = _issue_deauth(padapter, da, reason, wait_ms > 0); i++; -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: remove unneeded conversions to bool 2017-09-22 9:40 [PATCH] staging: rtl8188eu: remove unneeded conversions to bool Aishwarya Pant @ 2017-09-22 9:47 ` Julia Lawall 2017-09-22 10:22 ` Aishwarya Pant 0 siblings, 1 reply; 4+ messages in thread From: Julia Lawall @ 2017-09-22 9:47 UTC (permalink / raw) To: Aishwarya Pant; +Cc: Greg Kroah-Hartman, devel, outreachy-kernel On Fri, 22 Sep 2017, Aishwarya Pant wrote: > Patch suppresses the following warning issued by coccicheck: > WARNING: conversion to bool not needed here > > Signed-off-by: Aishwarya Pant <aishpant@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> > --- > drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > index 52f31c7..2db2ca6 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > @@ -707,7 +707,7 @@ static int issue_probereq_ex(struct adapter *padapter, > unsigned long start = jiffies; > > do { > - ret = issue_probereq(padapter, pssid, da, wait_ms > 0 ? true : false); > + ret = issue_probereq(padapter, pssid, da, wait_ms > 0); > > i++; > > @@ -1283,7 +1283,7 @@ int issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned int pow > da = pnetwork->MacAddress; > > do { > - ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0 ? true : false); > + ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0); > > i++; > > @@ -1410,7 +1410,7 @@ int issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 tid, int > da = pnetwork->MacAddress; > > do { > - ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0 ? true : false); > + ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0); > > i++; > > @@ -1517,7 +1517,7 @@ static int issue_deauth_ex(struct adapter *padapter, u8 *da, > unsigned long start = jiffies; > > do { > - ret = _issue_deauth(padapter, da, reason, wait_ms > 0 ? true : false); > + ret = _issue_deauth(padapter, da, reason, wait_ms > 0); > > i++; > > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170922094052.GA29313%40aishwarya. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: remove unneeded conversions to bool 2017-09-22 9:47 ` [Outreachy kernel] " Julia Lawall @ 2017-09-22 10:22 ` Aishwarya Pant 2017-09-22 10:22 ` Julia Lawall 0 siblings, 1 reply; 4+ messages in thread From: Aishwarya Pant @ 2017-09-22 10:22 UTC (permalink / raw) To: Julia Lawall; +Cc: Greg Kroah-Hartman, devel, outreachy-kernel On Fri, Sep 22, 2017 at 11:47:44AM +0200, Julia Lawall wrote: > > > On Fri, 22 Sep 2017, Aishwarya Pant wrote: > > > Patch suppresses the following warning issued by coccicheck: > > WARNING: conversion to bool not needed here > > > > Signed-off-by: Aishwarya Pant <aishpant@gmail.com> > > Acked-by: Julia Lawall <julia.lawall@lip6.fr> Dropping this patch to include it in a clean up patch set. Julia, I can include this ack when I add it to the patch set? > > > > --- > > drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > > index 52f31c7..2db2ca6 100644 > > --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > > +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > > @@ -707,7 +707,7 @@ static int issue_probereq_ex(struct adapter *padapter, > > unsigned long start = jiffies; > > > > do { > > - ret = issue_probereq(padapter, pssid, da, wait_ms > 0 ? true : false); > > + ret = issue_probereq(padapter, pssid, da, wait_ms > 0); > > > > i++; > > > > @@ -1283,7 +1283,7 @@ int issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned int pow > > da = pnetwork->MacAddress; > > > > do { > > - ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0 ? true : false); > > + ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0); > > > > i++; > > > > @@ -1410,7 +1410,7 @@ int issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 tid, int > > da = pnetwork->MacAddress; > > > > do { > > - ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0 ? true : false); > > + ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0); > > > > i++; > > > > @@ -1517,7 +1517,7 @@ static int issue_deauth_ex(struct adapter *padapter, u8 *da, > > unsigned long start = jiffies; > > > > do { > > - ret = _issue_deauth(padapter, da, reason, wait_ms > 0 ? true : false); > > + ret = _issue_deauth(padapter, da, reason, wait_ms > 0); > > > > i++; > > > > -- > > 2.7.4 > > > > -- > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170922094052.GA29313%40aishwarya. > > For more options, visit https://groups.google.com/d/optout. > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: remove unneeded conversions to bool 2017-09-22 10:22 ` Aishwarya Pant @ 2017-09-22 10:22 ` Julia Lawall 0 siblings, 0 replies; 4+ messages in thread From: Julia Lawall @ 2017-09-22 10:22 UTC (permalink / raw) To: Aishwarya Pant; +Cc: Greg Kroah-Hartman, devel, outreachy-kernel On Fri, 22 Sep 2017, Aishwarya Pant wrote: > On Fri, Sep 22, 2017 at 11:47:44AM +0200, Julia Lawall wrote: > > > > > > On Fri, 22 Sep 2017, Aishwarya Pant wrote: > > > > > Patch suppresses the following warning issued by coccicheck: > > > WARNING: conversion to bool not needed here > > > > > > Signed-off-by: Aishwarya Pant <aishpant@gmail.com> > > > > Acked-by: Julia Lawall <julia.lawall@lip6.fr> > > Dropping this patch to include it in a clean up patch set. > > Julia, I can include this ack when I add it to the patch set? Yes, that part of the patch was fine. julia > > > > > > > > --- > > > drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > > > index 52f31c7..2db2ca6 100644 > > > --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > > > +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > > > @@ -707,7 +707,7 @@ static int issue_probereq_ex(struct adapter *padapter, > > > unsigned long start = jiffies; > > > > > > do { > > > - ret = issue_probereq(padapter, pssid, da, wait_ms > 0 ? true : false); > > > + ret = issue_probereq(padapter, pssid, da, wait_ms > 0); > > > > > > i++; > > > > > > @@ -1283,7 +1283,7 @@ int issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned int pow > > > da = pnetwork->MacAddress; > > > > > > do { > > > - ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0 ? true : false); > > > + ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0); > > > > > > i++; > > > > > > @@ -1410,7 +1410,7 @@ int issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 tid, int > > > da = pnetwork->MacAddress; > > > > > > do { > > > - ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0 ? true : false); > > > + ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0); > > > > > > i++; > > > > > > @@ -1517,7 +1517,7 @@ static int issue_deauth_ex(struct adapter *padapter, u8 *da, > > > unsigned long start = jiffies; > > > > > > do { > > > - ret = _issue_deauth(padapter, da, reason, wait_ms > 0 ? true : false); > > > + ret = _issue_deauth(padapter, da, reason, wait_ms > 0); > > > > > > i++; > > > > > > -- > > > 2.7.4 > > > > > > -- > > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170922094052.GA29313%40aishwarya. > > > For more options, visit https://groups.google.com/d/optout. > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-22 10:22 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-09-22 9:40 [PATCH] staging: rtl8188eu: remove unneeded conversions to bool Aishwarya Pant 2017-09-22 9:47 ` [Outreachy kernel] " Julia Lawall 2017-09-22 10:22 ` Aishwarya Pant 2017-09-22 10:22 ` Julia Lawall
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.