All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: 陈华才 <chenhc@lemote.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Fuxin Zhang <zhangfx@lemote.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	James Hogan <james.hogan@imgtec.com>,
	linux-mips <linux-mips@linux-mips.org>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	Roland Dreier <rolandd@cisco.com>,
	Pawel Osciak <pawel@osciak.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Michael Chan <michael.chan@broadcom.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Ivan Mikhaylov <ivan@ru.ibm.com>,
	Tariq Toukan <tariqt@mellanox.com>,
	Andy Gross <agross@codeaurora.org>,
	"Mark A . Greer" <mgreer@mvista.com>,
	Robert Baldyga <r.baldyga@samsung.com>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment()
Date: Tue, 26 Sep 2017 08:10:19 +0200	[thread overview]
Message-ID: <20170926061019.GA6416@lst.de> (raw)
In-Reply-To: <tencent_7716E99906A9D63D4592EFB6@qq.com>

On Tue, Sep 26, 2017 at 09:48:01AM +0800, 陈华才 wrote:
> Hi, Christoph,
> 
> Can I put the declaration in asm/dma-coherence.h?

Generally something not expose to the rest of the kernel (that is not
in arch/mips/include/) would be preferred, but in the end the architecture
maintainer will have to decide.

> And, last time you said it is OK to pass a NULL to dma_get_cache_alignment() and cc all driver maintainers. I have do so.

No, I asked you to converted everything to pass the struct device and
cc the driver maintainers.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: 陈华才 <chenhc@lemote.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Fuxin Zhang <zhangfx@lemote.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	James Hogan <james.hogan@imgtec.com>,
	linux-mips <linux-mips@linux-mips.org>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	Roland Dreier <rolandd@cisco.com>,
	Pawel Osciak <pawel@osciak.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Michael Chan <michael.chan@broadcom.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Ivan Mikhaylov <ivan@ru.ibm.com>, Tariq Toukan <tari>
Subject: Re: [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment()
Date: Tue, 26 Sep 2017 08:10:19 +0200	[thread overview]
Message-ID: <20170926061019.GA6416@lst.de> (raw)
In-Reply-To: <tencent_7716E99906A9D63D4592EFB6@qq.com>

On Tue, Sep 26, 2017 at 09:48:01AM +0800, 陈华才 wrote:
> Hi, Christoph,
> 
> Can I put the declaration in asm/dma-coherence.h?

Generally something not expose to the rest of the kernel (that is not
in arch/mips/include/) would be preferred, but in the end the architecture
maintainer will have to decide.

> And, last time you said it is OK to pass a NULL to dma_get_cache_alignment() and cc all driver maintainers. I have do so.

No, I asked you to converted everything to pass the struct device and
cc the driver maintainers.

  reply	other threads:[~2017-09-26  6:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25  9:46 [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment() Huacai Chen
2017-09-25  9:46 ` Huacai Chen
2017-09-25  9:46 ` [PATCH V7 2/2] scsi: Align block queue to dma_get_cache_alignment() Huacai Chen
2017-09-25  9:46   ` Huacai Chen
2017-09-30 23:30   ` kbuild test robot
2017-09-30 23:30     ` kbuild test robot
2017-09-30 23:30     ` kbuild test robot
2017-09-25 12:51 ` [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment() Christoph Hellwig
2017-09-25 12:51   ` Christoph Hellwig
2017-09-26  1:48   ` 陈华才
2017-09-26  1:48     ` 陈华才
2017-09-26  6:10     ` Christoph Hellwig [this message]
2017-09-26  6:10       ` Christoph Hellwig
2017-09-25 12:57 ` Robin Murphy
2017-09-25 12:57   ` Robin Murphy
2017-09-26  1:44   ` 陈华才
2017-09-26  1:44     ` 陈华才

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170926061019.GA6416@lst.de \
    --to=hch@lst.de \
    --cc=agross@codeaurora.org \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=chenhc@lemote.com \
    --cc=ivan@ru.ibm.com \
    --cc=james.hogan@imgtec.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=martin.petersen@oracle.com \
    --cc=mgreer@mvista.com \
    --cc=michael.chan@broadcom.com \
    --cc=pawel@osciak.com \
    --cc=r.baldyga@samsung.com \
    --cc=ralf@linux-mips.org \
    --cc=robin.murphy@arm.com \
    --cc=rolandd@cisco.com \
    --cc=stable@vger.kernel.org \
    --cc=tariqt@mellanox.com \
    --cc=zhangfx@lemote.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.