All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "dm-raid: fix a race condition in request handling" has been added to the 4.13-stable tree
@ 2017-10-02  9:41 gregkh
  2017-10-02 10:10 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: gregkh @ 2017-10-02  9:41 UTC (permalink / raw)
  To: shli, gregkh, heinzm, neilb, snitzer; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    dm-raid: fix a race condition in request handling

to the 4.13-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     dm-raid-fix-a-race-condition-in-request-handling.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From c4d6a1b8e8ea79c439a4871cba540443c9eb13b9 Mon Sep 17 00:00:00 2001
From: Shaohua Li <shli@fb.com>
Date: Thu, 21 Sep 2017 10:29:22 -0700
Subject: dm-raid: fix a race condition in request handling

From: Shaohua Li <shli@fb.com>

commit c4d6a1b8e8ea79c439a4871cba540443c9eb13b9 upstream.

raid_map calls pers->make_request, which missed the suspend check. Fix it with
the new md_handle_request API.

Fix: cc27b0c78c79(md: fix deadlock between mddev_suspend() and md_write_start())
Cc: Heinz Mauelshagen <heinzm@redhat.com>
Cc: Mike Snitzer <snitzer@redhat.com>
Reviewed-by: NeilBrown <neilb@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/md/dm-raid.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -3238,7 +3238,7 @@ static int raid_map(struct dm_target *ti
 	if (unlikely(bio_end_sector(bio) > mddev->array_sectors))
 		return DM_MAPIO_REQUEUE;
 
-	mddev->pers->make_request(mddev, bio);
+	md_handle_request(mddev, bio);
 
 	return DM_MAPIO_SUBMITTED;
 }


Patches currently in stable-queue which might be from shli@fb.com are

queue-4.13/md-raid5-preserve-stripe_on_unplug_list-in-break_stripe_batch_list.patch
queue-4.13/dm-raid-fix-a-race-condition-in-request-handling.patch
queue-4.13/md-raid5-fix-a-race-condition-in-stripe-batch.patch

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Patch "dm-raid: fix a race condition in request handling" has been added to the 4.13-stable tree
  2017-10-02  9:41 Patch "dm-raid: fix a race condition in request handling" has been added to the 4.13-stable tree gregkh
@ 2017-10-02 10:10 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-10-02 10:10 UTC (permalink / raw)
  To: shli, heinzm, neilb, snitzer; +Cc: stable, stable-commits

On Mon, Oct 02, 2017 at 11:41:39AM +0200, gregkh@linuxfoundation.org wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     dm-raid: fix a race condition in request handling
> 
> to the 4.13-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      dm-raid-fix-a-race-condition-in-request-handling.patch
> and it can be found in the queue-4.13 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 

Nope, this broke the build, so if it should go into 4.13-stable, someone
needs to provide a working version of this :(

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-10-02 10:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-02  9:41 Patch "dm-raid: fix a race condition in request handling" has been added to the 4.13-stable tree gregkh
2017-10-02 10:10 ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.