[meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[Martin Jansa]

* this reverts commit 04b37dbdb79638b17a670280058400ffaf1b6ccb.
* this makes qtbase and everything which depends on some qt* recipe to
  be effectivelly MACHINE_ARCH

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 ---
 1 file changed, 3 deletions(-)
 delete mode 100644 dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend

diff --git a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend b/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
deleted file mode 100644
index ae3f1d3..0000000
--- a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
+++ /dev/null
@@ -1,3 +0,0 @@
-# Copyright (C) 2017 O.S. Systems Software LTDA.
-
-PACKAGECONFIG_GL_rpi   = "gles2 eglfs"
-- 
2.7.4

Re: [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 973 bytes --]

On Wed, Sep 27, 2017 at 4:23 PM, Martin Jansa <martin.jansa@gmail.com>
wrote:

> * this reverts commit 04b37dbdb79638b17a670280058400ffaf1b6ccb.
> * this makes qtbase and everything which depends on some qt* recipe to
>   be effectivelly MACHINE_ARCH
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 ---
>  1 file changed, 3 deletions(-)
>  delete mode 100644 dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.
> bbappend
>
> diff --git a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> b/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> deleted file mode 100644
> index ae3f1d3..0000000
> --- a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -# Copyright (C) 2017 O.S. Systems Software LTDA.
> -
> -PACKAGECONFIG_GL_rpi   = "gles2 eglfs"


What would be the solution though?

--
Andrei Gherzan

[-- Attachment #2: Type: text/html, Size: 1573 bytes --]

Re: [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]

On Wed, Sep 27, 2017 at 10:17 AM Andrei Gherzan <andrei@gherzan.ro> wrote:

> On Wed, Sep 27, 2017 at 4:23 PM, Martin Jansa <martin.jansa@gmail.com>
> wrote:
>
>> * this reverts commit 04b37dbdb79638b17a670280058400ffaf1b6ccb.
>> * this makes qtbase and everything which depends on some qt* recipe to
>>   be effectivelly MACHINE_ARCH
>>
>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>> ---
>>  dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 ---
>>  1 file changed, 3 deletions(-)
>>  delete mode 100644
>> dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
>>
>> diff --git a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
>> b/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
>> deleted file mode 100644
>> index ae3f1d3..0000000
>> --- a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
>> +++ /dev/null
>> @@ -1,3 +0,0 @@
>> -# Copyright (C) 2017 O.S. Systems Software LTDA.
>> -
>> -PACKAGECONFIG_GL_rpi   = "gles2 eglfs"
>
>
> What would be the solution though?
>
I think check for OpenGL feature to enable it
I think another thing is to also check for X11 in distro features before
enabling it

Gl support is quite soc specific so I don't think there is an elegant way
unless qt components can be built with soc specific elements as plugins or
something which then can have independent recipe



> --
> Andrei Gherzan
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>

[-- Attachment #2: Type: text/html, Size: 2929 bytes --]

Re: [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[Otavio Salvador]

Hello Andrei,

On Wed, Sep 27, 2017 at 2:13 PM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> On Wed, Sep 27, 2017 at 4:23 PM, Martin Jansa <martin.jansa@gmail.com>
> wrote:
>>
>> * this reverts commit 04b37dbdb79638b17a670280058400ffaf1b6ccb.
>> * this makes qtbase and everything which depends on some qt* recipe to
>>   be effectivelly MACHINE_ARCH
>>
>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>> ---
>>  dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 ---
>>  1 file changed, 3 deletions(-)
>>  delete mode 100644
>> dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
>>
>> diff --git a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
>> b/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
>> deleted file mode 100644
>> index ae3f1d3..0000000
>> --- a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
>> +++ /dev/null
>> @@ -1,3 +0,0 @@
>> -# Copyright (C) 2017 O.S. Systems Software LTDA.
>> -
>> -PACKAGECONFIG_GL_rpi   = "gles2 eglfs"
>
>
> What would be the solution though?

It would use something similar we use for meta-freescale where we
change the package architecture depending on the SoC.

Martin, do you have any idea how other alternative we have?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[Otavio Salvador]

On Wed, Sep 27, 2017 at 2:20 PM, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Wed, Sep 27, 2017 at 10:17 AM Andrei Gherzan <andrei@gherzan.ro> wrote:
>>
>> On Wed, Sep 27, 2017 at 4:23 PM, Martin Jansa <martin.jansa@gmail.com>
>> wrote:
>>>
>>> * this reverts commit 04b37dbdb79638b17a670280058400ffaf1b6ccb.
>>> * this makes qtbase and everything which depends on some qt* recipe to
>>>   be effectivelly MACHINE_ARCH
>>>
>>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>>> ---
>>>  dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 ---
>>>  1 file changed, 3 deletions(-)
>>>  delete mode 100644
>>> dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
>>>
>>> diff --git a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
>>> b/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
>>> deleted file mode 100644
>>> index ae3f1d3..0000000
>>> --- a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
>>> +++ /dev/null
>>> @@ -1,3 +0,0 @@
>>> -# Copyright (C) 2017 O.S. Systems Software LTDA.
>>> -
>>> -PACKAGECONFIG_GL_rpi   = "gles2 eglfs"
>>
>>
>> What would be the solution though?
>
> I think check for OpenGL feature to enable it
> I think another thing is to also check for X11 in distro features before
> enabling it
>
> Gl support is quite soc specific so I don't think there is an elegant way
> unless qt components can be built with soc specific elements as plugins or
> something which then can have independent recipe

https://github.com/Freescale/meta-freescale/blob/master/classes/fsl-dynamic-packagearch.bbclass

Something like this?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2260 bytes --]

On Wed, Sep 27, 2017 at 02:23:43PM -0300, Otavio Salvador wrote:
> Hello Andrei,
> 
> On Wed, Sep 27, 2017 at 2:13 PM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> > On Wed, Sep 27, 2017 at 4:23 PM, Martin Jansa <martin.jansa@gmail.com>
> > wrote:
> >>
> >> * this reverts commit 04b37dbdb79638b17a670280058400ffaf1b6ccb.
> >> * this makes qtbase and everything which depends on some qt* recipe to
> >>   be effectivelly MACHINE_ARCH
> >>
> >> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> >> ---
> >>  dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 ---
> >>  1 file changed, 3 deletions(-)
> >>  delete mode 100644
> >> dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> >>
> >> diff --git a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> >> b/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> >> deleted file mode 100644
> >> index ae3f1d3..0000000
> >> --- a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> >> +++ /dev/null
> >> @@ -1,3 +0,0 @@
> >> -# Copyright (C) 2017 O.S. Systems Software LTDA.
> >> -
> >> -PACKAGECONFIG_GL_rpi   = "gles2 eglfs"
> >
> >
> > What would be the solution though?
> 
> It would use something similar we use for meta-freescale where we
> change the package architecture depending on the SoC.
> 
> Martin, do you have any idea how other alternative we have?

In theory you can set QT_PACKAGES_ARCH to MACHINE_ARCH in rpi-base.inc
to make it explicit, but that's also really bad (as e.g. rpi2 and rpi3
will each build it's own qtwebengine and all it's deps even when it
should be the same for both).

I think the only usable solution is to let DISTRO to decide the policy,
as Khem suggested DISTRO_FEATURES is first step, if it isn't enough (in
this case it's difficult to distinguish e.g. opengl and gles2 when there
is opengl in DISTRO_FEATURES). So I would leave it to DISTRO maintainers
to decide if they can enable "gles2 eglfs" globally for all MACHINEs in
distro bbappend, or they can enable it only for some DEFAULT_TUNE (or
e.g. for all arm MACHINEs and leave desktop gl for x86).

But forcing this policy from BSP is bad.

Regards,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

Re: [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[Otavio Salvador]

Hello Martin,

On Wed, Sep 27, 2017 at 2:34 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
...
>> Martin, do you have any idea how other alternative we have?
>
> In theory you can set QT_PACKAGES_ARCH to MACHINE_ARCH in rpi-base.inc
> to make it explicit, but that's also really bad (as e.g. rpi2 and rpi3
> will each build it's own qtwebengine and all it's deps even when it
> should be the same for both).

Agreed and that was the reason of we create MACHINE_SOCARCH in
meta-freescale. It allows for SoC specific packages but compatible
across machines.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[Manjukumar Harthikote Matha]

Hi Otavio,

> -----Original Message-----
> From: yocto-bounces@yoctoproject.org [mailto:yocto-bounces@yoctoproject.org]
> On Behalf Of Otavio Salvador
> Sent: Wednesday, September 27, 2017 10:29 AM
> To: Khem Raj <raj.khem@gmail.com>
> Cc: yocto@lists.yoctoproject.org; Otavio Salvador <otavio@ossystems.com.br>
> Subject: Re: [yocto] [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS
> support"
> 
> On Wed, Sep 27, 2017 at 2:20 PM, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > On Wed, Sep 27, 2017 at 10:17 AM Andrei Gherzan <andrei@gherzan.ro> wrote:
> >>
> >> On Wed, Sep 27, 2017 at 4:23 PM, Martin Jansa
> >> <martin.jansa@gmail.com>
> >> wrote:
> >>>
> >>> * this reverts commit 04b37dbdb79638b17a670280058400ffaf1b6ccb.
> >>> * this makes qtbase and everything which depends on some qt* recipe to
> >>>   be effectivelly MACHINE_ARCH
> >>>
> >>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> >>> ---
> >>>  dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 ---
> >>>  1 file changed, 3 deletions(-)
> >>>  delete mode 100644
> >>> dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> >>>
> >>> diff --git
> >>> a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> >>> b/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> >>> deleted file mode 100644
> >>> index ae3f1d3..0000000
> >>> --- a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> >>> +++ /dev/null
> >>> @@ -1,3 +0,0 @@
> >>> -# Copyright (C) 2017 O.S. Systems Software LTDA.
> >>> -
> >>> -PACKAGECONFIG_GL_rpi   = "gles2 eglfs"
> >>
> >>
> >> What would be the solution though?
> >
> > I think check for OpenGL feature to enable it I think another thing is
> > to also check for X11 in distro features before enabling it
> >
> > Gl support is quite soc specific so I don't think there is an elegant
> > way unless qt components can be built with soc specific elements as
> > plugins or something which then can have independent recipe
> 
> https://github.com/Freescale/meta-freescale/blob/master/classes/fsl-dynamic-
> packagearch.bbclass
> 
> Something like this?
> 

This is very useful, can this concept be upstreamed to OE-Core?

Thanks,
Manju

Re: [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[Otavio Salvador]

On Wed, Sep 27, 2017 at 3:53 PM, Manjukumar Harthikote Matha
<MANJUKUM@xilinx.com> wrote:
...
>> https://github.com/Freescale/meta-freescale/blob/master/classes/fsl-dynamic-
>> packagearch.bbclass
>>
>> Something like this?
>>
>
> This is very useful, can this concept be upstreamed to OE-Core?

I think so; if people agree with this concept I can work in upstreaming it.

There is also the machine-overrides-extender.bbclass[1] which allows
for overrides to be added/removed based on other overrides.

1. https://github.com/Freescale/meta-freescale/blob/master/classes/machine-overrides-extender.bbclass

This was how I could generalize the BSP in a kind of SoC feature set.

You can see the original commit where I enable it:

https://github.com/Freescale/meta-freescale/commit/ad4611ab16bcd09eef11d630159253a12c5ecced#diff-7bac7755a2891a94e863ed0a7af1876a

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[Manjukumar Harthikote Matha]

Hi Otavio,

> -----Original Message-----
> From: Otavio Salvador [mailto:otavio.salvador@ossystems.com.br]
> Sent: Wednesday, September 27, 2017 12:23 PM
> To: Manjukumar Harthikote Matha <MANJUKUM@xilinx.com>
> Cc: Khem Raj <raj.khem@gmail.com>; yocto@lists.yoctoproject.org; Otavio
> Salvador <otavio@ossystems.com.br>
> Subject: Re: [yocto] [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS
> support"
> 
> On Wed, Sep 27, 2017 at 3:53 PM, Manjukumar Harthikote Matha
> <MANJUKUM@xilinx.com> wrote:
> ...
> >> https://github.com/Freescale/meta-freescale/blob/master/classes/fsl-dynamic-
> >> packagearch.bbclass
> >>
> >> Something like this?
> >>
> >
> > This is very useful, can this concept be upstreamed to OE-Core?
> 
> I think so; if people agree with this concept I can work in upstreaming it.
> 
> There is also the machine-overrides-extender.bbclass[1] which allows
> for overrides to be added/removed based on other overrides.
> 
> 1. https://github.com/Freescale/meta-freescale/blob/master/classes/machine-
> overrides-extender.bbclass
> 
> This was how I could generalize the BSP in a kind of SoC feature set.
> 
> You can see the original commit where I enable it:
> 
> https://github.com/Freescale/meta-
> freescale/commit/ad4611ab16bcd09eef11d630159253a12c5ecced#diff-
> 7bac7755a2891a94e863ed0a7af1876a
> 
Thanks for the patch.

We were thinking on similar lines for SOC variants and MACHINE variants (basically boards supporting different features like GPU, VCU etc).  These configuration mechanism will help resolve these cases. 
SOARCH can also help in package-feed mechanism for boards

You should definitely considering up streaming these to OE-core

Thanks,
Manju

Re: [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[Otavio Salvador]

On Wed, Sep 27, 2017 at 5:14 PM, Manjukumar Harthikote Matha
<MANJUKUM@xilinx.com> wrote:
>> -----Original Message-----
>> From: Otavio Salvador [mailto:otavio.salvador@ossystems.com.br]
>> Sent: Wednesday, September 27, 2017 12:23 PM
>> To: Manjukumar Harthikote Matha <MANJUKUM@xilinx.com>
>> Cc: Khem Raj <raj.khem@gmail.com>; yocto@lists.yoctoproject.org; Otavio
>> Salvador <otavio@ossystems.com.br>
>> Subject: Re: [yocto] [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS
>> support"
>>
>> On Wed, Sep 27, 2017 at 3:53 PM, Manjukumar Harthikote Matha
>> <MANJUKUM@xilinx.com> wrote:
>> ...
>> >> https://github.com/Freescale/meta-freescale/blob/master/classes/fsl-dynamic-
>> >> packagearch.bbclass
>> >>
>> >> Something like this?
>> >>
>> >
>> > This is very useful, can this concept be upstreamed to OE-Core?
>>
>> I think so; if people agree with this concept I can work in upstreaming it.
>>
>> There is also the machine-overrides-extender.bbclass[1] which allows
>> for overrides to be added/removed based on other overrides.
>>
>> 1. https://github.com/Freescale/meta-freescale/blob/master/classes/machine-
>> overrides-extender.bbclass
>>
>> This was how I could generalize the BSP in a kind of SoC feature set.
>>
>> You can see the original commit where I enable it:
>>
>> https://github.com/Freescale/meta-
>> freescale/commit/ad4611ab16bcd09eef11d630159253a12c5ecced#diff-
>> 7bac7755a2891a94e863ed0a7af1876a
>>
> Thanks for the patch.
>
> We were thinking on similar lines for SOC variants and MACHINE variants (basically boards supporting different features like GPU, VCU etc).  These configuration mechanism will help resolve these cases.
> SOARCH can also help in package-feed mechanism for boards
>
> You should definitely considering up streaming these to OE-core

That was the goal. I will work on this.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[Trevor Woerner]

On Wed, Sep 27, 2017 at 3:22 PM, Otavio Salvador
<otavio.salvador@ossystems.com.br> wrote:
>> This is very useful, can this concept be upstreamed to OE-Core?
>
> I think so; if people agree with this concept I can work in upstreaming it.
>
> There is also the machine-overrides-extender.bbclass[1] which allows
> for overrides to be added/removed based on other overrides.
>
> 1. https://github.com/Freescale/meta-freescale/blob/master/classes/machine-overrides-extender.bbclass

I've been trying (begging) since the start of August to get the above
one added to OE-core
https://bugzilla.yoctoproject.org/show_bug.cgi?id=11881

Re: [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[Andrei Gherzan]

On Wed, Sep 27, 2017 at 02:45:07PM -0300, Otavio Salvador wrote:
> Hello Martin,
>
> On Wed, Sep 27, 2017 at 2:34 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> ...
> >> Martin, do you have any idea how other alternative we have?
> >
> > In theory you can set QT_PACKAGES_ARCH to MACHINE_ARCH in rpi-base.inc
> > to make it explicit, but that's also really bad (as e.g. rpi2 and rpi3
> > will each build it's own qtwebengine and all it's deps even when it
> > should be the same for both).
>
> Agreed and that was the reason of we create MACHINE_SOCARCH in
> meta-freescale. It allows for SoC specific packages but compatible
> across machines.
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Merged to master in the meanwhile.

--
Andrei Gherzan
gpg: rsa4096/D4D94F67AD0E9640 | t: @agherzan