All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 3/6] nvme: claim block devices
Date: Mon, 2 Oct 2017 18:42:18 +0200	[thread overview]
Message-ID: <20171002164218.GA11886@lst.de> (raw)
In-Reply-To: <1506952559-1588-4-git-send-email-hare@suse.de>

On Mon, Oct 02, 2017@03:55:56PM +0200, Hannes Reinecke wrote:
> When setting up a multipath device we need to claim the underlying
> block devices to avoid other systems and/or programs to access it.
> And we should be using the standard holders/slave sysfs relationship
> instead of the hand-crafted 'mpath' links.

This completely breaks backwards compatibility:

root at testvm:~# mkfs.xfs /dev/nvme0n1 -f
mkfs.xfs: cannot open /dev/nvme0n1: Device or resource busy

Also we really do not want and outstanding struct block_device reference
all the time - struct block_device should only have a reference if
the block device node is in use or a file system is mounted.  Avoiding
this case was the whole point of my refactor to store the gendisk
instead of the block_device in struct bio.

  reply	other threads:[~2017-10-02 16:42 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-02 13:55 [PATCH 0/6] nvme: sanitize multipathing Hannes Reinecke
2017-10-02 13:55 ` [PATCH 1/6] nvme: display 'CMIC' controller attribute Hannes Reinecke
2017-10-02 16:15   ` Christoph Hellwig
2017-10-02 13:55 ` [PATCH 2/6] nvme: use 'nvmsXnZ' instead of 'nvm-subXnZ' Hannes Reinecke
2017-10-02 16:16   ` Christoph Hellwig
2017-10-02 16:20     ` Keith Busch
2017-10-11 14:32       ` Guan Junxiong
2017-10-02 13:55 ` [PATCH 3/6] nvme: claim block devices Hannes Reinecke
2017-10-02 16:42   ` Christoph Hellwig [this message]
2017-10-03 10:08     ` Hannes Reinecke
2017-10-03 11:55       ` Christoph Hellwig
2017-10-04  5:42         ` Hannes Reinecke
2017-10-04  6:15           ` Christoph Hellwig
2017-10-04  6:33             ` Hannes Reinecke
2017-10-04  7:13               ` Christoph Hellwig
2017-10-04  7:26                 ` Hannes Reinecke
2017-10-05  1:08                 ` Martin K. Petersen
2017-10-05  6:51                   ` Johannes Thumshirn
2017-10-05 14:05                     ` Keith Busch
2017-10-05 14:39                       ` Hannes Reinecke
2017-10-05 14:47                         ` Christoph Hellwig
2017-10-02 13:55 ` [PATCH 4/6] nvme: display 'NMIC' namespace attribute Hannes Reinecke
2017-10-02 16:16   ` Christoph Hellwig
2017-10-03 10:00     ` Hannes Reinecke
2017-10-03 11:49       ` Christoph Hellwig
2017-10-03 16:01         ` Hannes Reinecke
2017-10-02 13:55 ` [PATCH 5/6] nvme: Export subsystems to /sys/class/nvme-subsys Hannes Reinecke
2017-10-02 16:18   ` Christoph Hellwig
2017-10-02 16:53     ` Keith Busch
2017-10-02 16:56       ` Christoph Hellwig
2017-10-02 17:15         ` Keith Busch
2017-10-02 13:55 ` [PATCH 6/6] nvme: ignore retries for multipath devices Hannes Reinecke
2017-10-02 16:22   ` Christoph Hellwig
2017-10-03 10:02     ` Hannes Reinecke
2017-10-03 11:53       ` Christoph Hellwig
2017-10-02 14:35 ` [PATCH] nvme: reset retires after path failover Johannes Thumshirn
2017-10-02 14:43   ` Keith Busch
2017-10-02 15:08     ` Hannes Reinecke
2017-10-02 14:45   ` Johannes Thumshirn
2017-10-02 16:25     ` Christoph Hellwig
2017-10-02 14:46   ` Johannes Thumshirn
2017-10-02 16:19   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171002164218.GA11886@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.