From: Stephen Hemminger <stephen@networkplumber.org>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [Bridge] [PATCH] bridge: Fix format string for %ul
Date: Tue, 3 Oct 2017 13:43:11 -0700 [thread overview]
Message-ID: <20171003134311.34681644@xeon-e3> (raw)
In-Reply-To: <1472267428-810527-1-git-send-email-green@linuxhacker.ru>
On Fri, 26 Aug 2016 23:10:28 -0400
Oleg Drokin <green@linuxhacker.ru> wrote:
> %ul would print an unsigned value and a letter l,
> likely it was %lu that was meant to print the long int,
> but in reality the values printed there are just regular signed
> ints, so just dropping the l altogether.
>
> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> ---
> net/bridge/br_stp_bpdu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_stp_bpdu.c b/net/bridge/br_stp_bpdu.c
> index 5881fbc..15c4a9c 100644
> --- a/net/bridge/br_stp_bpdu.c
> +++ b/net/bridge/br_stp_bpdu.c
> @@ -230,7 +230,7 @@ void br_stp_rcv(const struct stp_proto *proto, struct sk_buff *skb,
> if (net_ratelimit())
> br_notice(p->br,
> "port %u config from %pM"
> - " (message_age %ul > max_age %ul)\n",
> + " (message_age %u > max_age %u)\n",
> p->port_no,
> eth_hdr(skb)->h_source,
> bpdu.message_age, bpdu.max_age);
Could you make the format string a single line plwase.
And add Fixes tag.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: "David S. Miller" <davem@davemloft.net>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bridge: Fix format string for %ul
Date: Tue, 3 Oct 2017 13:43:11 -0700 [thread overview]
Message-ID: <20171003134311.34681644@xeon-e3> (raw)
In-Reply-To: <1472267428-810527-1-git-send-email-green@linuxhacker.ru>
On Fri, 26 Aug 2016 23:10:28 -0400
Oleg Drokin <green@linuxhacker.ru> wrote:
> %ul would print an unsigned value and a letter l,
> likely it was %lu that was meant to print the long int,
> but in reality the values printed there are just regular signed
> ints, so just dropping the l altogether.
>
> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> ---
> net/bridge/br_stp_bpdu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_stp_bpdu.c b/net/bridge/br_stp_bpdu.c
> index 5881fbc..15c4a9c 100644
> --- a/net/bridge/br_stp_bpdu.c
> +++ b/net/bridge/br_stp_bpdu.c
> @@ -230,7 +230,7 @@ void br_stp_rcv(const struct stp_proto *proto, struct sk_buff *skb,
> if (net_ratelimit())
> br_notice(p->br,
> "port %u config from %pM"
> - " (message_age %ul > max_age %ul)\n",
> + " (message_age %u > max_age %u)\n",
> p->port_no,
> eth_hdr(skb)->h_source,
> bpdu.message_age, bpdu.max_age);
Could you make the format string a single line plwase.
And add Fixes tag.
next prev parent reply other threads:[~2017-10-03 20:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 3:10 [Bridge] [PATCH] bridge: Fix format string for %ul Oleg Drokin
2016-08-27 3:10 ` Oleg Drokin
2016-08-27 15:13 ` [Bridge] " Sergei Shtylyov
2016-08-27 15:13 ` Sergei Shtylyov
2016-08-27 15:13 ` Sergei Shtylyov
2016-08-27 15:58 ` [Bridge] " Oleg Drokin
2016-08-27 15:58 ` Oleg Drokin
2016-08-27 16:18 ` [Bridge] " Sergei Shtylyov
2016-08-27 16:18 ` Sergei Shtylyov
2016-08-27 16:18 ` Sergei Shtylyov
2016-08-27 16:36 ` [Bridge] " Oleg Drokin
2016-08-27 16:36 ` Oleg Drokin
2017-10-03 20:43 ` Stephen Hemminger [this message]
2017-10-03 20:43 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003134311.34681644@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=green@linuxhacker.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.