All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tobin C. Harding" <me@tobin.cc>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Petr Mladek <pmladek@suse.com>, Joe Perches <joe@perches.com>,
	Ian Campbell <ijc@hellion.org.uk>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	kernel-hardening@lists.openwall.com,
	linux-kernel@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	William Roberts <william.c.roberts@intel.com>,
	Chris Fries <cfries@google.com>,
	Dave Weinstein <olorin@google.com>
Subject: Re: [kernel-hardening] [RFC V2 0/6] add more kernel pointer filter options
Date: Wed, 4 Oct 2017 21:45:49 +1100	[thread overview]
Message-ID: <20171004104549.GD16685@eros> (raw)
In-Reply-To: <20171004085756.GD28247@kroah.com>

On Wed, Oct 04, 2017 at 10:57:56AM +0200, Greg KH wrote:
> On Sun, Oct 01, 2017 at 11:11:05AM +1100, Tobin C. Harding wrote:
> > On Sun, Oct 01, 2017 at 11:06:44AM +1100, Tobin C. Harding wrote:
> > > Version 2 of Greg's patch series with changes made as suggested by comments to V1.
> > 
> > Patch set tested by setting /proc/sys/kernel/kptr_restrict and inserting the following module
> > 
> > #include <linux/init.h>
> > #include <linux/module.h>
> > 
> > #define DRIVER_AUTHOR "Tobin C. Harding <me@tobin.cc>"
> > #define DRIVER_DESC "Testing module"
> > 
> > static void test_printk(void)
> > {
> > 	char *ptr = "";
> > 
> > 	pr_alert("printing with p: %p\n", ptr);
> > 	pr_alert("printing with pK: %pK\n", ptr);
> > 	pr_alert("printing with pP: %pP\n", ptr);
> > 
> > 	pr_alert("printing with pa: %pa\n", ptr);
> > 	pr_alert("printing with pad: %pad\n", ptr);
> > 	pr_alert("printing with pap: %pap\n", ptr);
> > 
> > 	pr_alert("printing with paP: %paP\n", ptr);
> > 	pr_alert("printing with padP: %padP\n", ptr);
> > 	pr_alert("printing with papP: %papP\n", ptr);
> > 
> > 	pr_alert("printing with pr: %pr\n", ptr);
> > 	pr_alert("printing with pR: %pR\n", ptr);
> > }
> > 
> > static int hello_init(void)
> > {
> > 	pr_alert("Hello, world\n");
> > 
> > 	test_printk();
> > 
> > 	return 0;
> > }
> > module_init(hello_init);
> > 
> > static void hello_exit(void)
> > {
> > 	pr_alert("Goodbye, world\n");
> > }
> > module_exit(hello_exit);
> > 
> > MODULE_DESCRIPTION(DRIVER_DESC);
> > MODULE_AUTHOR(DRIVER_AUTHOR);
> > MODULE_LICENSE("GPL");
> 
> 
> Hm, any way to add something like this to the testing infrastructure?
> Or maybe just at boot time?  It's nice to keep tests around to ensure
> things do not break :)

Sure, good idea, I'll look into it. It will be my first attempt at adding tests to the kernel so
will come as a separate patch set some time soon.

thanks,
Tobin.

  reply	other threads:[~2017-10-04 10:45 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-01  0:06 [kernel-hardening] [RFC V2 0/6] add more kernel pointer filter options Tobin C. Harding
2017-10-01  0:06 ` [kernel-hardening] [RFC V2 1/6] lib: vsprintf: additional kernel pointer filtering options Tobin C. Harding
2017-10-04  8:55   ` Greg KH
2017-10-04 13:08     ` Steven Rostedt
2017-10-04 13:26       ` Greg KH
2017-10-04 13:29         ` Steven Rostedt
2017-10-04 13:54           ` Greg KH
2017-10-01  0:06 ` [kernel-hardening] [RFC V2 2/6] lib: vsprintf: whitelist stack traces Tobin C. Harding
2017-10-02 10:42   ` Will Deacon
2017-10-02 21:49     ` Tobin C. Harding
2017-10-04  8:56     ` Greg KH
2017-10-04  8:58       ` Will Deacon
2017-10-04  9:02         ` Greg KH
2017-10-04 10:42           ` Tobin C. Harding
2017-10-01  0:06 ` [kernel-hardening] [RFC V2 3/6] lib: vsprintf: physical address kernel pointer filtering options Tobin C. Harding
2017-10-04  8:58   ` Greg KH
2017-10-01  0:06 ` [kernel-hardening] [RFC V2 4/6] lib: vsprintf: default kptr_restrict to the maximum value Tobin C. Harding
2017-10-04  8:55   ` Greg KH
2017-10-04 16:42   ` Kees Cook
2017-10-04 16:48     ` Roberts, William C
2017-10-04 17:08     ` Linus Torvalds
2017-10-04 17:28       ` Linus Torvalds
2017-10-04 19:13         ` Jann Horn
2017-10-04 19:23           ` Linus Torvalds
2017-10-01  0:06 ` [kernel-hardening] [RFC V2 5/6] lib: vsprintf: add "%paP", "%papP", and "%padP" specifiers Tobin C. Harding
2017-10-04  8:58   ` Greg KH
2017-10-01  0:06 ` [kernel-hardening] [RFC V2 6/6] drivers: uio: un-restrict sysfs pointers for UIO Tobin C. Harding
2017-10-04  8:58   ` Greg KH
2017-10-01  0:11 ` [kernel-hardening] [RFC V2 0/6] add more kernel pointer filter options Tobin C. Harding
2017-10-04  8:57   ` Greg KH
2017-10-04 10:45     ` Tobin C. Harding [this message]
2017-10-04  8:58 ` Greg KH
2017-10-04 10:50   ` Tobin C. Harding
2017-10-04 12:42     ` Greg KH
2017-10-04 13:28       ` Steven Rostedt
2017-10-04 13:28         ` Steven Rostedt
2017-10-04 13:31         ` Steven Rostedt
2017-10-04 16:17   ` Roberts, William C
2017-10-04 15:41 ` Linus Torvalds
2017-10-04 16:22   ` Boris Lukashev
2017-10-04 16:29     ` Linus Torvalds
2017-10-04 16:54       ` Steven Rostedt
2017-10-04 18:58   ` Jordan Glover
2017-10-04 19:19     ` Linus Torvalds
2017-10-04 21:58       ` Roberts, William C
2017-10-04 23:21         ` Daniel Micay
2017-10-04 23:52         ` Linus Torvalds
2017-10-05  0:09           ` Linus Torvalds
2017-10-05 13:55             ` Bjorn Helgaas
2017-10-05  0:29           ` Daniel Micay
2017-10-05  0:35             ` Kees Cook
2017-10-06  8:33               ` Djalal Harouni
2017-10-05  2:19           ` Tobin C. Harding
2017-10-05  3:10             ` Linus Torvalds
2017-10-05  3:15               ` Kees Cook
2017-10-05 15:12               ` Roberts, William C
2017-10-05 16:19                 ` Linus Torvalds
2017-10-05 17:10                   ` Dave Weinstein
2017-10-07 23:44                   ` Theodore Ts'o
2017-10-08  0:08                     ` Linus Torvalds
2017-10-13 16:32                       ` Roberts, William C
2017-10-13 18:11                         ` Linus Torvalds
2017-10-13 19:34                           ` Kees Cook
2017-10-13 20:22                             ` Linus Torvalds
2017-10-13 20:47                               ` Kees Cook
2017-10-13 21:45                                 ` Linus Torvalds
2017-10-13 22:48                                 ` Theodore Ts'o
2017-10-13 16:14             ` Roberts, William C
2017-10-04 16:32 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171004104549.GD16685@eros \
    --to=me@tobin.cc \
    --cc=catalin.marinas@arm.com \
    --cc=cfries@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ijc@hellion.org.uk \
    --cc=joe@perches.com \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olorin@google.com \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=will.deacon@arm.com \
    --cc=william.c.roberts@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.