From: "KAVITA MATHUR" <kavitam@cdot.in>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
ath10k <ath10k@lists.infradead.org>,
Ben Greear <greearb@candelatech.com>,
Johannes Berg <johannes.berg@intel.com>,
kirtika@google.com
Subject: Not able to set single rate in ath10k (backports-4.14-rc2-1)
Date: Wed, 11 Oct 2017 10:07:33 +0530 [thread overview]
Message-ID: <20171011043733.M56782@cdot.in> (raw)
In-Reply-To: <13895fa0-3685-dd2b-583d-2d6469d23cfe@candelatech.com>
Hi,
I got the same error while setting single rate in ath10k
firmware version : firmware-5.bin_10.2.4.70.66
ath10k version : backports-4.14-rc2-1.tar.xz
After running following commands, I got error and rate didn't set. Please see following
log for error and help me to resolve it.
root@CDOT-BBWT:/etc# iw wlan0 info
Interface wlan0
ifindex 30
wdev 0x1a
addr 04:f0:21:25:45:81
ssid test
type AP
wiphy 0
channel 153 (5765 MHz), width: 40 MHz, center1: 5755 MHz
txpower 18.00 dBm
root@CDOT-BBWT:/etc#
root@CDOT-BBWT:/etc#
root@CDOT-BBWT:/etc# iw wlan0 set bitrates legacy-5 ht-mcs-5 vht-mcs-5 2:4
command failed: Invalid argument (-22)
root@CDOT-BBWT:/etc#
root@CDOT-BBWT:/etc#
root@CDOT-BBWT:/etc#
root@CDOT-BBWT:/etc#
root@CDOT-BBWT:/etc# iw wlan0 set bitrates legacy-5 24 ht-mcs-5 vht-mcs-5 2:4
ath10k_pci 0001:02:00.0: refusing bitrate mask with missing 0-7 VHT MCS rates
command failed: Invalid argument (-22)
root@CDOT-BBWT:/etc# iw wlan0 set bitrates legacy-5 24 ht-mcs-5 4 vht-mcs-5 2:4
ath10k_pci 0001:02:00.0: refusing bitrate mask with missing 0-7 VHT MCS rates
command failed: Invalid argument (-22)
root@CDOT-BBWT:/etc# iw wlan0 set bitrates legacy-5 24 ht-mcs-5 4 vht-mcs-5 2:0-4
ath10k_pci 0001:02:00.0: refusing bitrate mask with missing 0-7 VHT MCS rates
command failed: Invalid argument (-22)
root@CDOT-BBWT:/etc# iw wlan0 set bitrates legacy-5 24 ht-mcs-5 4 vht-mcs-5 2:0-7
Following commands works without any error , but it take range of MCS.My requirement is
to set single rate.
# iw wlan0 set bitrates legacy-5 24 ht-mcs-5 4 vht-mcs-5 2:0-7
Thanks & Regards,
कविता माथुर Kavita Mathur
वरिष्ठ अनुसंधान अभियंता Senior Research Engineer
सी-डॉट C-DOT
इलैक्ट्रॉनिक्स सिटी फेज़ I Electronics City Phase I
होसूर रोड, बेंगलूरु Hosur Road, Bengaluru – 560100
फोन Ph 080-28529896
On Tue, 10 Oct 2017 13:54:20 -0700, Ben Greear wrote
> At one point, you could set a single rate using 'iw' and
> ath10k would convert that to a special firmware API that
> fixed all data traffic to a particular rate set. (Management
> frames and broadcast will not be affected by setting the rates
> when using ath10k).
>
> But, with the commit below, a command like this will fail:
>
> #iw dev vap206 set bitrates legacy-5 ht-mcs-5 0 vht-mcs-5
> command failed: Invalid argument (-22)
>
> But, it actually *does* successfully set the rate in the driver first, which
> is confusing at best.
>
> So, I think we should relax this check, at least for ath10k.
>
> commit e8e4f5280ddd0a7b43a795f90a0758e3c99df6a6
> Author: Johannes Berg <johannes.berg@intel.com>
> Date: Wed Mar 8 11:12:10 2017 +0100
>
> mac80211: reject/clear user rate mask if not usable
>
> If the user rate mask results in no (basic) rates being usable,
> clear it. Also, if we're already operating when it's set, reject
> it instead.
>
> Technically, selecting basic rates as the criterion is a bit too
> restrictive, but calculating the usable rates over all stations
> (e.g. in AP mode) is harder, and all stations must support the
> basic rates. Similarly, in client mode, the basic rates will be
> used anyway for control frames.
>
> This fixes the "no supported rates (...) in rate_mask ..." warning
> that occurs on TX when you've selected a rate mask that's not
> compatible with the connection (e.g. an AP that enables only the
> rates 36, 48, 54 and you've selected only 6, 9, 12.)
>
> Reported-by: Kirtika Ruchandani <kirtika@google.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>
> Thanks,
> Ben
>
> --
> Ben Greear <greearb@candelatech.com>
> Candela Technologies Inc http://www.candelatech.com
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
Thanks & Regards,
कविता माथुर Kavita Mathur
वरिष्ठ अनुसंधान अभियंता Senior Research Engineer
सी-डॉट C-DOT
इलैक्ट्रॉनिक्स सिटी फेज़ I Electronics City Phase I
होसूर रोड, बेंगलूरु Hosur Road, Bengaluru – 560100
फोन Ph 080-28529896
Disclaimer:
----------
This email and any files transmitted with it
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-10-11 4:46 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 20:54 Setting single rate in ath10k broken by "reject/clear user rate mask if not usable" Ben Greear
2017-10-10 20:54 ` Ben Greear
2017-10-11 4:37 ` KAVITA MATHUR [this message]
2017-10-11 8:02 ` Johannes Berg
2017-10-11 8:02 ` Johannes Berg
2017-10-11 8:07 ` Johannes Berg
2017-10-11 8:07 ` Johannes Berg
2017-10-11 14:51 ` Ben Greear
2017-10-11 14:51 ` Ben Greear
2017-10-18 7:33 ` Johannes Berg
2017-10-18 7:33 ` Johannes Berg
2017-10-18 14:50 ` Ben Greear
2017-10-18 14:50 ` Ben Greear
2017-10-18 17:56 ` Oleksij Rempel
2017-10-18 17:56 ` Oleksij Rempel
2017-10-18 20:34 ` Johannes Berg
2017-10-18 20:34 ` Johannes Berg
2017-10-18 20:51 ` Ben Greear
2017-10-18 20:51 ` Ben Greear
2017-10-18 21:02 ` Johannes Berg
2017-10-18 21:02 ` Johannes Berg
2017-10-18 21:30 ` Ben Greear
2017-10-18 21:30 ` Ben Greear
2017-10-25 15:17 ` Johannes Berg
2017-10-25 15:17 ` Johannes Berg
2017-10-25 16:13 ` Ben Greear
2017-10-25 16:13 ` Ben Greear
2017-10-27 20:15 ` Johannes Berg
2017-10-27 20:15 ` Johannes Berg
2017-10-27 20:41 ` Ben Greear
2017-10-27 20:41 ` Ben Greear
2017-11-13 10:09 ` Johannes Berg
2017-11-13 10:09 ` Johannes Berg
2017-11-13 17:05 ` Ben Greear
2017-11-13 17:05 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011043733.M56782@cdot.in \
--to=kavitam@cdot.in \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=johannes.berg@intel.com \
--cc=kirtika@google.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.