All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
	Oleksij Rempel <linux@rempel-privat.de>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	ath10k <ath10k@lists.infradead.org>,
	kirtika@google.com
Subject: Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"
Date: Mon, 13 Nov 2017 11:09:43 +0100	[thread overview]
Message-ID: <1510567783.30497.33.camel@sipsolutions.net> (raw)
In-Reply-To: <a1adb2ea-44c4-67ae-1044-08c4dc16bb9a@candelatech.com>

On Fri, 2017-10-27 at 13:41 -0700, Ben Greear wrote:

> ath10k ignores the tx rateset pretty much entirely when sending management
> frames, so even if you set the tx rateset to have only VHT MCS 8,
> management frames are still sent with legacy ratesets.

So that's a driver bug.

> My end goal about this part is to be able to configure a single tx rate
> and have that be allowed again, at least with ath10k.
> 
> Maybe a new flag for drivers like ath10k that at least somewhat ignore
> the tx-rateset for management frames, and this flag would allow us to
> bypass the cannot-set-single-rate check?

What? No, I'm not going to put a driver bug into the API like that!

johannes

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
	Oleksij Rempel <linux@rempel-privat.de>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	ath10k <ath10k@lists.infradead.org>,
	kirtika@google.com
Subject: Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"
Date: Mon, 13 Nov 2017 11:09:43 +0100	[thread overview]
Message-ID: <1510567783.30497.33.camel@sipsolutions.net> (raw)
In-Reply-To: <a1adb2ea-44c4-67ae-1044-08c4dc16bb9a@candelatech.com>

On Fri, 2017-10-27 at 13:41 -0700, Ben Greear wrote:

> ath10k ignores the tx rateset pretty much entirely when sending management
> frames, so even if you set the tx rateset to have only VHT MCS 8,
> management frames are still sent with legacy ratesets.

So that's a driver bug.

> My end goal about this part is to be able to configure a single tx rate
> and have that be allowed again, at least with ath10k.
> 
> Maybe a new flag for drivers like ath10k that at least somewhat ignore
> the tx-rateset for management frames, and this flag would allow us to
> bypass the cannot-set-single-rate check?

What? No, I'm not going to put a driver bug into the API like that!

johannes

  reply	other threads:[~2017-11-13 10:10 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10 20:54 Setting single rate in ath10k broken by "reject/clear user rate mask if not usable" Ben Greear
2017-10-10 20:54 ` Ben Greear
2017-10-11  4:37 ` Not able to set single rate in ath10k (backports-4.14-rc2-1) KAVITA MATHUR
2017-10-11  8:02 ` Setting single rate in ath10k broken by "reject/clear user rate mask if not usable" Johannes Berg
2017-10-11  8:02   ` Johannes Berg
2017-10-11  8:07   ` Johannes Berg
2017-10-11  8:07     ` Johannes Berg
2017-10-11 14:51   ` Ben Greear
2017-10-11 14:51     ` Ben Greear
2017-10-18  7:33     ` Johannes Berg
2017-10-18  7:33       ` Johannes Berg
2017-10-18 14:50       ` Ben Greear
2017-10-18 14:50         ` Ben Greear
2017-10-18 17:56         ` Oleksij Rempel
2017-10-18 17:56           ` Oleksij Rempel
2017-10-18 20:34           ` Johannes Berg
2017-10-18 20:34             ` Johannes Berg
2017-10-18 20:51             ` Ben Greear
2017-10-18 20:51               ` Ben Greear
2017-10-18 21:02               ` Johannes Berg
2017-10-18 21:02                 ` Johannes Berg
2017-10-18 21:30                 ` Ben Greear
2017-10-18 21:30                   ` Ben Greear
2017-10-25 15:17                   ` Johannes Berg
2017-10-25 15:17                     ` Johannes Berg
2017-10-25 16:13                     ` Ben Greear
2017-10-25 16:13                       ` Ben Greear
2017-10-27 20:15                       ` Johannes Berg
2017-10-27 20:15                         ` Johannes Berg
2017-10-27 20:41                         ` Ben Greear
2017-10-27 20:41                           ` Ben Greear
2017-11-13 10:09                           ` Johannes Berg [this message]
2017-11-13 10:09                             ` Johannes Berg
2017-11-13 17:05                             ` Ben Greear
2017-11-13 17:05                               ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510567783.30497.33.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath10k@lists.infradead.org \
    --cc=greearb@candelatech.com \
    --cc=kirtika@google.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@rempel-privat.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.