* [PATCH] doc: enhance dochelp include default output location for doc build
2017-10-02 23:44 [PATCH] doc: dev-tools: kselftest.rst: update to include make O=dir support Shuah Khan
@ 2017-10-02 23:44 ` Shuah Khan
2017-10-02 23:44 ` [PATCH] Makefile: enable dochelp run from main make level Shuah Khan
` (3 subsequent siblings)
4 siblings, 0 replies; 14+ messages in thread
From: Shuah Khan @ 2017-10-02 23:44 UTC (permalink / raw)
To: corbet; +Cc: Shuah Khan, linux-doc, linux-kernel
Enhance documentation help message to specify the default location for
the generated documents.
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
Documentation/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/Makefile b/Documentation/Makefile
index 85f7856f0092..5e65fa5c6ab7 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -116,3 +116,5 @@ dochelp:
@echo
@echo ' make SPHINX_CONF={conf-file} [target] use *additional* sphinx-build'
@echo ' configuration. This is e.g. useful to build with nit-picking config.'
+ @echo
+ @echo ' Default location for the generated documents is Documentation/output'
--
2.11.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH] Makefile: enable dochelp run from main make level
2017-10-02 23:44 [PATCH] doc: dev-tools: kselftest.rst: update to include make O=dir support Shuah Khan
2017-10-02 23:44 ` [PATCH] doc: enhance dochelp include default output location for doc build Shuah Khan
@ 2017-10-02 23:44 ` Shuah Khan
2017-10-07 11:24 ` Masahiro Yamada
2017-10-02 23:44 ` [PATCH] selftests: mqueue: fix regression in silencing output from RUN_TESTS Shuah Khan
` (2 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: Shuah Khan @ 2017-10-02 23:44 UTC (permalink / raw)
To: yamada.masahiro, mmarek, corbet; +Cc: Shuah Khan, linux-kbuild, linux-kernel
Change to enable dochelp run from main make level to make it easier to
use it.
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index cf007a31d575..f99d1b36c437 100644
--- a/Makefile
+++ b/Makefile
@@ -1454,7 +1454,7 @@ $(help-board-dirs): help-%:
# Documentation targets
# ---------------------------------------------------------------------------
-DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs
+DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs dochelp
PHONY += $(DOC_TARGETS)
$(DOC_TARGETS): scripts_basic FORCE
$(Q)$(MAKE) $(build)=Documentation $@
--
2.11.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] Makefile: enable dochelp run from main make level
2017-10-02 23:44 ` [PATCH] Makefile: enable dochelp run from main make level Shuah Khan
@ 2017-10-07 11:24 ` Masahiro Yamada
2017-10-10 20:09 ` Shuah Khan
0 siblings, 1 reply; 14+ messages in thread
From: Masahiro Yamada @ 2017-10-07 11:24 UTC (permalink / raw)
To: Shuah Khan
Cc: Michal Marek, Jonathan Corbet, Linux Kbuild mailing list,
Linux Kernel Mailing List
2017-10-03 8:44 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
> Change to enable dochelp run from main make level to make it easier to
> use it.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index cf007a31d575..f99d1b36c437 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1454,7 +1454,7 @@ $(help-board-dirs): help-%:
>
> # Documentation targets
> # ---------------------------------------------------------------------------
> -DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs
> +DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs dochelp
> PHONY += $(DOC_TARGETS)
> $(DOC_TARGETS): scripts_basic FORCE
> $(Q)$(MAKE) $(build)=Documentation $@
> --
> 2.11.0
>
The dochelp is invoked from "make help" of the main make level.
Do you mean "make dochelp" is also necessary?
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Makefile: enable dochelp run from main make level
2017-10-07 11:24 ` Masahiro Yamada
@ 2017-10-10 20:09 ` Shuah Khan
2017-10-11 0:54 ` Masahiro Yamada
0 siblings, 1 reply; 14+ messages in thread
From: Shuah Khan @ 2017-10-10 20:09 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Michal Marek, Jonathan Corbet, Linux Kbuild mailing list,
Linux Kernel Mailing List, Shuah Khan
On 10/07/2017 05:24 AM, Masahiro Yamada wrote:
> 2017-10-03 8:44 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
>> Change to enable dochelp run from main make level to make it easier to
>> use it.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>> Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Makefile b/Makefile
>> index cf007a31d575..f99d1b36c437 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1454,7 +1454,7 @@ $(help-board-dirs): help-%:
>>
>> # Documentation targets
>> # ---------------------------------------------------------------------------
>> -DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs
>> +DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs dochelp
>> PHONY += $(DOC_TARGETS)
>> $(DOC_TARGETS): scripts_basic FORCE
>> $(Q)$(MAKE) $(build)=Documentation $@
>> --
>> 2.11.0
>>
>
>
> The dochelp is invoked from "make help" of the main make level.
>
> Do you mean "make dochelp" is also necessary?
>
Right. It is a bit hard to pick out individual help messages from
the 'make help' output and it would make it easier to use to enable
dochelp.
That said, it is your call on whether it would make it cumbersome to
support 'make dochlep' and other sub-makefile help targets.
I can go either way.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Makefile: enable dochelp run from main make level
2017-10-10 20:09 ` Shuah Khan
@ 2017-10-11 0:54 ` Masahiro Yamada
2017-10-11 0:58 ` Randy Dunlap
0 siblings, 1 reply; 14+ messages in thread
From: Masahiro Yamada @ 2017-10-11 0:54 UTC (permalink / raw)
To: Shuah Khan
Cc: Michal Marek, Jonathan Corbet, Linux Kbuild mailing list,
Linux Kernel Mailing List
2017-10-11 5:09 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
> On 10/07/2017 05:24 AM, Masahiro Yamada wrote:
>> 2017-10-03 8:44 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
>>> Change to enable dochelp run from main make level to make it easier to
>>> use it.
>>>
>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>> ---
>>> Makefile | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index cf007a31d575..f99d1b36c437 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -1454,7 +1454,7 @@ $(help-board-dirs): help-%:
>>>
>>> # Documentation targets
>>> # ---------------------------------------------------------------------------
>>> -DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs
>>> +DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs dochelp
>>> PHONY += $(DOC_TARGETS)
>>> $(DOC_TARGETS): scripts_basic FORCE
>>> $(Q)$(MAKE) $(build)=Documentation $@
>>> --
>>> 2.11.0
>>>
>>
>>
>> The dochelp is invoked from "make help" of the main make level.
>>
>> Do you mean "make dochelp" is also necessary?
>>
>
> Right. It is a bit hard to pick out individual help messages from
> the 'make help' output and it would make it easier to use to enable
> dochelp.
>
> That said, it is your call on whether it would make it cumbersome to
> support 'make dochlep' and other sub-makefile help targets.
>
> I can go either way.
>
I thought of this.
The same thing would apply to "make confighelp", "make pkghelp", ...
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Makefile: enable dochelp run from main make level
2017-10-11 0:54 ` Masahiro Yamada
@ 2017-10-11 0:58 ` Randy Dunlap
2017-10-11 1:06 ` Shuah Khan
0 siblings, 1 reply; 14+ messages in thread
From: Randy Dunlap @ 2017-10-11 0:58 UTC (permalink / raw)
To: Masahiro Yamada, Shuah Khan
Cc: Michal Marek, Jonathan Corbet, Linux Kbuild mailing list,
Linux Kernel Mailing List
On 10/10/17 17:54, Masahiro Yamada wrote:
> 2017-10-11 5:09 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
>> On 10/07/2017 05:24 AM, Masahiro Yamada wrote:
>>> 2017-10-03 8:44 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
>>>> Change to enable dochelp run from main make level to make it easier to
>>>> use it.
>>>>
>>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>>> ---
>>>> Makefile | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/Makefile b/Makefile
>>>> index cf007a31d575..f99d1b36c437 100644
>>>> --- a/Makefile
>>>> +++ b/Makefile
>>>> @@ -1454,7 +1454,7 @@ $(help-board-dirs): help-%:
>>>>
>>>> # Documentation targets
>>>> # ---------------------------------------------------------------------------
>>>> -DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs
>>>> +DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs dochelp
>>>> PHONY += $(DOC_TARGETS)
>>>> $(DOC_TARGETS): scripts_basic FORCE
>>>> $(Q)$(MAKE) $(build)=Documentation $@
>>>> --
>>>> 2.11.0
>>>>
>>>
>>>
>>> The dochelp is invoked from "make help" of the main make level.
>>>
>>> Do you mean "make dochelp" is also necessary?
>>>
>>
>> Right. It is a bit hard to pick out individual help messages from
>> the 'make help' output and it would make it easier to use to enable
>> dochelp.
>>
>> That said, it is your call on whether it would make it cumbersome to
>> support 'make dochlep' and other sub-makefile help targets.
>>
>> I can go either way.
>>
>
> I thought of this.
> The same thing would apply to "make confighelp", "make pkghelp", ...
Yes, especially confighelp. I have to use grep, otherwise there is too
much noise.
--
~Randy
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Makefile: enable dochelp run from main make level
2017-10-11 0:58 ` Randy Dunlap
@ 2017-10-11 1:06 ` Shuah Khan
2017-10-12 18:15 ` Randy Dunlap
2017-10-17 23:57 ` Masahiro Yamada
0 siblings, 2 replies; 14+ messages in thread
From: Shuah Khan @ 2017-10-11 1:06 UTC (permalink / raw)
To: Randy Dunlap, Masahiro Yamada
Cc: Michal Marek, Jonathan Corbet, Linux Kbuild mailing list,
Linux Kernel Mailing List, Shuah Khan
On 10/10/2017 06:58 PM, Randy Dunlap wrote:
> On 10/10/17 17:54, Masahiro Yamada wrote:
>> 2017-10-11 5:09 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
>>> On 10/07/2017 05:24 AM, Masahiro Yamada wrote:
>>>> 2017-10-03 8:44 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
>>>>> Change to enable dochelp run from main make level to make it easier to
>>>>> use it.
>>>>>
>>>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>>>> ---
>>>>> Makefile | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/Makefile b/Makefile
>>>>> index cf007a31d575..f99d1b36c437 100644
>>>>> --- a/Makefile
>>>>> +++ b/Makefile
>>>>> @@ -1454,7 +1454,7 @@ $(help-board-dirs): help-%:
>>>>>
>>>>> # Documentation targets
>>>>> # ---------------------------------------------------------------------------
>>>>> -DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs
>>>>> +DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs dochelp
>>>>> PHONY += $(DOC_TARGETS)
>>>>> $(DOC_TARGETS): scripts_basic FORCE
>>>>> $(Q)$(MAKE) $(build)=Documentation $@
>>>>> --
>>>>> 2.11.0
>>>>>
>>>>
>>>>
>>>> The dochelp is invoked from "make help" of the main make level.
>>>>
>>>> Do you mean "make dochelp" is also necessary?
>>>>
>>>
>>> Right. It is a bit hard to pick out individual help messages from
>>> the 'make help' output and it would make it easier to use to enable
>>> dochelp.
>>>
>>> That said, it is your call on whether it would make it cumbersome to
>>> support 'make dochlep' and other sub-makefile help targets.
>>>
>>> I can go either way.
>>>
>>
>> I thought of this.
>> The same thing would apply to "make confighelp", "make pkghelp", ...
>
> Yes, especially confighelp. I have to use grep, otherwise there is too
> much noise.
>
>
If you would like I can send patches to cover some of these cases.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Makefile: enable dochelp run from main make level
2017-10-11 1:06 ` Shuah Khan
@ 2017-10-12 18:15 ` Randy Dunlap
2017-10-17 23:57 ` Masahiro Yamada
1 sibling, 0 replies; 14+ messages in thread
From: Randy Dunlap @ 2017-10-12 18:15 UTC (permalink / raw)
To: Shuah Khan, Masahiro Yamada
Cc: Michal Marek, Jonathan Corbet, Linux Kbuild mailing list,
Linux Kernel Mailing List
On 10/10/17 18:06, Shuah Khan wrote:
> On 10/10/2017 06:58 PM, Randy Dunlap wrote:
>> On 10/10/17 17:54, Masahiro Yamada wrote:
>>> 2017-10-11 5:09 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
>>>> On 10/07/2017 05:24 AM, Masahiro Yamada wrote:
>>>>> 2017-10-03 8:44 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
>>>>>> Change to enable dochelp run from main make level to make it easier to
>>>>>> use it.
>>>>>>
>>>>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>>>>> ---
>>>>>> Makefile | 2 +-
>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/Makefile b/Makefile
>>>>>> index cf007a31d575..f99d1b36c437 100644
>>>>>> --- a/Makefile
>>>>>> +++ b/Makefile
>>>>>> @@ -1454,7 +1454,7 @@ $(help-board-dirs): help-%:
>>>>>>
>>>>>> # Documentation targets
>>>>>> # ---------------------------------------------------------------------------
>>>>>> -DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs
>>>>>> +DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs dochelp
>>>>>> PHONY += $(DOC_TARGETS)
>>>>>> $(DOC_TARGETS): scripts_basic FORCE
>>>>>> $(Q)$(MAKE) $(build)=Documentation $@
>>>>>> --
>>>>>> 2.11.0
>>>>>>
>>>>>
>>>>>
>>>>> The dochelp is invoked from "make help" of the main make level.
>>>>>
>>>>> Do you mean "make dochelp" is also necessary?
>>>>>
>>>>
>>>> Right. It is a bit hard to pick out individual help messages from
>>>> the 'make help' output and it would make it easier to use to enable
>>>> dochelp.
>>>>
>>>> That said, it is your call on whether it would make it cumbersome to
>>>> support 'make dochlep' and other sub-makefile help targets.
>>>>
>>>> I can go either way.
>>>>
>>>
>>> I thought of this.
>>> The same thing would apply to "make confighelp", "make pkghelp", ...
>>
>> Yes, especially confighelp. I have to use grep, otherwise there is too
>> much noise.
>>
>>
>
> If you would like I can send patches to cover some of these cases.
I would be happy to see that...
thanks,
--
~Randy
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Makefile: enable dochelp run from main make level
2017-10-11 1:06 ` Shuah Khan
2017-10-12 18:15 ` Randy Dunlap
@ 2017-10-17 23:57 ` Masahiro Yamada
1 sibling, 0 replies; 14+ messages in thread
From: Masahiro Yamada @ 2017-10-17 23:57 UTC (permalink / raw)
To: Shuah Khan
Cc: Randy Dunlap, Michal Marek, Jonathan Corbet,
Linux Kbuild mailing list, Linux Kernel Mailing List
2017-10-11 10:06 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
> On 10/10/2017 06:58 PM, Randy Dunlap wrote:
>> On 10/10/17 17:54, Masahiro Yamada wrote:
>>> 2017-10-11 5:09 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
>>>> On 10/07/2017 05:24 AM, Masahiro Yamada wrote:
>>>>> 2017-10-03 8:44 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:
>>>>>> Change to enable dochelp run from main make level to make it easier to
>>>>>> use it.
>>>>>>
>>>>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>>>>> ---
>>>>>> Makefile | 2 +-
>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/Makefile b/Makefile
>>>>>> index cf007a31d575..f99d1b36c437 100644
>>>>>> --- a/Makefile
>>>>>> +++ b/Makefile
>>>>>> @@ -1454,7 +1454,7 @@ $(help-board-dirs): help-%:
>>>>>>
>>>>>> # Documentation targets
>>>>>> # ---------------------------------------------------------------------------
>>>>>> -DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs
>>>>>> +DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs linkcheckdocs dochelp
>>>>>> PHONY += $(DOC_TARGETS)
>>>>>> $(DOC_TARGETS): scripts_basic FORCE
>>>>>> $(Q)$(MAKE) $(build)=Documentation $@
>>>>>> --
>>>>>> 2.11.0
>>>>>>
>>>>>
>>>>>
>>>>> The dochelp is invoked from "make help" of the main make level.
>>>>>
>>>>> Do you mean "make dochelp" is also necessary?
>>>>>
>>>>
>>>> Right. It is a bit hard to pick out individual help messages from
>>>> the 'make help' output and it would make it easier to use to enable
>>>> dochelp.
>>>>
>>>> That said, it is your call on whether it would make it cumbersome to
>>>> support 'make dochlep' and other sub-makefile help targets.
>>>>
>>>> I can go either way.
>>>>
>>>
>>> I thought of this.
>>> The same thing would apply to "make confighelp", "make pkghelp", ...
>>
>> Yes, especially confighelp. I have to use grep, otherwise there is too
>> much noise.
>>
>>
>
> If you would like I can send patches to cover some of these cases.
>
We have a kind of hierarchy
when arch/$(SRCARCH)/configs has sub-directories.
For example,
$ make ARCH=powerpc help
[ snip ]
storcenter_defconfig - Build for storcenter
tqm8xx_defconfig - Build for tqm8xx
wii_defconfig - Build for wii
help-40x - Show 40x-specific targets
help-44x - Show 44x-specific targets
help-52xx - Show 52xx-specific targets
help-83xx - Show 83xx-specific targets
help-85xx - Show 85xx-specific targets
help-boards - Show all of the above
I think your suggestion is, to keep the top "make help" as-is
and add new targets to display subsets.
All targets you can run from the top-level
must be described in "make help".
Maybe like this?
confighelp - Show only configuration targets
dochelp - Show only documentation targets
I feel a bit cumbersome, but I will probably accept it
if people think it is useful.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] selftests: mqueue: fix regression in silencing output from RUN_TESTS
2017-10-02 23:44 [PATCH] doc: dev-tools: kselftest.rst: update to include make O=dir support Shuah Khan
2017-10-02 23:44 ` [PATCH] doc: enhance dochelp include default output location for doc build Shuah Khan
2017-10-02 23:44 ` [PATCH] Makefile: enable dochelp run from main make level Shuah Khan
@ 2017-10-02 23:44 ` Shuah Khan
2017-10-02 23:44 ` [PATCH] selftests: x86: sysret_ss_attrs doesn't build on a PIE build Shuah Khan
2017-10-12 17:02 ` [PATCH] doc: dev-tools: kselftest.rst: update to include make O=dir support Jonathan Corbet
4 siblings, 0 replies; 14+ messages in thread
From: Shuah Khan @ 2017-10-02 23:44 UTC (permalink / raw)
To: shuah, bamvor.zhangjian; +Cc: Shuah Khan, linux-kselftest, linux-kernel
Fix fix regression in silencing output from RUN_TESTS introduced by
commit <8230b905a6780c6> selftests: mqueue: Use full path to run tests
from Makefile
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
tools/testing/selftests/mqueue/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/mqueue/Makefile b/tools/testing/selftests/mqueue/Makefile
index 0f5e347b068d..152823b6cb21 100644
--- a/tools/testing/selftests/mqueue/Makefile
+++ b/tools/testing/selftests/mqueue/Makefile
@@ -5,8 +5,8 @@ TEST_GEN_PROGS := mq_open_tests mq_perf_tests
include ../lib.mk
override define RUN_TESTS
- $(OUTPUT)/mq_open_tests /test1 || echo "selftests: mq_open_tests [FAIL]"
- $(OUTPUT)//mq_perf_tests || echo "selftests: mq_perf_tests [FAIL]"
+ @$(OUTPUT)/mq_open_tests /test1 || echo "selftests: mq_open_tests [FAIL]"
+ @$(OUTPUT)/mq_perf_tests || echo "selftests: mq_perf_tests [FAIL]"
endef
override define EMIT_TESTS
--
2.11.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] selftests: x86: sysret_ss_attrs doesn't build on a PIE build
2017-10-02 23:44 [PATCH] doc: dev-tools: kselftest.rst: update to include make O=dir support Shuah Khan
` (2 preceding siblings ...)
2017-10-02 23:44 ` [PATCH] selftests: mqueue: fix regression in silencing output from RUN_TESTS Shuah Khan
@ 2017-10-02 23:44 ` Shuah Khan
2017-10-12 17:02 ` [PATCH] doc: dev-tools: kselftest.rst: update to include make O=dir support Jonathan Corbet
4 siblings, 0 replies; 14+ messages in thread
From: Shuah Khan @ 2017-10-02 23:44 UTC (permalink / raw)
To: shuah, luto, mingo, bamvor.zhangjian, kirill.shutemov,
dave.hansen, bamvor.zhangjian
Cc: Shuah Khan, linux-kselftest, linux-kernel
sysret_ss_attrs fails to compile leading x86 test run to fail on systems
configured to build using PIE by default. Add -no-pie fix it.
Relocation might still fail if relocated above 4G. For now this change
fixes the build and runs x86 tests.
tools/testing/selftests/x86$ make
gcc -m64 -o .../tools/testing/selftests/x86/single_step_syscall_64 -O2
-g -std=gnu99 -pthread -Wall single_step_syscall.c -lrt -ldl
gcc -m64 -o .../tools/testing/selftests/x86/sysret_ss_attrs_64 -O2 -g
-std=gnu99 -pthread -Wall sysret_ss_attrs.c thunks.S -lrt -ldl
/usr/bin/ld: /tmp/ccS6pvIh.o: relocation R_X86_64_32S against `.text'
can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Nonrepresentable section on output
collect2: error: ld returned 1 exit status
Makefile:49: recipe for target
'.../tools/testing/selftests/x86/sysret_ss_attrs_64' failed
make: *** [.../tools/testing/selftests/x86/sysret_ss_attrs_64] Error 1
Suggested-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
tools/testing/selftests/x86/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index 97f187e2663f..0a74a20ca32b 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -20,7 +20,7 @@ BINARIES_64 := $(TARGETS_C_64BIT_ALL:%=%_64)
BINARIES_32 := $(patsubst %,$(OUTPUT)/%,$(BINARIES_32))
BINARIES_64 := $(patsubst %,$(OUTPUT)/%,$(BINARIES_64))
-CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
+CFLAGS := -O2 -g -std=gnu99 -pthread -Wall -no-pie
UNAME_M := $(shell uname -m)
CAN_BUILD_I386 := $(shell ./check_cc.sh $(CC) trivial_32bit_program.c -m32)
--
2.11.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] doc: dev-tools: kselftest.rst: update to include make O=dir support
2017-10-02 23:44 [PATCH] doc: dev-tools: kselftest.rst: update to include make O=dir support Shuah Khan
` (3 preceding siblings ...)
2017-10-02 23:44 ` [PATCH] selftests: x86: sysret_ss_attrs doesn't build on a PIE build Shuah Khan
@ 2017-10-12 17:02 ` Jonathan Corbet
2017-10-12 17:07 ` Shuah Khan
4 siblings, 1 reply; 14+ messages in thread
From: Jonathan Corbet @ 2017-10-12 17:02 UTC (permalink / raw)
To: Shuah Khan; +Cc: shuah, linux-kselftest, linux-doc, linux-kernel
On Mon, 2 Oct 2017 17:44:17 -0600
Shuah Khan <shuahkh@osg.samsung.com> wrote:
> Update to include details on make O=dir support and other changes improve
> test results output.
So the three patches you sent me appear to be a part of a larger series
that I didn't get. I'll assume you want me to apply these three...
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> Documentation/dev-tools/kselftest.rst | 34 ++++++++++++++++++++++++++++++++--
> 1 file changed, 32 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index ebd03d11d2c2..0aa6dde835d1 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -31,6 +31,17 @@ To build and run the tests with a single command, use::
>
> Note that some tests will require root privileges.
>
> +Build and run from user specific object directory (make O=dir):
> +
> + $ make O=/tmp/kselftest kselftest
> +
> +Build and run KBUILD_OUTPUT directory (make KBUILD_OUTPUT=):
> +
> + $ make KBUILD_OUTPUT=/tmp/kselftest kselftest
> +
These lines should really end with a double colon like this:
Build and run from user specific object directory (make O=dir)::
That indicates that what follows is to be formatted as code, and makes it
match the rest of the document. I took the liberty of fixing these up on
the way in.
All three applied, thanks.
jon
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] doc: dev-tools: kselftest.rst: update to include make O=dir support
2017-10-12 17:02 ` [PATCH] doc: dev-tools: kselftest.rst: update to include make O=dir support Jonathan Corbet
@ 2017-10-12 17:07 ` Shuah Khan
0 siblings, 0 replies; 14+ messages in thread
From: Shuah Khan @ 2017-10-12 17:07 UTC (permalink / raw)
To: Jonathan Corbet
Cc: shuah, linux-kselftest, linux-doc, linux-kernel, Shuah Khan
On 10/12/2017 11:02 AM, Jonathan Corbet wrote:
> On Mon, 2 Oct 2017 17:44:17 -0600
> Shuah Khan <shuahkh@osg.samsung.com> wrote:
>
>> Update to include details on make O=dir support and other changes improve
>> test results output.
>
> So the three patches you sent me appear to be a part of a larger series
> that I didn't get. I'll assume you want me to apply these three...
There is no dependency between the patches. The other two patches are
improvements to dochelp target.
>
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>> Documentation/dev-tools/kselftest.rst | 34 ++++++++++++++++++++++++++++++++--
>> 1 file changed, 32 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
>> index ebd03d11d2c2..0aa6dde835d1 100644
>> --- a/Documentation/dev-tools/kselftest.rst
>> +++ b/Documentation/dev-tools/kselftest.rst
>> @@ -31,6 +31,17 @@ To build and run the tests with a single command, use::
>>
>> Note that some tests will require root privileges.
>>
>> +Build and run from user specific object directory (make O=dir):
>> +
>> + $ make O=/tmp/kselftest kselftest
>> +
>> +Build and run KBUILD_OUTPUT directory (make KBUILD_OUTPUT=):
>> +
>> + $ make KBUILD_OUTPUT=/tmp/kselftest kselftest
>> +
>
> These lines should really end with a double colon like this:
>
> Build and run from user specific object directory (make O=dir)::
>
> That indicates that what follows is to be formatted as code, and makes it
> match the rest of the document. I took the liberty of fixing these up on
> the way in.
Thanks for fixing this.
>
> All three applied, thanks.
>
Thanks,
-- Shuah
^ permalink raw reply [flat|nested] 14+ messages in thread