All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: stable@vger.kernel.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell
Date: Fri, 13 Oct 2017 18:53:10 +0300	[thread overview]
Message-ID: <20171013155310.GD10981@intel.com> (raw)
In-Reply-To: <20171013154735.27163-1-chris@chris-wilson.co.uk>

On Fri, Oct 13, 2017 at 04:47:35PM +0100, Chris Wilson wrote:
> The compiler warns:
> 
> 	drivers/gpu/drm/i915/intel_ddi.c:118:35: warning: ‘bdw_ddi_translations_fdi’ defined but not used
> 
> Lo and behold, if we look at intel_ddi_get_buf_trans_fdi(), it uses
> hsw_ddi_translations_fdi[] for both Haswell and *Broadwell*
> 
> Fixes: 7d1c42e679f9 ("drm/i915: Refactor code to select the DDI buf translation table")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: David Weinehall <david.weinehall@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v4.12+

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index b307b6fe1ce3..115162549914 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -734,8 +734,8 @@ intel_ddi_get_buf_trans_fdi(struct drm_i915_private *dev_priv,
>  			    int *n_entries)
>  {
>  	if (IS_BROADWELL(dev_priv)) {
> -		*n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
> -		return hsw_ddi_translations_fdi;
> +		*n_entries = ARRAY_SIZE(bdw_ddi_translations_fdi);
> +		return bdw_ddi_translations_fdi;
>  	} else if (IS_HASWELL(dev_priv)) {
>  		*n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
>  		return hsw_ddi_translations_fdi;
> -- 
> 2.15.0.rc0

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org,
	David Weinehall <david.weinehall@linux.intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell
Date: Fri, 13 Oct 2017 18:53:10 +0300	[thread overview]
Message-ID: <20171013155310.GD10981@intel.com> (raw)
In-Reply-To: <20171013154735.27163-1-chris@chris-wilson.co.uk>

On Fri, Oct 13, 2017 at 04:47:35PM +0100, Chris Wilson wrote:
> The compiler warns:
> 
> 	drivers/gpu/drm/i915/intel_ddi.c:118:35: warning: ‘bdw_ddi_translations_fdi’ defined but not used
> 
> Lo and behold, if we look at intel_ddi_get_buf_trans_fdi(), it uses
> hsw_ddi_translations_fdi[] for both Haswell and *Broadwell*
> 
> Fixes: 7d1c42e679f9 ("drm/i915: Refactor code to select the DDI buf translation table")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: David Weinehall <david.weinehall@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v4.12+

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index b307b6fe1ce3..115162549914 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -734,8 +734,8 @@ intel_ddi_get_buf_trans_fdi(struct drm_i915_private *dev_priv,
>  			    int *n_entries)
>  {
>  	if (IS_BROADWELL(dev_priv)) {
> -		*n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
> -		return hsw_ddi_translations_fdi;
> +		*n_entries = ARRAY_SIZE(bdw_ddi_translations_fdi);
> +		return bdw_ddi_translations_fdi;
>  	} else if (IS_HASWELL(dev_priv)) {
>  		*n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi);
>  		return hsw_ddi_translations_fdi;
> -- 
> 2.15.0.rc0

-- 
Ville Syrjälä
Intel OTC

  parent reply	other threads:[~2017-10-13 15:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13 15:47 [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell Chris Wilson
2017-10-13 15:50 ` Chris Wilson
2017-10-13 15:53 ` Ville Syrjälä [this message]
2017-10-13 15:53   ` Ville Syrjälä
2017-10-13 17:42 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-13 20:46   ` Chris Wilson
2017-10-16 11:55     ` Ville Syrjälä
2017-10-14  1:49 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-10-16 14:17 ` [PATCH] " David Weinehall
2017-10-16 14:17   ` David Weinehall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171013155310.GD10981@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.