From: Thierry Reding <thierry.reding@gmail.com>
To: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Cc: bhelgaas@google.com, jonathanh@nvidia.com,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
mperttunen@nvidia.com
Subject: Re: [PATCH V2 3/4] arm64: tegra: Add PCIe node for Tegra186
Date: Thu, 19 Oct 2017 12:48:17 +0200 [thread overview]
Message-ID: <20171019104817.GJ9005@ulmo> (raw)
In-Reply-To: <1506513517-25870-4-git-send-email-mmaddireddy@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]
On Wed, Sep 27, 2017 at 05:28:36PM +0530, Manikanta Maddireddy wrote:
> Tegra186 has three PCIe controllers, which can be operated
> in 401, 211 or 111 lane combinations. Add DT support for
> PCIe controllers.
>
> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
> Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
> Tested-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
> V2: No change in this patch
> arch/arm64/boot/dts/nvidia/tegra186.dtsi | 82 ++++++++++++++++++++++++++++++++
> 1 file changed, 82 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> index 0b0552c9f7dd..9edf2a839e5d 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> @@ -443,6 +443,7 @@
> shmem = <&cpu_bpmp_tx &cpu_bpmp_rx>;
> #clock-cells = <1>;
> #reset-cells = <1>;
> + #power-domain-cells = <1>;
>
> bpmp_i2c: i2c {
> compatible = "nvidia,tegra186-bpmp-i2c";
> @@ -465,4 +466,85 @@
> (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
> interrupt-parent = <&gic>;
> };
> +
> + pcie@10003000 {
I sorted this in correctly. For the future, please sort nodes by unit
address. If a node doesn't have a unit address, sort it by name and
after those with a unit address.
Also removed a gratuituous blank line.
Applied to for-4.15/arm64/dt.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Manikanta Maddireddy
<mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH V2 3/4] arm64: tegra: Add PCIe node for Tegra186
Date: Thu, 19 Oct 2017 12:48:17 +0200 [thread overview]
Message-ID: <20171019104817.GJ9005@ulmo> (raw)
In-Reply-To: <1506513517-25870-4-git-send-email-mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1528 bytes --]
On Wed, Sep 27, 2017 at 05:28:36PM +0530, Manikanta Maddireddy wrote:
> Tegra186 has three PCIe controllers, which can be operated
> in 401, 211 or 111 lane combinations. Add DT support for
> PCIe controllers.
>
> Signed-off-by: Manikanta Maddireddy <mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Reviewed-by: Mikko Perttunen <mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Tested-by: Mikko Perttunen <mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> V2: No change in this patch
> arch/arm64/boot/dts/nvidia/tegra186.dtsi | 82 ++++++++++++++++++++++++++++++++
> 1 file changed, 82 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> index 0b0552c9f7dd..9edf2a839e5d 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> @@ -443,6 +443,7 @@
> shmem = <&cpu_bpmp_tx &cpu_bpmp_rx>;
> #clock-cells = <1>;
> #reset-cells = <1>;
> + #power-domain-cells = <1>;
>
> bpmp_i2c: i2c {
> compatible = "nvidia,tegra186-bpmp-i2c";
> @@ -465,4 +466,85 @@
> (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
> interrupt-parent = <&gic>;
> };
> +
> + pcie@10003000 {
I sorted this in correctly. For the future, please sort nodes by unit
address. If a node doesn't have a unit address, sort it by name and
after those with a unit address.
Also removed a gratuituous blank line.
Applied to for-4.15/arm64/dt.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-19 10:48 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 11:58 [PATCH V2 0/4] Add Tegra186 PCIe support Manikanta Maddireddy
2017-09-27 11:58 ` Manikanta Maddireddy
2017-09-27 11:58 ` [PATCH V2 1/4] dt-bindings: pci: tegra: Document Tegra186 PCIe DT Manikanta Maddireddy
2017-09-27 11:58 ` Manikanta Maddireddy
2017-10-13 16:37 ` Thierry Reding
2017-10-13 16:37 ` Thierry Reding
2017-09-27 11:58 ` [PATCH V2 2/4] PCI: tegra: Add Tegra186 PCIe support Manikanta Maddireddy
2017-09-27 11:58 ` Manikanta Maddireddy
2017-10-13 16:38 ` Thierry Reding
2017-10-13 16:38 ` Thierry Reding
2017-10-17 17:34 ` Bjorn Helgaas
2017-10-17 17:34 ` Bjorn Helgaas
2017-10-17 20:27 ` Thierry Reding
2017-10-17 20:27 ` Thierry Reding
2017-10-18 13:27 ` Bjorn Helgaas
2017-10-18 14:14 ` Manikanta Maddireddy
2017-10-18 14:14 ` Manikanta Maddireddy
2017-10-18 16:29 ` Bjorn Helgaas
2017-10-19 6:51 ` Manikanta Maddireddy
2017-10-19 6:51 ` Manikanta Maddireddy
2017-09-27 11:58 ` [PATCH V2 3/4] arm64: tegra: Add PCIe node for Tegra186 Manikanta Maddireddy
2017-09-27 11:58 ` Manikanta Maddireddy
2017-10-19 10:48 ` Thierry Reding [this message]
2017-10-19 10:48 ` Thierry Reding
2017-09-27 11:58 ` [PATCH V2 4/4] arm64: tegra: Enable PCIe on Jetson TX2 Manikanta Maddireddy
2017-09-27 11:58 ` Manikanta Maddireddy
2017-10-19 10:49 ` Thierry Reding
2017-10-19 10:49 ` Thierry Reding
2017-10-17 17:37 ` [PATCH V2 0/4] Add Tegra186 PCIe support Bjorn Helgaas
2017-10-17 20:28 ` Thierry Reding
2017-10-18 5:07 ` Manikanta Maddireddy
2017-10-18 5:07 ` Manikanta Maddireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019104817.GJ9005@ulmo \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=mperttunen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.