From: Steffen Klassert <steffen.klassert@secunet.com>
To: Colin King <colin.king@canonical.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] esp6: remove redundant initialization of esph
Date: Mon, 23 Oct 2017 11:21:07 +0000 [thread overview]
Message-ID: <20171023112107.GG3323@secunet.com> (raw)
In-Reply-To: <20171019130947.30950-1-colin.king@canonical.com>
On Thu, Oct 19, 2017 at 03:09:47PM +0200, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer esph is being initialized with a value that is never
> read and then being updated. Remove the redundant initialization
> and move the declaration and initializtion of esph to the local
> code block.
>
> Cleans up clang warning:
> net/ipv6/esp6.c:562:21: warning: Value stored to 'esph' during its
> initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to ipsec-next, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Colin King <colin.king@canonical.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
<netdev@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] esp6: remove redundant initialization of esph
Date: Mon, 23 Oct 2017 13:21:07 +0200 [thread overview]
Message-ID: <20171023112107.GG3323@secunet.com> (raw)
In-Reply-To: <20171019130947.30950-1-colin.king@canonical.com>
On Thu, Oct 19, 2017 at 03:09:47PM +0200, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer esph is being initialized with a value that is never
> read and then being updated. Remove the redundant initialization
> and move the declaration and initializtion of esph to the local
> code block.
>
> Cleans up clang warning:
> net/ipv6/esp6.c:562:21: warning: Value stored to 'esph' during its
> initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to ipsec-next, thanks!
next prev parent reply other threads:[~2017-10-23 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 13:09 [PATCH] esp6: remove redundant initialization of esph Colin King
2017-10-19 13:09 ` Colin King
2017-10-23 11:21 ` Steffen Klassert [this message]
2017-10-23 11:21 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023112107.GG3323@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.