From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 1/3] perf tool: Introduce arch-specific supplemental perf open strerror capability
Date: Tue, 24 Oct 2017 14:35:35 +0100 [thread overview]
Message-ID: <20171024133535.GC13445@arm.com> (raw)
In-Reply-To: <20171024030404.ec366ec2d9c38910ccd84ba5@arm.com>
On Tue, Oct 24, 2017 at 03:04:04AM -0500, Kim Phillips wrote:
> Introduce new tools/perf/arch/*/util/evsel.c:perf_evsel__suppl_strerror()
> so each arch can start to customize usability for its h/w PMU drivers.
>
> Signed-off-by: Kim Phillips <kim.phillips@arm.com>
> ---
> tools/perf/arch/x86/util/Build | 1 +
> tools/perf/arch/x86/util/evsel.c | 24 ++++++++++++++++++++++++
> tools/perf/util/evsel.c | 21 +++++++++++++++------
> tools/perf/util/evsel.h | 2 ++
> 4 files changed, 42 insertions(+), 6 deletions(-)
> create mode 100644 tools/perf/arch/x86/util/evsel.c
This looks sensible to me, although it's difficult to justify all of the
parameters to perf_evsel__suppl_strerror judging by this patch alone.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Kim Phillips <kim.phillips@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com,
mark.rutland@arm.com, tglx@linutronix.de, peterz@infradead.org,
alexander.shishkin@linux.intel.com, robh@kernel.org,
suzuki.poulose@arm.com, pawel.moll@arm.com,
mathieu.poirier@linaro.org, mingo@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/3] perf tool: Introduce arch-specific supplemental perf open strerror capability
Date: Tue, 24 Oct 2017 14:35:35 +0100 [thread overview]
Message-ID: <20171024133535.GC13445@arm.com> (raw)
In-Reply-To: <20171024030404.ec366ec2d9c38910ccd84ba5@arm.com>
On Tue, Oct 24, 2017 at 03:04:04AM -0500, Kim Phillips wrote:
> Introduce new tools/perf/arch/*/util/evsel.c:perf_evsel__suppl_strerror()
> so each arch can start to customize usability for its h/w PMU drivers.
>
> Signed-off-by: Kim Phillips <kim.phillips@arm.com>
> ---
> tools/perf/arch/x86/util/Build | 1 +
> tools/perf/arch/x86/util/evsel.c | 24 ++++++++++++++++++++++++
> tools/perf/util/evsel.c | 21 +++++++++++++++------
> tools/perf/util/evsel.h | 2 ++
> 4 files changed, 42 insertions(+), 6 deletions(-)
> create mode 100644 tools/perf/arch/x86/util/evsel.c
This looks sensible to me, although it's difficult to justify all of the
parameters to perf_evsel__suppl_strerror judging by this patch alone.
Will
next prev parent reply other threads:[~2017-10-24 13:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 8:04 [RFC 1/3] perf tool: Introduce arch-specific supplemental perf open strerror capability Kim Phillips
2017-10-24 13:35 ` Will Deacon [this message]
2017-10-24 13:35 ` Will Deacon
2017-10-25 1:11 ` Kim Phillips
2017-10-25 1:11 ` Kim Phillips
2017-10-24 14:27 ` Arnaldo Carvalho de Melo
2017-10-24 14:27 ` Arnaldo Carvalho de Melo
2017-10-25 1:23 ` Kim Phillips
2017-10-25 1:23 ` Kim Phillips
2017-10-26 2:22 ` Kim Phillips
2017-10-26 2:22 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024133535.GC13445@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.