All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] locking: Update table layout
@ 2017-10-24 13:26 Akira Yokosawa
  2017-10-24 13:27 ` [PATCH 2/2] defer/rcuapi: Move sidewaystable caption to top Akira Yokosawa
  2017-10-25 21:58 ` [PATCH v2] locking: Update table layout Akira Yokosawa
  0 siblings, 2 replies; 5+ messages in thread
From: Akira Yokosawa @ 2017-10-24 13:26 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: perfbook, Akira Yokosawa

From 126fac5ccb8966764d49cb81b6c61d55bd1d21f4 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <akiyks@gmail.com>
Date: Tue, 24 Oct 2017 07:54:30 +0900
Subject: [PATCH 1/2] locking: Update table layout

To imply vertical lines, instead of coloring alternate rows,
put light gray boxes in blank cells.

Suggested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
---
 locking/locking.tex | 42 ++++++++++++++++++++----------------------
 1 file changed, 20 insertions(+), 22 deletions(-)

diff --git a/locking/locking.tex b/locking/locking.tex
index 9cb0176..a574a0c 100644
--- a/locking/locking.tex
+++ b/locking/locking.tex
@@ -1311,44 +1311,42 @@ or even milliseconds.
 \subsection{Beyond Reader-Writer Locks}
 \label{sec:locking:Beyond Reader-Writer Locks}

+\newcommand{\x}{\textcolor{gray!20}{\rule{7pt}{7pt}}}
+
 \begin{table}
+\renewcommand*{\arraystretch}{1.2}
 \small
 \centering
-\begin{tabular}{l||c|c|c|c|c|c}
-	~ ~ ~ ~ ~ ~ ~ ~ ~
-	& \begin{picture}(6,70)(0,0)
+\begin{tabular}{lcccccc}
+	\toprule
+	& \begin{picture}(6,65)(0,0)
 		\rotatebox{90}{Null (Not Held)}
 	  \end{picture}
-	& \begin{picture}(6,70)(0,0)
+	& \begin{picture}(6,65)(0,0)
 		\rotatebox{90}{Concurrent Read}
 	  \end{picture}
-	& \begin{picture}(6,70)(0,0)
+	& \begin{picture}(6,65)(0,0)
 		\rotatebox{90}{Concurrent Write}
 	  \end{picture}
-	& \begin{picture}(6,70)(0,0)
+	& \begin{picture}(6,65)(0,0)
 		\rotatebox{90}{Protected Read}
 	  \end{picture}
-	& \begin{picture}(6,70)(0,0)
+	& \begin{picture}(6,65)(0,0)
 		\rotatebox{90}{Protected Write}
 	  \end{picture}
-	& \begin{picture}(6,70)(0,0)
+	& \begin{picture}(6,65)(0,0)
 		\rotatebox{90}{Exclusive}
 	  \end{picture}
 	\\
-	\hline
-%				 NL  CR  CW  PR    PW  EX
-	\hline
-	Null (Not Held)		& ~ & ~ & ~   & ~ & ~ & ~ \\
-	\hline
-	Concurrent Read		& ~ & ~ & ~   & ~ & ~ & X \\
-	\hline
-	Concurrent Write	& ~ & ~ & ~   & X & X & X \\
-	\hline
-	Protected Read		& ~ & ~ & X   & ~ & X & X \\
-	\hline
-	Protected Write		& ~ & ~ & X   & X & X & X \\
-	\hline
-	Exclusive		& ~ & X & X   & X & X & X \\
+%				  NL   CR   CW     PR   PW   EX
+	\cmidrule(r){1-1} \cmidrule{2-7}
+	Null (Not Held)		& \x & \x & \x   & \x & \x & \x \\
+	Concurrent Read		& \x & \x & \x   & \x & \x &  X \\
+	Concurrent Write	& \x & \x & \x   &  X &  X &  X \\
+	Protected Read		& \x & \x &  X   & \x &  X &  X \\
+	Protected Write		& \x & \x &  X   &  X &  X &  X \\
+	Exclusive		& \x &  X &  X   &  X &  X &  X \\
+	\bottomrule
 \end{tabular}
 \caption{VAX/VMS Distributed Lock Manager Policy}
 \label{tab:locking:VAX/VMS Distributed Lock Manager Policy}
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] defer/rcuapi: Move sidewaystable caption to top
  2017-10-24 13:26 [PATCH 1/2] locking: Update table layout Akira Yokosawa
@ 2017-10-24 13:27 ` Akira Yokosawa
  2017-10-25 19:26   ` Paul E. McKenney
  2017-10-25 21:58 ` [PATCH v2] locking: Update table layout Akira Yokosawa
  1 sibling, 1 reply; 5+ messages in thread
From: Akira Yokosawa @ 2017-10-24 13:27 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: perfbook, Akira Yokosawa

From 72c667546d964d7fd40a1f21a6475c62e364e77c Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <akiyks@gmail.com>
Date: Tue, 24 Oct 2017 22:15:27 +0900
Subject: [PATCH 2/2] defer/rcuapi: Move sidewaystable caption to top

Captions of sidewaystables can't be controled by float package's
styles. We need to move the caption in LaTeX source.

Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
---
 defer/rcuapi.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/defer/rcuapi.tex b/defer/rcuapi.tex
index 6da4676..d4e434d 100644
--- a/defer/rcuapi.tex
+++ b/defer/rcuapi.tex
@@ -20,6 +20,8 @@ presents concluding remarks.
 \rowcolors{1}{}{lightgray}
 \renewcommand*{\arraystretch}{1.3}
 \centering
+\caption{RCU Wait-to-Finish APIs}
+\label{tab:defer:RCU Wait-to-Finish APIs}
 \footnotesize
 \begin{tabularx}{7.9in}{>{\raggedright\arraybackslash}p{1.08in}
     >{\raggedright\arraybackslash}X
@@ -115,8 +117,6 @@ Non-\tco{PREEMPT_RT} implementation &
 		    SRCU \\
 \bottomrule
 \end{tabularx}
-\caption{RCU Wait-to-Finish APIs}
-\label{tab:defer:RCU Wait-to-Finish APIs}
 \end{sidewaystable*}

 The most straightforward answer to ``what is RCU'' is that RCU is
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] defer/rcuapi: Move sidewaystable caption to top
  2017-10-24 13:27 ` [PATCH 2/2] defer/rcuapi: Move sidewaystable caption to top Akira Yokosawa
@ 2017-10-25 19:26   ` Paul E. McKenney
  0 siblings, 0 replies; 5+ messages in thread
From: Paul E. McKenney @ 2017-10-25 19:26 UTC (permalink / raw)
  To: Akira Yokosawa; +Cc: perfbook

On Tue, Oct 24, 2017 at 10:27:07PM +0900, Akira Yokosawa wrote:
> >From 72c667546d964d7fd40a1f21a6475c62e364e77c Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiyks@gmail.com>
> Date: Tue, 24 Oct 2017 22:15:27 +0900
> Subject: [PATCH 2/2] defer/rcuapi: Move sidewaystable caption to top
> 
> Captions of sidewaystables can't be controled by float package's
> styles. We need to move the caption in LaTeX source.
> 
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>

Applied and pushed, thank you!

							Thanx, Paul

> ---
>  defer/rcuapi.tex | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/defer/rcuapi.tex b/defer/rcuapi.tex
> index 6da4676..d4e434d 100644
> --- a/defer/rcuapi.tex
> +++ b/defer/rcuapi.tex
> @@ -20,6 +20,8 @@ presents concluding remarks.
>  \rowcolors{1}{}{lightgray}
>  \renewcommand*{\arraystretch}{1.3}
>  \centering
> +\caption{RCU Wait-to-Finish APIs}
> +\label{tab:defer:RCU Wait-to-Finish APIs}
>  \footnotesize
>  \begin{tabularx}{7.9in}{>{\raggedright\arraybackslash}p{1.08in}
>      >{\raggedright\arraybackslash}X
> @@ -115,8 +117,6 @@ Non-\tco{PREEMPT_RT} implementation &
>  		    SRCU \\
>  \bottomrule
>  \end{tabularx}
> -\caption{RCU Wait-to-Finish APIs}
> -\label{tab:defer:RCU Wait-to-Finish APIs}
>  \end{sidewaystable*}
> 
>  The most straightforward answer to ``what is RCU'' is that RCU is
> -- 
> 2.7.4
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] locking: Update table layout
  2017-10-24 13:26 [PATCH 1/2] locking: Update table layout Akira Yokosawa
  2017-10-24 13:27 ` [PATCH 2/2] defer/rcuapi: Move sidewaystable caption to top Akira Yokosawa
@ 2017-10-25 21:58 ` Akira Yokosawa
  2017-10-25 22:40   ` Paul E. McKenney
  1 sibling, 1 reply; 5+ messages in thread
From: Akira Yokosawa @ 2017-10-25 21:58 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: perfbook, Akira Yokosawa

From aa7899ff624e41740f4ed22eb43abf856caa6940 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <akiyks@gmail.com>
Date: Tue, 26 Oct 2017 06:51:42 +0900
Subject: [PATCH v2] locking: Update table layout

To imply vertical lines, instead of coloring alternate rows,
put light gray boxes in blank cells.

Suggested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
---
Change after v1:
  The definition of "\x" is moved to within the "table" environment
  to make the macro local.

--
 locking/locking.tex | 41 +++++++++++++++++++----------------------
 1 file changed, 19 insertions(+), 22 deletions(-)

diff --git a/locking/locking.tex b/locking/locking.tex
index 9cb0176..14db27d 100644
--- a/locking/locking.tex
+++ b/locking/locking.tex
@@ -1312,43 +1312,40 @@ or even milliseconds.
 \label{sec:locking:Beyond Reader-Writer Locks}

 \begin{table}
+\renewcommand*{\arraystretch}{1.2}
+\newcommand{\x}{\textcolor{gray!20}{\rule{7pt}{7pt}}}
 \small
 \centering
-\begin{tabular}{l||c|c|c|c|c|c}
-	~ ~ ~ ~ ~ ~ ~ ~ ~
-	& \begin{picture}(6,70)(0,0)
+\begin{tabular}{lcccccc}
+	\toprule
+	& \begin{picture}(6,65)(0,0)
 		\rotatebox{90}{Null (Not Held)}
 	  \end{picture}
-	& \begin{picture}(6,70)(0,0)
+	& \begin{picture}(6,65)(0,0)
 		\rotatebox{90}{Concurrent Read}
 	  \end{picture}
-	& \begin{picture}(6,70)(0,0)
+	& \begin{picture}(6,65)(0,0)
 		\rotatebox{90}{Concurrent Write}
 	  \end{picture}
-	& \begin{picture}(6,70)(0,0)
+	& \begin{picture}(6,65)(0,0)
 		\rotatebox{90}{Protected Read}
 	  \end{picture}
-	& \begin{picture}(6,70)(0,0)
+	& \begin{picture}(6,65)(0,0)
 		\rotatebox{90}{Protected Write}
 	  \end{picture}
-	& \begin{picture}(6,70)(0,0)
+	& \begin{picture}(6,65)(0,0)
 		\rotatebox{90}{Exclusive}
 	  \end{picture}
 	\\
-	\hline
-%				 NL  CR  CW  PR    PW  EX
-	\hline
-	Null (Not Held)		& ~ & ~ & ~   & ~ & ~ & ~ \\
-	\hline
-	Concurrent Read		& ~ & ~ & ~   & ~ & ~ & X \\
-	\hline
-	Concurrent Write	& ~ & ~ & ~   & X & X & X \\
-	\hline
-	Protected Read		& ~ & ~ & X   & ~ & X & X \\
-	\hline
-	Protected Write		& ~ & ~ & X   & X & X & X \\
-	\hline
-	Exclusive		& ~ & X & X   & X & X & X \\
+%				  NL   CR   CW     PR   PW   EX
+	\cmidrule(r){1-1} \cmidrule{2-7}
+	Null (Not Held)		& \x & \x & \x   & \x & \x & \x \\
+	Concurrent Read		& \x & \x & \x   & \x & \x &  X \\
+	Concurrent Write	& \x & \x & \x   &  X &  X &  X \\
+	Protected Read		& \x & \x &  X   & \x &  X &  X \\
+	Protected Write		& \x & \x &  X   &  X &  X &  X \\
+	Exclusive		& \x &  X &  X   &  X &  X &  X \\
+	\bottomrule
 \end{tabular}
 \caption{VAX/VMS Distributed Lock Manager Policy}
 \label{tab:locking:VAX/VMS Distributed Lock Manager Policy}
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] locking: Update table layout
  2017-10-25 21:58 ` [PATCH v2] locking: Update table layout Akira Yokosawa
@ 2017-10-25 22:40   ` Paul E. McKenney
  0 siblings, 0 replies; 5+ messages in thread
From: Paul E. McKenney @ 2017-10-25 22:40 UTC (permalink / raw)
  To: Akira Yokosawa; +Cc: perfbook

On Thu, Oct 26, 2017 at 06:58:44AM +0900, Akira Yokosawa wrote:
> >From aa7899ff624e41740f4ed22eb43abf856caa6940 Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiyks@gmail.com>
> Date: Tue, 26 Oct 2017 06:51:42 +0900
> Subject: [PATCH v2] locking: Update table layout
> 
> To imply vertical lines, instead of coloring alternate rows,
> put light gray boxes in blank cells.
> 
> Suggested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> ---
> Change after v1:
>   The definition of "\x" is moved to within the "table" environment
>   to make the macro local.

Applied, verified that adding a "\x" after the table gives an error,
and pushed it out, thank you!

							Thanx, Paul

> --
>  locking/locking.tex | 41 +++++++++++++++++++----------------------
>  1 file changed, 19 insertions(+), 22 deletions(-)
> 
> diff --git a/locking/locking.tex b/locking/locking.tex
> index 9cb0176..14db27d 100644
> --- a/locking/locking.tex
> +++ b/locking/locking.tex
> @@ -1312,43 +1312,40 @@ or even milliseconds.
>  \label{sec:locking:Beyond Reader-Writer Locks}
> 
>  \begin{table}
> +\renewcommand*{\arraystretch}{1.2}
> +\newcommand{\x}{\textcolor{gray!20}{\rule{7pt}{7pt}}}
>  \small
>  \centering
> -\begin{tabular}{l||c|c|c|c|c|c}
> -	~ ~ ~ ~ ~ ~ ~ ~ ~
> -	& \begin{picture}(6,70)(0,0)
> +\begin{tabular}{lcccccc}
> +	\toprule
> +	& \begin{picture}(6,65)(0,0)
>  		\rotatebox{90}{Null (Not Held)}
>  	  \end{picture}
> -	& \begin{picture}(6,70)(0,0)
> +	& \begin{picture}(6,65)(0,0)
>  		\rotatebox{90}{Concurrent Read}
>  	  \end{picture}
> -	& \begin{picture}(6,70)(0,0)
> +	& \begin{picture}(6,65)(0,0)
>  		\rotatebox{90}{Concurrent Write}
>  	  \end{picture}
> -	& \begin{picture}(6,70)(0,0)
> +	& \begin{picture}(6,65)(0,0)
>  		\rotatebox{90}{Protected Read}
>  	  \end{picture}
> -	& \begin{picture}(6,70)(0,0)
> +	& \begin{picture}(6,65)(0,0)
>  		\rotatebox{90}{Protected Write}
>  	  \end{picture}
> -	& \begin{picture}(6,70)(0,0)
> +	& \begin{picture}(6,65)(0,0)
>  		\rotatebox{90}{Exclusive}
>  	  \end{picture}
>  	\\
> -	\hline
> -%				 NL  CR  CW  PR    PW  EX
> -	\hline
> -	Null (Not Held)		& ~ & ~ & ~   & ~ & ~ & ~ \\
> -	\hline
> -	Concurrent Read		& ~ & ~ & ~   & ~ & ~ & X \\
> -	\hline
> -	Concurrent Write	& ~ & ~ & ~   & X & X & X \\
> -	\hline
> -	Protected Read		& ~ & ~ & X   & ~ & X & X \\
> -	\hline
> -	Protected Write		& ~ & ~ & X   & X & X & X \\
> -	\hline
> -	Exclusive		& ~ & X & X   & X & X & X \\
> +%				  NL   CR   CW     PR   PW   EX
> +	\cmidrule(r){1-1} \cmidrule{2-7}
> +	Null (Not Held)		& \x & \x & \x   & \x & \x & \x \\
> +	Concurrent Read		& \x & \x & \x   & \x & \x &  X \\
> +	Concurrent Write	& \x & \x & \x   &  X &  X &  X \\
> +	Protected Read		& \x & \x &  X   & \x &  X &  X \\
> +	Protected Write		& \x & \x &  X   &  X &  X &  X \\
> +	Exclusive		& \x &  X &  X   &  X &  X &  X \\
> +	\bottomrule
>  \end{tabular}
>  \caption{VAX/VMS Distributed Lock Manager Policy}
>  \label{tab:locking:VAX/VMS Distributed Lock Manager Policy}
> -- 
> 2.7.4
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-10-25 22:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-24 13:26 [PATCH 1/2] locking: Update table layout Akira Yokosawa
2017-10-24 13:27 ` [PATCH 2/2] defer/rcuapi: Move sidewaystable caption to top Akira Yokosawa
2017-10-25 19:26   ` Paul E. McKenney
2017-10-25 21:58 ` [PATCH v2] locking: Update table layout Akira Yokosawa
2017-10-25 22:40   ` Paul E. McKenney

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.