All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: support __int128 on gcc 5+
Date: Tue, 31 Oct 2017 12:17:02 +0000	[thread overview]
Message-ID: <20171031121701.GI5584@arm.com> (raw)
In-Reply-To: <CAHmME9qZq4rsspQ2BFWMXp1boj8YRuvbyfqKWtdPs=6BO9Bm0g@mail.gmail.com>

Hi Jason,

On Tue, Oct 31, 2017 at 12:57:29PM +0100, Jason A. Donenfeld wrote:
> On Tue, Oct 31, 2017 at 12:51 PM, Will Deacon <will.deacon@arm.com> wrote:
> > Which code in the kernel actually uses 128-bit types directly? I know we
> > have some unfortunate occurences in our headers (including uapi) for the
> > vector registers, but I thought we generally used asm or copy routines to
> > access those.
> 
> math64.h provides it, and various things throughout use those
> functions. Notably, the scheduler and kvm use those the __int128
> functions. There's also an elliptic curve implementation that uses it,
> which makes a big difference. And soon I'll be adding an
> implementation of curve25519 that will make heavy use of these
> instructions for significant speedups as well.

Thanks for the info. It does indeed look like mul_u64_u64_shr improves
pretty drastically with this patch, so that sounds good to me. We don't
ever call that function on arm64, but hey.

> Generally, adding this CONFIG_ARCH key is a hint for current and
> future bits of code, so that they can use the faster 128-bit
> implementations when available. Not providing it when it's there and
> available would be silly. This wasn't originally added to the
> architecture, because when the Kconfig symbol was added, gcc didn't
> have sane support for it on aarch64. But now it does, so let's support
> it.

Sure, I'll wait for your patch that matches the relevant compiler versions.

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-arm-kernel@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] arm64: support __int128 on gcc 5+
Date: Tue, 31 Oct 2017 12:17:02 +0000	[thread overview]
Message-ID: <20171031121701.GI5584@arm.com> (raw)
In-Reply-To: <CAHmME9qZq4rsspQ2BFWMXp1boj8YRuvbyfqKWtdPs=6BO9Bm0g@mail.gmail.com>

Hi Jason,

On Tue, Oct 31, 2017 at 12:57:29PM +0100, Jason A. Donenfeld wrote:
> On Tue, Oct 31, 2017 at 12:51 PM, Will Deacon <will.deacon@arm.com> wrote:
> > Which code in the kernel actually uses 128-bit types directly? I know we
> > have some unfortunate occurences in our headers (including uapi) for the
> > vector registers, but I thought we generally used asm or copy routines to
> > access those.
> 
> math64.h provides it, and various things throughout use those
> functions. Notably, the scheduler and kvm use those the __int128
> functions. There's also an elliptic curve implementation that uses it,
> which makes a big difference. And soon I'll be adding an
> implementation of curve25519 that will make heavy use of these
> instructions for significant speedups as well.

Thanks for the info. It does indeed look like mul_u64_u64_shr improves
pretty drastically with this patch, so that sounds good to me. We don't
ever call that function on arm64, but hey.

> Generally, adding this CONFIG_ARCH key is a hint for current and
> future bits of code, so that they can use the faster 128-bit
> implementations when available. Not providing it when it's there and
> available would be silly. This wasn't originally added to the
> architecture, because when the Kconfig symbol was added, gcc didn't
> have sane support for it on aarch64. But now it does, so let's support
> it.

Sure, I'll wait for your patch that matches the relevant compiler versions.

Will

  reply	other threads:[~2017-10-31 12:17 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31 10:17 CONFIG_ARCH_SUPPORTS_INT128 for AArch64 Jason A. Donenfeld
2017-10-31 10:17 ` Jason A. Donenfeld
2017-10-31 10:43 ` Mark Rutland
2017-10-31 10:43   ` Mark Rutland
2017-10-31 11:17   ` Jason A. Donenfeld
2017-10-31 11:17     ` Jason A. Donenfeld
2017-10-31 11:43     ` [PATCH] arm64: support __int128 on gcc 5+ Jason A. Donenfeld
2017-10-31 11:43       ` Jason A. Donenfeld
2017-10-31 11:51       ` Will Deacon
2017-10-31 11:51         ` Will Deacon
2017-10-31 11:57         ` Jason A. Donenfeld
2017-10-31 11:57           ` Jason A. Donenfeld
2017-10-31 12:17           ` Will Deacon [this message]
2017-10-31 12:17             ` Will Deacon
2017-10-31 12:18             ` Jason A. Donenfeld
2017-10-31 12:18               ` Jason A. Donenfeld
2017-11-02 13:47       ` Will Deacon
2017-11-02 13:47         ` Will Deacon
2017-11-02 17:43         ` [PATCH v2] " Jason A. Donenfeld
2017-11-02 17:43           ` Jason A. Donenfeld
2017-11-03 13:42           ` Will Deacon
2017-11-03 13:42             ` Will Deacon
2017-11-03 14:02             ` Ard Biesheuvel
2017-11-03 14:02               ` Ard Biesheuvel
2017-11-03 14:14             ` Jason A. Donenfeld
2017-11-03 14:14               ` Jason A. Donenfeld
2017-11-03 14:18               ` [PATCH v3] " Jason A. Donenfeld
2017-11-03 14:18                 ` Jason A. Donenfeld
2017-11-06  9:31                 ` [PATCH v4] " Jason A. Donenfeld
2017-11-06  9:31                   ` Jason A. Donenfeld
2017-11-06 15:59                   ` Catalin Marinas
2017-11-06 15:59                     ` Catalin Marinas
2017-11-06 16:14                     ` Catalin Marinas
2017-11-06 16:14                       ` Catalin Marinas
     [not found]                       ` <CAHmME9p+ef-+fmdiO15LU7X3Sr-CDyngpPwKZN2FqOQmZNjLtg@mail.gmail.com>
2017-11-06 16:55                         ` Ard Biesheuvel
2017-11-06 16:55                           ` Ard Biesheuvel
2017-11-06 23:58                           ` [PATCH v5] " Jason A. Donenfeld
2017-11-06 23:58                             ` Jason A. Donenfeld
2017-11-07  0:01                           ` [PATCH v4] " Jason A. Donenfeld
2017-11-07  0:01                             ` Jason A. Donenfeld
2017-11-07  2:13                     ` Will Deacon
2017-11-07  2:13                       ` Will Deacon
2017-11-07  2:16                       ` Jason A. Donenfeld
2017-11-07  2:16                         ` Jason A. Donenfeld
2017-11-02 20:24         ` [PATCH] " Jason A. Donenfeld
2017-11-02 20:24           ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171031121701.GI5584@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.