All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] arm64: support __int128 on gcc 5+
Date: Tue, 7 Nov 2017 02:13:16 +0000	[thread overview]
Message-ID: <20171107021316.GA23638@arm.com> (raw)
In-Reply-To: <20171106155917.glgjgipppzsdpp6h@armageddon.cambridge.arm.com>

On Mon, Nov 06, 2017 at 03:59:18PM +0000, Catalin Marinas wrote:
> On Mon, Nov 06, 2017 at 10:31:51AM +0100, Jason A. Donenfeld wrote:
> > Versions of gcc prior to gcc 5 emitted a __multi3 function call when
> > dealing with TI types, resulting in failures when trying to link to
> > libgcc, and more generally, bad performance. However, since gcc 5,
> > the compiler supports actually emitting fast instructions, which means
> > we can at long last enable this option and receive the speedups.
> > 
> > The gcc commit that added proper Aarch64 support is:
> > https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=d1ae7bb994f49316f6f63e6173f2931e837a351d
> > This commit appears to be part of the gcc 5 release.
> > 
> > There are still a few instructions, __ashlti3 and __ashrti3, which
> > require libgcc, which is fine. Rather than linking to libgcc, we
> > simply provide them ourselves, since they're not that complicated.
> > 
> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> 
> According to Arnd, linux-next (with this patch included) fails to build
> with gcc-7 (config: https://pastebin.com/raw/sgvPe96e).
> 
> Will is managing the upcoming merging window for arm64 but is travelling
> this week. I'll wait for couple of days, he'll probably catch up with
> emails but my suggestion is that we revert the patch and push it back
> again into -next after the 4.15 merging window.

So I pushed a fixup patch on top of for-next/core, but I suggest we
temporarily revert the- DCONFIG_ARCH_SUPPORTS_INT128 option if any other
issues crop up.

Cheers,

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	linux-arm-kernel@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	wangkefeng.wang@huawei.com,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v4] arm64: support __int128 on gcc 5+
Date: Tue, 7 Nov 2017 02:13:16 +0000	[thread overview]
Message-ID: <20171107021316.GA23638@arm.com> (raw)
In-Reply-To: <20171106155917.glgjgipppzsdpp6h@armageddon.cambridge.arm.com>

On Mon, Nov 06, 2017 at 03:59:18PM +0000, Catalin Marinas wrote:
> On Mon, Nov 06, 2017 at 10:31:51AM +0100, Jason A. Donenfeld wrote:
> > Versions of gcc prior to gcc 5 emitted a __multi3 function call when
> > dealing with TI types, resulting in failures when trying to link to
> > libgcc, and more generally, bad performance. However, since gcc 5,
> > the compiler supports actually emitting fast instructions, which means
> > we can at long last enable this option and receive the speedups.
> > 
> > The gcc commit that added proper Aarch64 support is:
> > https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=d1ae7bb994f49316f6f63e6173f2931e837a351d
> > This commit appears to be part of the gcc 5 release.
> > 
> > There are still a few instructions, __ashlti3 and __ashrti3, which
> > require libgcc, which is fine. Rather than linking to libgcc, we
> > simply provide them ourselves, since they're not that complicated.
> > 
> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> 
> According to Arnd, linux-next (with this patch included) fails to build
> with gcc-7 (config: https://pastebin.com/raw/sgvPe96e).
> 
> Will is managing the upcoming merging window for arm64 but is travelling
> this week. I'll wait for couple of days, he'll probably catch up with
> emails but my suggestion is that we revert the patch and push it back
> again into -next after the 4.15 merging window.

So I pushed a fixup patch on top of for-next/core, but I suggest we
temporarily revert the- DCONFIG_ARCH_SUPPORTS_INT128 option if any other
issues crop up.

Cheers,

Will

  parent reply	other threads:[~2017-11-07  2:13 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31 10:17 CONFIG_ARCH_SUPPORTS_INT128 for AArch64 Jason A. Donenfeld
2017-10-31 10:17 ` Jason A. Donenfeld
2017-10-31 10:43 ` Mark Rutland
2017-10-31 10:43   ` Mark Rutland
2017-10-31 11:17   ` Jason A. Donenfeld
2017-10-31 11:17     ` Jason A. Donenfeld
2017-10-31 11:43     ` [PATCH] arm64: support __int128 on gcc 5+ Jason A. Donenfeld
2017-10-31 11:43       ` Jason A. Donenfeld
2017-10-31 11:51       ` Will Deacon
2017-10-31 11:51         ` Will Deacon
2017-10-31 11:57         ` Jason A. Donenfeld
2017-10-31 11:57           ` Jason A. Donenfeld
2017-10-31 12:17           ` Will Deacon
2017-10-31 12:17             ` Will Deacon
2017-10-31 12:18             ` Jason A. Donenfeld
2017-10-31 12:18               ` Jason A. Donenfeld
2017-11-02 13:47       ` Will Deacon
2017-11-02 13:47         ` Will Deacon
2017-11-02 17:43         ` [PATCH v2] " Jason A. Donenfeld
2017-11-02 17:43           ` Jason A. Donenfeld
2017-11-03 13:42           ` Will Deacon
2017-11-03 13:42             ` Will Deacon
2017-11-03 14:02             ` Ard Biesheuvel
2017-11-03 14:02               ` Ard Biesheuvel
2017-11-03 14:14             ` Jason A. Donenfeld
2017-11-03 14:14               ` Jason A. Donenfeld
2017-11-03 14:18               ` [PATCH v3] " Jason A. Donenfeld
2017-11-03 14:18                 ` Jason A. Donenfeld
2017-11-06  9:31                 ` [PATCH v4] " Jason A. Donenfeld
2017-11-06  9:31                   ` Jason A. Donenfeld
2017-11-06 15:59                   ` Catalin Marinas
2017-11-06 15:59                     ` Catalin Marinas
2017-11-06 16:14                     ` Catalin Marinas
2017-11-06 16:14                       ` Catalin Marinas
     [not found]                       ` <CAHmME9p+ef-+fmdiO15LU7X3Sr-CDyngpPwKZN2FqOQmZNjLtg@mail.gmail.com>
2017-11-06 16:55                         ` Ard Biesheuvel
2017-11-06 16:55                           ` Ard Biesheuvel
2017-11-06 23:58                           ` [PATCH v5] " Jason A. Donenfeld
2017-11-06 23:58                             ` Jason A. Donenfeld
2017-11-07  0:01                           ` [PATCH v4] " Jason A. Donenfeld
2017-11-07  0:01                             ` Jason A. Donenfeld
2017-11-07  2:13                     ` Will Deacon [this message]
2017-11-07  2:13                       ` Will Deacon
2017-11-07  2:16                       ` Jason A. Donenfeld
2017-11-07  2:16                         ` Jason A. Donenfeld
2017-11-02 20:24         ` [PATCH] " Jason A. Donenfeld
2017-11-02 20:24           ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171107021316.GA23638@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.