From: James Hogan <james.hogan@mips.com>
To: Allen Pais <allen.lkml@gmail.com>
Cc: <ralf@linux-mips.org>, <linux-mips@linux-mips.org>
Subject: Re: mips: use setup_timer() helper.
Date: Thu, 9 Nov 2017 12:54:32 +0000 [thread overview]
Message-ID: <20171109125432.GT15260@jhogan-linux> (raw)
In-Reply-To: <1506080615-6137-1-git-send-email-allen.lkml@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Fri, Sep 22, 2017 at 05:13:35PM +0530, Allen Pais wrote:
> Use setup_timer function instead of initializing timer with the
> function and data fields.
>
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Thanks, applied for 4.15.
Cheers
James
> ---
> arch/mips/lasat/picvue_proc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/mips/lasat/picvue_proc.c b/arch/mips/lasat/picvue_proc.c
> index dd292dc..a8103f6 100644
> --- a/arch/mips/lasat/picvue_proc.c
> +++ b/arch/mips/lasat/picvue_proc.c
> @@ -197,8 +197,7 @@ static int __init pvc_proc_init(void)
> if (proc_entry == NULL)
> goto error;
>
> - init_timer(&timer);
> - timer.function = pvc_proc_timerfunc;
> + setup_timer(&timer, pvc_proc_timerfunc, 0UL);
>
> return 0;
> error:
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@mips.com>
To: Allen Pais <allen.lkml@gmail.com>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: mips: use setup_timer() helper.
Date: Thu, 9 Nov 2017 12:54:32 +0000 [thread overview]
Message-ID: <20171109125432.GT15260@jhogan-linux> (raw)
Message-ID: <20171109125432.T9E9rxqaesdSdub7RqrVeDD-IhqV8ujad9ZdWJ9e78I@z> (raw)
In-Reply-To: <1506080615-6137-1-git-send-email-allen.lkml@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Fri, Sep 22, 2017 at 05:13:35PM +0530, Allen Pais wrote:
> Use setup_timer function instead of initializing timer with the
> function and data fields.
>
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Thanks, applied for 4.15.
Cheers
James
> ---
> arch/mips/lasat/picvue_proc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/mips/lasat/picvue_proc.c b/arch/mips/lasat/picvue_proc.c
> index dd292dc..a8103f6 100644
> --- a/arch/mips/lasat/picvue_proc.c
> +++ b/arch/mips/lasat/picvue_proc.c
> @@ -197,8 +197,7 @@ static int __init pvc_proc_init(void)
> if (proc_entry == NULL)
> goto error;
>
> - init_timer(&timer);
> - timer.function = pvc_proc_timerfunc;
> + setup_timer(&timer, pvc_proc_timerfunc, 0UL);
>
> return 0;
> error:
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-09 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 11:43 [PATCH] mips: use setup_timer() helper Allen Pais
2017-11-09 12:54 ` James Hogan [this message]
2017-11-09 12:54 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109125432.GT15260@jhogan-linux \
--to=james.hogan@mips.com \
--cc=allen.lkml@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.