* [PATCH] mips: use setup_timer() helper.
@ 2017-09-22 11:43 Allen Pais
2017-11-09 12:54 ` James Hogan
0 siblings, 1 reply; 3+ messages in thread
From: Allen Pais @ 2017-09-22 11:43 UTC (permalink / raw)
To: ralf; +Cc: linux-mips, Allen Pais
Use setup_timer function instead of initializing timer with the
function and data fields.
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
arch/mips/lasat/picvue_proc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/mips/lasat/picvue_proc.c b/arch/mips/lasat/picvue_proc.c
index dd292dc..a8103f6 100644
--- a/arch/mips/lasat/picvue_proc.c
+++ b/arch/mips/lasat/picvue_proc.c
@@ -197,8 +197,7 @@ static int __init pvc_proc_init(void)
if (proc_entry == NULL)
goto error;
- init_timer(&timer);
- timer.function = pvc_proc_timerfunc;
+ setup_timer(&timer, pvc_proc_timerfunc, 0UL);
return 0;
error:
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: mips: use setup_timer() helper.
@ 2017-11-09 12:54 ` James Hogan
0 siblings, 0 replies; 3+ messages in thread
From: James Hogan @ 2017-11-09 12:54 UTC (permalink / raw)
To: Allen Pais; +Cc: ralf, linux-mips
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Fri, Sep 22, 2017 at 05:13:35PM +0530, Allen Pais wrote:
> Use setup_timer function instead of initializing timer with the
> function and data fields.
>
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Thanks, applied for 4.15.
Cheers
James
> ---
> arch/mips/lasat/picvue_proc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/mips/lasat/picvue_proc.c b/arch/mips/lasat/picvue_proc.c
> index dd292dc..a8103f6 100644
> --- a/arch/mips/lasat/picvue_proc.c
> +++ b/arch/mips/lasat/picvue_proc.c
> @@ -197,8 +197,7 @@ static int __init pvc_proc_init(void)
> if (proc_entry == NULL)
> goto error;
>
> - init_timer(&timer);
> - timer.function = pvc_proc_timerfunc;
> + setup_timer(&timer, pvc_proc_timerfunc, 0UL);
>
> return 0;
> error:
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mips: use setup_timer() helper.
@ 2017-11-09 12:54 ` James Hogan
0 siblings, 0 replies; 3+ messages in thread
From: James Hogan @ 2017-11-09 12:54 UTC (permalink / raw)
To: Allen Pais; +Cc: ralf, linux-mips
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Fri, Sep 22, 2017 at 05:13:35PM +0530, Allen Pais wrote:
> Use setup_timer function instead of initializing timer with the
> function and data fields.
>
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Thanks, applied for 4.15.
Cheers
James
> ---
> arch/mips/lasat/picvue_proc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/mips/lasat/picvue_proc.c b/arch/mips/lasat/picvue_proc.c
> index dd292dc..a8103f6 100644
> --- a/arch/mips/lasat/picvue_proc.c
> +++ b/arch/mips/lasat/picvue_proc.c
> @@ -197,8 +197,7 @@ static int __init pvc_proc_init(void)
> if (proc_entry == NULL)
> goto error;
>
> - init_timer(&timer);
> - timer.function = pvc_proc_timerfunc;
> + setup_timer(&timer, pvc_proc_timerfunc, 0UL);
>
> return 0;
> error:
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-09 12:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-22 11:43 [PATCH] mips: use setup_timer() helper Allen Pais
2017-11-09 12:54 ` James Hogan
2017-11-09 12:54 ` James Hogan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.