Re: [PATCH 0/4] dma-buf: Silence dma_fence __rcu sparse warnings

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Nov 07, 2017 at 01:37:10PM +0530, Sumit Semwal wrote:
> Hi Ville,
> 
> On 3 November 2017 at 13:18, Christian König <christian.koenig@amd.com> wrote:
> > Patch #4 is Reviewed-by: Christian König <christian.koenig@amd.com>.
> >
> > The rest is Acked-by: Christian König <christian.koenig@amd.com>.
> >
> > Regards,
> > Christian.
> >
> >
> > Am 02.11.2017 um 21:03 schrieb Ville Syrjala:
> >>
> >> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >>
> >> When building drm+i915 I get around 150 lines of sparse noise from
> >> dma_fence __rcu warnings. This series eliminates all of that.
> >>
> >> The first two patches were already posted by Chris, but there wasn't
> >> any real reaction, so I figured I'd repost with a wider Cc list.
> >>
> >> As for the other two patches, I'm no expert on dma_fence and I didn't
> >> spend a lot of time looking at it so I can't be sure I annotated all
> >> the accesses correctly. But I figured someone will scream at me if
> >> I got it wrong ;)
> >>
> >> Cc: Dave Airlie <airlied@redhat.com>
> >> Cc: Jason Ekstrand <jason@jlekstrand.net>
> >> Cc: linaro-mm-sig@lists.linaro.org
> >> Cc: linux-media@vger.kernel.org
> >> Cc: Alex Deucher <alexander.deucher@amd.com>
> >> Cc: Christian König <christian.koenig@amd.com>
> >> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> >> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> >>
> >> Chris Wilson (2):
> >>    drm/syncobj: Mark up the fence as an RCU protected pointer
> >>    dma-buf/fence: Sparse wants __rcu on the object itself
> >>
> >> Ville Syrjälä (2):
> >>    drm/syncobj: Use proper methods for accessing rcu protected pointers
> >>    dma-buf: Use rcu_assign_pointer() to set rcu protected pointers
> 
> For patches 2 (with Daniel's minor comment) and 4, please feel free to add my
> Acked-by: Sumit Semwal <sumit.semwal@linaro.org.

Thanks everyone. Series pushed to drm-misc-next.

> 
> >>
> >>   drivers/dma-buf/reservation.c |  2 +-
> >>   drivers/gpu/drm/drm_syncobj.c | 11 +++++++----
> >>   include/drm/drm_syncobj.h     |  2 +-
> >>   include/linux/dma-fence.h     |  2 +-
> >>   4 files changed, 10 insertions(+), 7 deletions(-)
> >>
> >
> 
> Best,
> Sumit.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel