From: James Hogan <james.hogan@mips.com>
To: John Crispin <john@phrozen.org>
Cc: Mathias Kresin <dev@kresin.me>, <ralf@linux-mips.org>,
<linux-mips@linux-mips.org>
Subject: Re: [PATCH 1/2] MIPS: ralink: fix MT7628 pinmux
Date: Mon, 13 Nov 2017 12:25:53 +0000 [thread overview]
Message-ID: <20171113122552.GA15260@jhogan-linux> (raw)
In-Reply-To: <2ddeb62a-adae-d715-7c77-a27df30db6df@phrozen.org>
On Sun, Nov 12, 2017 at 10:55:50AM +0100, John Crispin wrote:
>
>
> On 11/05/17 08:11, Mathias Kresin wrote:
> > According to the datasheet the REFCLK pin is shared with GPIO#37 and
> > the PERST pin is shared with GPIO#36.
> >
> > Signed-off-by: Mathias Kresin <dev@kresin.me>
> Acked-by: John Crispin <john@phrozen.org>
Thanks, both patches applied.
Cheers
James
> > ---
> > arch/mips/ralink/mt7620.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
> > index 094a0ee..528a6ac 100644
> > --- a/arch/mips/ralink/mt7620.c
> > +++ b/arch/mips/ralink/mt7620.c
> > @@ -144,8 +144,8 @@ static struct rt2880_pmx_func i2c_grp_mt7628[] = {
> > FUNC("i2c", 0, 4, 2),
> > };
> >
> > -static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("reclk", 0, 36, 1) };
> > -static struct rt2880_pmx_func perst_grp_mt7628[] = { FUNC("perst", 0, 37, 1) };
> > +static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("reclk", 0, 37, 1) };
> > +static struct rt2880_pmx_func perst_grp_mt7628[] = { FUNC("perst", 0, 36, 1) };
> > static struct rt2880_pmx_func wdt_grp_mt7628[] = { FUNC("wdt", 0, 38, 1) };
> > static struct rt2880_pmx_func spi_grp_mt7628[] = { FUNC("spi", 0, 7, 4) };
> >
>
>
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@mips.com>
To: John Crispin <john@phrozen.org>
Cc: Mathias Kresin <dev@kresin.me>,
ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 1/2] MIPS: ralink: fix MT7628 pinmux
Date: Mon, 13 Nov 2017 12:25:53 +0000 [thread overview]
Message-ID: <20171113122552.GA15260@jhogan-linux> (raw)
Message-ID: <20171113122553.ncJ6uqVX0z6ZfVMVv_vyYnMAYhhnKCJ4_07BBeD86ns@z> (raw)
In-Reply-To: <2ddeb62a-adae-d715-7c77-a27df30db6df@phrozen.org>
On Sun, Nov 12, 2017 at 10:55:50AM +0100, John Crispin wrote:
>
>
> On 11/05/17 08:11, Mathias Kresin wrote:
> > According to the datasheet the REFCLK pin is shared with GPIO#37 and
> > the PERST pin is shared with GPIO#36.
> >
> > Signed-off-by: Mathias Kresin <dev@kresin.me>
> Acked-by: John Crispin <john@phrozen.org>
Thanks, both patches applied.
Cheers
James
> > ---
> > arch/mips/ralink/mt7620.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
> > index 094a0ee..528a6ac 100644
> > --- a/arch/mips/ralink/mt7620.c
> > +++ b/arch/mips/ralink/mt7620.c
> > @@ -144,8 +144,8 @@ static struct rt2880_pmx_func i2c_grp_mt7628[] = {
> > FUNC("i2c", 0, 4, 2),
> > };
> >
> > -static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("reclk", 0, 36, 1) };
> > -static struct rt2880_pmx_func perst_grp_mt7628[] = { FUNC("perst", 0, 37, 1) };
> > +static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("reclk", 0, 37, 1) };
> > +static struct rt2880_pmx_func perst_grp_mt7628[] = { FUNC("perst", 0, 36, 1) };
> > static struct rt2880_pmx_func wdt_grp_mt7628[] = { FUNC("wdt", 0, 38, 1) };
> > static struct rt2880_pmx_func spi_grp_mt7628[] = { FUNC("spi", 0, 7, 4) };
> >
>
>
next prev parent reply other threads:[~2017-11-13 12:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 6:11 [PATCH 1/2] MIPS: ralink: fix MT7628 pinmux Mathias Kresin
2017-05-11 6:11 ` [PATCH 2/2] MIPS: ralink: fix typo in mt7628 pinmux function Mathias Kresin
2017-11-12 9:56 ` John Crispin
2017-11-12 9:55 ` [PATCH 1/2] MIPS: ralink: fix MT7628 pinmux John Crispin
2017-11-13 12:25 ` James Hogan [this message]
2017-11-13 12:25 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113122552.GA15260@jhogan-linux \
--to=james.hogan@mips.com \
--cc=dev@kresin.me \
--cc=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.