* [PATCH 1/2] MIPS: ralink: fix MT7628 pinmux
@ 2017-05-11 6:11 Mathias Kresin
2017-05-11 6:11 ` [PATCH 2/2] MIPS: ralink: fix typo in mt7628 pinmux function Mathias Kresin
2017-11-12 9:55 ` [PATCH 1/2] MIPS: ralink: fix MT7628 pinmux John Crispin
0 siblings, 2 replies; 6+ messages in thread
From: Mathias Kresin @ 2017-05-11 6:11 UTC (permalink / raw)
To: ralf; +Cc: john, linux-mips
According to the datasheet the REFCLK pin is shared with GPIO#37 and
the PERST pin is shared with GPIO#36.
Signed-off-by: Mathias Kresin <dev@kresin.me>
---
arch/mips/ralink/mt7620.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
index 094a0ee..528a6ac 100644
--- a/arch/mips/ralink/mt7620.c
+++ b/arch/mips/ralink/mt7620.c
@@ -144,8 +144,8 @@ static struct rt2880_pmx_func i2c_grp_mt7628[] = {
FUNC("i2c", 0, 4, 2),
};
-static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("reclk", 0, 36, 1) };
-static struct rt2880_pmx_func perst_grp_mt7628[] = { FUNC("perst", 0, 37, 1) };
+static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("reclk", 0, 37, 1) };
+static struct rt2880_pmx_func perst_grp_mt7628[] = { FUNC("perst", 0, 36, 1) };
static struct rt2880_pmx_func wdt_grp_mt7628[] = { FUNC("wdt", 0, 38, 1) };
static struct rt2880_pmx_func spi_grp_mt7628[] = { FUNC("spi", 0, 7, 4) };
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] MIPS: ralink: fix typo in mt7628 pinmux function
2017-05-11 6:11 [PATCH 1/2] MIPS: ralink: fix MT7628 pinmux Mathias Kresin
@ 2017-05-11 6:11 ` Mathias Kresin
2017-11-12 9:56 ` John Crispin
2017-11-12 9:55 ` [PATCH 1/2] MIPS: ralink: fix MT7628 pinmux John Crispin
1 sibling, 1 reply; 6+ messages in thread
From: Mathias Kresin @ 2017-05-11 6:11 UTC (permalink / raw)
To: ralf; +Cc: john, linux-mips
There is a typo inside the pinmux setup code. The function is called
refclk and not reclk.
Signed-off-by: Mathias Kresin <dev@kresin.me>
---
arch/mips/ralink/mt7620.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
index 528a6ac..86fac75 100644
--- a/arch/mips/ralink/mt7620.c
+++ b/arch/mips/ralink/mt7620.c
@@ -144,7 +144,7 @@ static struct rt2880_pmx_func i2c_grp_mt7628[] = {
FUNC("i2c", 0, 4, 2),
};
-static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("reclk", 0, 37, 1) };
+static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("refclk", 0, 37, 1) };
static struct rt2880_pmx_func perst_grp_mt7628[] = { FUNC("perst", 0, 36, 1) };
static struct rt2880_pmx_func wdt_grp_mt7628[] = { FUNC("wdt", 0, 38, 1) };
static struct rt2880_pmx_func spi_grp_mt7628[] = { FUNC("spi", 0, 7, 4) };
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] MIPS: ralink: fix typo in mt7628 pinmux function
2017-05-11 6:11 ` [PATCH 2/2] MIPS: ralink: fix typo in mt7628 pinmux function Mathias Kresin
@ 2017-11-12 9:56 ` John Crispin
0 siblings, 0 replies; 6+ messages in thread
From: John Crispin @ 2017-11-12 9:56 UTC (permalink / raw)
To: Mathias Kresin, ralf; +Cc: linux-mips
On 11/05/17 08:11, Mathias Kresin wrote:
> There is a typo inside the pinmux setup code. The function is called
> refclk and not reclk.
>
> Signed-off-by: Mathias Kresin <dev@kresin.me>
Acked-by: John Crispin <john@phrozen.org>
> ---
> arch/mips/ralink/mt7620.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
> index 528a6ac..86fac75 100644
> --- a/arch/mips/ralink/mt7620.c
> +++ b/arch/mips/ralink/mt7620.c
> @@ -144,7 +144,7 @@ static struct rt2880_pmx_func i2c_grp_mt7628[] = {
> FUNC("i2c", 0, 4, 2),
> };
>
> -static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("reclk", 0, 37, 1) };
> +static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("refclk", 0, 37, 1) };
> static struct rt2880_pmx_func perst_grp_mt7628[] = { FUNC("perst", 0, 36, 1) };
> static struct rt2880_pmx_func wdt_grp_mt7628[] = { FUNC("wdt", 0, 38, 1) };
> static struct rt2880_pmx_func spi_grp_mt7628[] = { FUNC("spi", 0, 7, 4) };
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] MIPS: ralink: fix MT7628 pinmux
2017-05-11 6:11 [PATCH 1/2] MIPS: ralink: fix MT7628 pinmux Mathias Kresin
2017-05-11 6:11 ` [PATCH 2/2] MIPS: ralink: fix typo in mt7628 pinmux function Mathias Kresin
@ 2017-11-12 9:55 ` John Crispin
2017-11-13 12:25 ` James Hogan
1 sibling, 1 reply; 6+ messages in thread
From: John Crispin @ 2017-11-12 9:55 UTC (permalink / raw)
To: Mathias Kresin, ralf; +Cc: linux-mips
On 11/05/17 08:11, Mathias Kresin wrote:
> According to the datasheet the REFCLK pin is shared with GPIO#37 and
> the PERST pin is shared with GPIO#36.
>
> Signed-off-by: Mathias Kresin <dev@kresin.me>
Acked-by: John Crispin <john@phrozen.org>
> ---
> arch/mips/ralink/mt7620.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
> index 094a0ee..528a6ac 100644
> --- a/arch/mips/ralink/mt7620.c
> +++ b/arch/mips/ralink/mt7620.c
> @@ -144,8 +144,8 @@ static struct rt2880_pmx_func i2c_grp_mt7628[] = {
> FUNC("i2c", 0, 4, 2),
> };
>
> -static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("reclk", 0, 36, 1) };
> -static struct rt2880_pmx_func perst_grp_mt7628[] = { FUNC("perst", 0, 37, 1) };
> +static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("reclk", 0, 37, 1) };
> +static struct rt2880_pmx_func perst_grp_mt7628[] = { FUNC("perst", 0, 36, 1) };
> static struct rt2880_pmx_func wdt_grp_mt7628[] = { FUNC("wdt", 0, 38, 1) };
> static struct rt2880_pmx_func spi_grp_mt7628[] = { FUNC("spi", 0, 7, 4) };
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] MIPS: ralink: fix MT7628 pinmux
@ 2017-11-13 12:25 ` James Hogan
0 siblings, 0 replies; 6+ messages in thread
From: James Hogan @ 2017-11-13 12:25 UTC (permalink / raw)
To: John Crispin; +Cc: Mathias Kresin, ralf, linux-mips
On Sun, Nov 12, 2017 at 10:55:50AM +0100, John Crispin wrote:
>
>
> On 11/05/17 08:11, Mathias Kresin wrote:
> > According to the datasheet the REFCLK pin is shared with GPIO#37 and
> > the PERST pin is shared with GPIO#36.
> >
> > Signed-off-by: Mathias Kresin <dev@kresin.me>
> Acked-by: John Crispin <john@phrozen.org>
Thanks, both patches applied.
Cheers
James
> > ---
> > arch/mips/ralink/mt7620.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
> > index 094a0ee..528a6ac 100644
> > --- a/arch/mips/ralink/mt7620.c
> > +++ b/arch/mips/ralink/mt7620.c
> > @@ -144,8 +144,8 @@ static struct rt2880_pmx_func i2c_grp_mt7628[] = {
> > FUNC("i2c", 0, 4, 2),
> > };
> >
> > -static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("reclk", 0, 36, 1) };
> > -static struct rt2880_pmx_func perst_grp_mt7628[] = { FUNC("perst", 0, 37, 1) };
> > +static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("reclk", 0, 37, 1) };
> > +static struct rt2880_pmx_func perst_grp_mt7628[] = { FUNC("perst", 0, 36, 1) };
> > static struct rt2880_pmx_func wdt_grp_mt7628[] = { FUNC("wdt", 0, 38, 1) };
> > static struct rt2880_pmx_func spi_grp_mt7628[] = { FUNC("spi", 0, 7, 4) };
> >
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] MIPS: ralink: fix MT7628 pinmux
@ 2017-11-13 12:25 ` James Hogan
0 siblings, 0 replies; 6+ messages in thread
From: James Hogan @ 2017-11-13 12:25 UTC (permalink / raw)
To: John Crispin; +Cc: Mathias Kresin, ralf, linux-mips
On Sun, Nov 12, 2017 at 10:55:50AM +0100, John Crispin wrote:
>
>
> On 11/05/17 08:11, Mathias Kresin wrote:
> > According to the datasheet the REFCLK pin is shared with GPIO#37 and
> > the PERST pin is shared with GPIO#36.
> >
> > Signed-off-by: Mathias Kresin <dev@kresin.me>
> Acked-by: John Crispin <john@phrozen.org>
Thanks, both patches applied.
Cheers
James
> > ---
> > arch/mips/ralink/mt7620.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
> > index 094a0ee..528a6ac 100644
> > --- a/arch/mips/ralink/mt7620.c
> > +++ b/arch/mips/ralink/mt7620.c
> > @@ -144,8 +144,8 @@ static struct rt2880_pmx_func i2c_grp_mt7628[] = {
> > FUNC("i2c", 0, 4, 2),
> > };
> >
> > -static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("reclk", 0, 36, 1) };
> > -static struct rt2880_pmx_func perst_grp_mt7628[] = { FUNC("perst", 0, 37, 1) };
> > +static struct rt2880_pmx_func refclk_grp_mt7628[] = { FUNC("reclk", 0, 37, 1) };
> > +static struct rt2880_pmx_func perst_grp_mt7628[] = { FUNC("perst", 0, 36, 1) };
> > static struct rt2880_pmx_func wdt_grp_mt7628[] = { FUNC("wdt", 0, 38, 1) };
> > static struct rt2880_pmx_func spi_grp_mt7628[] = { FUNC("spi", 0, 7, 4) };
> >
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-13 12:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-11 6:11 [PATCH 1/2] MIPS: ralink: fix MT7628 pinmux Mathias Kresin
2017-05-11 6:11 ` [PATCH 2/2] MIPS: ralink: fix typo in mt7628 pinmux function Mathias Kresin
2017-11-12 9:56 ` John Crispin
2017-11-12 9:55 ` [PATCH 1/2] MIPS: ralink: fix MT7628 pinmux John Crispin
2017-11-13 12:25 ` James Hogan
2017-11-13 12:25 ` James Hogan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.