From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>,
"Darrick J. Wong"
<darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>,
linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH] fs, dax: unify IOMAP_F_DIRTY read vs write handling policy in the dax core
Date: Mon, 13 Nov 2017 21:59:24 -0800 [thread overview]
Message-ID: <20171114055924.GA15810@infradead.org> (raw)
In-Reply-To: <151062258598.8554.8157038002895095232.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> - if ((flags & IOMAP_WRITE) && xfs_ipincount(ip) &&
> - (ip->i_itemp->ili_fsync_fields & ~XFS_ILOG_TIMESTAMP))
> - iomap->flags |= IOMAP_F_DIRTY;
> + if (xfs_ipincount(ip))
> + if (ip->i_itemp->ili_fsync_fields & ~XFS_ILOG_TIMESTAMP)
> + iomap->flags |= IOMAP_F_DIRTY;
Please don't split up the conditional and make it harder to read.
With that fixed up this looks fine to me:
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jan Kara <jack@suse.cz>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-nvdimm@lists.01.org, Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] fs, dax: unify IOMAP_F_DIRTY read vs write handling policy in the dax core
Date: Mon, 13 Nov 2017 21:59:24 -0800 [thread overview]
Message-ID: <20171114055924.GA15810@infradead.org> (raw)
In-Reply-To: <151062258598.8554.8157038002895095232.stgit@dwillia2-desk3.amr.corp.intel.com>
> - if ((flags & IOMAP_WRITE) && xfs_ipincount(ip) &&
> - (ip->i_itemp->ili_fsync_fields & ~XFS_ILOG_TIMESTAMP))
> - iomap->flags |= IOMAP_F_DIRTY;
> + if (xfs_ipincount(ip))
> + if (ip->i_itemp->ili_fsync_fields & ~XFS_ILOG_TIMESTAMP)
> + iomap->flags |= IOMAP_F_DIRTY;
Please don't split up the conditional and make it harder to read.
With that fixed up this looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org, Jan Kara <jack@suse.cz>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] fs, dax: unify IOMAP_F_DIRTY read vs write handling policy in the dax core
Date: Mon, 13 Nov 2017 21:59:24 -0800 [thread overview]
Message-ID: <20171114055924.GA15810@infradead.org> (raw)
In-Reply-To: <151062258598.8554.8157038002895095232.stgit@dwillia2-desk3.amr.corp.intel.com>
> - if ((flags & IOMAP_WRITE) && xfs_ipincount(ip) &&
> - (ip->i_itemp->ili_fsync_fields & ~XFS_ILOG_TIMESTAMP))
> - iomap->flags |= IOMAP_F_DIRTY;
> + if (xfs_ipincount(ip))
> + if (ip->i_itemp->ili_fsync_fields & ~XFS_ILOG_TIMESTAMP)
> + iomap->flags |= IOMAP_F_DIRTY;
Please don't split up the conditional and make it harder to read.
With that fixed up this looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-11-14 5:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 1:27 [PATCH] fs, dax: unify IOMAP_F_DIRTY read vs write handling policy in the dax core Dan Williams
2017-11-14 1:27 ` Dan Williams
[not found] ` <151062258598.8554.8157038002895095232.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-11-14 2:14 ` Darrick J. Wong
2017-11-14 2:14 ` Darrick J. Wong
2017-11-14 2:14 ` Darrick J. Wong
2017-11-14 4:12 ` Dave Chinner
2017-11-14 4:12 ` Dave Chinner
2017-11-14 4:12 ` Dave Chinner
2017-11-14 6:01 ` Christoph Hellwig
2017-11-14 6:01 ` Christoph Hellwig
2017-11-14 5:59 ` Christoph Hellwig [this message]
2017-11-14 5:59 ` Christoph Hellwig
2017-11-14 5:59 ` Christoph Hellwig
2017-11-14 9:31 ` Jan Kara
2017-11-14 9:31 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114055924.GA15810@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.