All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: David Airlie <airlied@linux.ie>,
	LKML <linux-kernel@vger.kernel.org>,
	DRI-devel <dri-devel@lists.freedesktop.org>,
	Mali DP Maintainers <malidp@foss.arm.com>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm: mali-dp: Separate static internal data into a read-only structure.
Date: Wed, 15 Nov 2017 17:23:59 -0200	[thread overview]
Message-ID: <20171115192359.GA5486@jade> (raw)
In-Reply-To: <20171101141317.3052-1-Liviu.Dudau@arm.com>

Hi Liviu,

2017-11-01 Liviu Dudau <Liviu.Dudau@arm.com>:

> The malidp_hw_device structure that the driver uses to handle the
> differences between versions of the IP contains both non-changeable
> data and fields that get updated at probe time. Previously we were
> copying the read-only part into allocated memory, but that can be
> completely avoided by splitting the structure into a read-only part
> and keeping the runtime modifiable fields into the old structure.
> 
> Reviewed-by: Brian Starkey <brian.starkey@arm.com>
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> ---
>  drivers/gpu/drm/arm/malidp_crtc.c   | 13 ++++----
>  drivers/gpu/drm/arm/malidp_drv.c    | 30 ++++++++---------
>  drivers/gpu/drm/arm/malidp_hw.c     | 46 ++++++++++++++------------
>  drivers/gpu/drm/arm/malidp_hw.h     | 65 ++++++++++++++++++++++---------------
>  drivers/gpu/drm/arm/malidp_planes.c | 19 +++++------
>  5 files changed, 93 insertions(+), 80 deletions(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Gustavo Padovan <gustavo@padovan.org>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: Brian Starkey <brian.starkey@arm.com>,
	David Airlie <airlied@linux.ie>,
	LKML <linux-kernel@vger.kernel.org>,
	DRI-devel <dri-devel@lists.freedesktop.org>,
	Mali DP Maintainers <malidp@foss.arm.com>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm: mali-dp: Separate static internal data into a read-only structure.
Date: Wed, 15 Nov 2017 17:23:59 -0200	[thread overview]
Message-ID: <20171115192359.GA5486@jade> (raw)
In-Reply-To: <20171101141317.3052-1-Liviu.Dudau@arm.com>

Hi Liviu,

2017-11-01 Liviu Dudau <Liviu.Dudau@arm.com>:

> The malidp_hw_device structure that the driver uses to handle the
> differences between versions of the IP contains both non-changeable
> data and fields that get updated at probe time. Previously we were
> copying the read-only part into allocated memory, but that can be
> completely avoided by splitting the structure into a read-only part
> and keeping the runtime modifiable fields into the old structure.
> 
> Reviewed-by: Brian Starkey <brian.starkey@arm.com>
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> ---
>  drivers/gpu/drm/arm/malidp_crtc.c   | 13 ++++----
>  drivers/gpu/drm/arm/malidp_drv.c    | 30 ++++++++---------
>  drivers/gpu/drm/arm/malidp_hw.c     | 46 ++++++++++++++------------
>  drivers/gpu/drm/arm/malidp_hw.h     | 65 ++++++++++++++++++++++---------------
>  drivers/gpu/drm/arm/malidp_planes.c | 19 +++++------
>  5 files changed, 93 insertions(+), 80 deletions(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Gustavo

  reply	other threads:[~2017-11-15 19:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-01 14:13 [PATCH] drm: mali-dp: Separate static internal data into a read-only structure Liviu Dudau
2017-11-01 14:13 ` Liviu Dudau
2017-11-15 19:23 ` Gustavo Padovan [this message]
2017-11-15 19:23   ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171115192359.GA5486@jade \
    --to=gustavo@padovan.org \
    --cc=Liviu.Dudau@arm.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=malidp@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.