From: Flavio Leitner <fbl@sysclose.org>
To: Jiri Benc <jbenc@redhat.com>
Cc: Colin King <colin.king@canonical.com>,
"David S . Miller" <davem@davemloft.net>,
David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtnetlink: fix missing size for IFLA_IF_NETNSID
Date: Thu, 16 Nov 2017 04:56:46 +0000 [thread overview]
Message-ID: <20171116025646.3327d157@plex.home> (raw)
In-Reply-To: <20171106161620.7080cf66@redhat.com>
On Mon, 6 Nov 2017 16:16:20 +0100
Jiri Benc <jbenc@redhat.com> wrote:
> On Mon, 6 Nov 2017 15:04:54 +0000, Colin King wrote:
> > The size for IFLA_IF_NETNSID is missing from the size calculation
> > because the proceeding semicolon was not removed. Fix this by removing
> > the semicolon.
>
> Acked-by: Jiri Benc <jbenc@redhat.com>
>
> Thanks for spotting this! Looking at my initial code, I had that right,
> this was probably introduced during one of rebases, so I blame
> Flavio :-p (On a serious note, thank you, Flavio, for taking care of
> the rebases.)
That's right, ouch!
Thanks for fixing it.
--
Flavio
WARNING: multiple messages have this Message-ID (diff)
From: Flavio Leitner <fbl@sysclose.org>
To: Jiri Benc <jbenc@redhat.com>
Cc: Colin King <colin.king@canonical.com>,
"David S . Miller" <davem@davemloft.net>,
David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtnetlink: fix missing size for IFLA_IF_NETNSID
Date: Thu, 16 Nov 2017 02:56:46 -0200 [thread overview]
Message-ID: <20171116025646.3327d157@plex.home> (raw)
In-Reply-To: <20171106161620.7080cf66@redhat.com>
On Mon, 6 Nov 2017 16:16:20 +0100
Jiri Benc <jbenc@redhat.com> wrote:
> On Mon, 6 Nov 2017 15:04:54 +0000, Colin King wrote:
> > The size for IFLA_IF_NETNSID is missing from the size calculation
> > because the proceeding semicolon was not removed. Fix this by removing
> > the semicolon.
>
> Acked-by: Jiri Benc <jbenc@redhat.com>
>
> Thanks for spotting this! Looking at my initial code, I had that right,
> this was probably introduced during one of rebases, so I blame
> Flavio :-p (On a serious note, thank you, Flavio, for taking care of
> the rebases.)
That's right, ouch!
Thanks for fixing it.
--
Flavio
next prev parent reply other threads:[~2017-11-16 4:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 15:04 [PATCH] rtnetlink: fix missing size for IFLA_IF_NETNSID Colin King
2017-11-06 15:04 ` Colin King
2017-11-06 15:16 ` Jiri Benc
2017-11-06 15:16 ` Jiri Benc
2017-11-16 4:56 ` Flavio Leitner [this message]
2017-11-16 4:56 ` Flavio Leitner
2017-11-08 4:46 ` David Miller
2017-11-08 4:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116025646.3327d157@plex.home \
--to=fbl@sysclose.org \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jbenc@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.