From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "Li Zefan" <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
"Johannes Weiner"
<hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
"Jonathan Corbet" <corbet-T1hC0tSOHrs@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Mike Galbraith" <efault-Mmb7MZpHnFY@public.gmane.org>,
"Christian Brauner"
<christian.brauner-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
"Stéphane Graber"
<stgraber-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>,
"Serge Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy
Date: Mon, 27 Nov 2017 13:42:32 -0800 [thread overview]
Message-ID: <20171127214232.GT983427@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <8a5ba419-2b02-5b6a-462f-34106cc575ab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Hello, Waiman.
On Mon, Nov 27, 2017 at 04:19:57PM -0500, Waiman Long wrote:
> > Let's start just with [e]cpus and [e]mems. The flags interface looks
> > fine but the implementations of these features are really bad and
> > cgroup2 doesn't migrate resources for other controllers either anyway.
>
> That is added because the mem_migrate feature is used in libvirt, I
> think. I am thinking of add a "[EXPERIMENTAL]" tag to the flags to
> indicate that it is subject to change.
I see. Do you happen to know what it's used for and why that's
necessary just so that we can evaluate it better? I'm not quite sure
what adding [EXPERIMENTAL] tag would achieve. If we expose the
feature and people use it, we just have to keep it anyway.
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: "Li Zefan" <lizefan@huawei.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-doc@vger.kernel.org, "Mike Galbraith" <efault@gmx.de>,
"Christian Brauner" <christian.brauner@canonical.com>,
"Stéphane Graber" <stgraber@ubuntu.com>,
"Serge Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy
Date: Mon, 27 Nov 2017 13:42:32 -0800 [thread overview]
Message-ID: <20171127214232.GT983427@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <8a5ba419-2b02-5b6a-462f-34106cc575ab@redhat.com>
Hello, Waiman.
On Mon, Nov 27, 2017 at 04:19:57PM -0500, Waiman Long wrote:
> > Let's start just with [e]cpus and [e]mems. The flags interface looks
> > fine but the implementations of these features are really bad and
> > cgroup2 doesn't migrate resources for other controllers either anyway.
>
> That is added because the mem_migrate feature is used in libvirt, I
> think. I am thinking of add a "[EXPERIMENTAL]" tag to the flags to
> indicate that it is subject to change.
I see. Do you happen to know what it's used for and why that's
necessary just so that we can evaluate it better? I'm not quite sure
what adding [EXPERIMENTAL] tag would achieve. If we expose the
feature and people use it, we just have to keep it anyway.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-11-27 21:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 21:10 [PATCH v3] cpuset: Enable cpuset controller in default hierarchy Waiman Long
2017-10-25 15:50 ` Waiman Long
2017-10-26 14:39 ` Tejun Heo
[not found] ` <20171026143908.GD59538-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2017-10-26 18:12 ` Waiman Long
2017-10-26 18:12 ` Waiman Long
[not found] ` <2814be69-8dc1-b2f8-406e-cc4dda289d94-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-26 20:59 ` Christian Brauner
2017-10-26 20:59 ` Christian Brauner
2017-11-14 17:49 ` Waiman Long
[not found] ` <1507324230-22996-1-git-send-email-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-11-27 21:04 ` Tejun Heo
2017-11-27 21:04 ` Tejun Heo
2017-11-27 21:19 ` Waiman Long
[not found] ` <8a5ba419-2b02-5b6a-462f-34106cc575ab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-11-27 21:42 ` Tejun Heo [this message]
2017-11-27 21:42 ` Tejun Heo
2017-11-27 21:47 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127214232.GT983427@devbig577.frc2.facebook.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=christian.brauner-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=corbet-T1hC0tSOHrs@public.gmane.org \
--cc=efault-Mmb7MZpHnFY@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org \
--cc=stgraber-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.