From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling
Date: Wed, 29 Nov 2017 16:37:12 +0100 [thread overview]
Message-ID: <20171129153712.GA24881@lunn.ch> (raw)
In-Reply-To: <20171129090240.GA3699@Red>
On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote:
> On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote:
> > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote:
> > > The driver expect "allwinner,leds-active-low" to be in PHY node, but
> > > the binding doc expect it to be in MAC node.
> > >
> > > Since all board DT use it also in MAC node, the driver need to search
> > > allwinner,leds-active-low in MAC node.
> >
> > Hi Corentin
> >
> > I'm having trouble working out how this worked before. This is code
> > you moved around, when adding external/internal MDIOs. But the very
> > first version of this driver code used priv->plat->phy_node. Did that
> > somehow point to the MAC node when the internal PHY is used? Or has it
> > been broken all the time?
> >
>
> Hello
>
> Since this feature control only when the activity LED need to blink,
> nobody see that it was broken.
Hi Corentin
So it never worked?
If it never worked, moving the DT properties into the PHY node, where
they belong, won't introduce a regression :-)
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: alexandre.torgue@st.com, netdev@vger.kernel.org,
linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
wens@csie.org, peppe.cavallaro@st.com,
maxime.ripard@free-electrons.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling
Date: Wed, 29 Nov 2017 16:37:12 +0100 [thread overview]
Message-ID: <20171129153712.GA24881@lunn.ch> (raw)
In-Reply-To: <20171129090240.GA3699@Red>
On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote:
> On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote:
> > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote:
> > > The driver expect "allwinner,leds-active-low" to be in PHY node, but
> > > the binding doc expect it to be in MAC node.
> > >
> > > Since all board DT use it also in MAC node, the driver need to search
> > > allwinner,leds-active-low in MAC node.
> >
> > Hi Corentin
> >
> > I'm having trouble working out how this worked before. This is code
> > you moved around, when adding external/internal MDIOs. But the very
> > first version of this driver code used priv->plat->phy_node. Did that
> > somehow point to the MAC node when the internal PHY is used? Or has it
> > been broken all the time?
> >
>
> Hello
>
> Since this feature control only when the activity LED need to blink,
> nobody see that it was broken.
Hi Corentin
So it never worked?
If it never worked, moving the DT properties into the PHY node, where
they belong, won't introduce a regression :-)
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: alexandre.torgue-qxv4g6HH51o@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
wens-jdAy2FN1RRM@public.gmane.org,
peppe.cavallaro-qxv4g6HH51o@public.gmane.org,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling
Date: Wed, 29 Nov 2017 16:37:12 +0100 [thread overview]
Message-ID: <20171129153712.GA24881@lunn.ch> (raw)
In-Reply-To: <20171129090240.GA3699@Red>
On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote:
> On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote:
> > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote:
> > > The driver expect "allwinner,leds-active-low" to be in PHY node, but
> > > the binding doc expect it to be in MAC node.
> > >
> > > Since all board DT use it also in MAC node, the driver need to search
> > > allwinner,leds-active-low in MAC node.
> >
> > Hi Corentin
> >
> > I'm having trouble working out how this worked before. This is code
> > you moved around, when adding external/internal MDIOs. But the very
> > first version of this driver code used priv->plat->phy_node. Did that
> > somehow point to the MAC node when the internal PHY is used? Or has it
> > been broken all the time?
> >
>
> Hello
>
> Since this feature control only when the activity LED need to blink,
> nobody see that it was broken.
Hi Corentin
So it never worked?
If it never worked, moving the DT properties into the PHY node, where
they belong, won't introduce a regression :-)
Andrew
next prev parent reply other threads:[~2017-11-29 15:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 16:48 [PATCH] net: stmmac: dwmac-sun8i: fix allwinner, leds-active-low handling Corentin Labbe
2017-11-28 16:48 ` [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling Corentin Labbe
2017-11-28 16:48 ` Corentin Labbe
2017-11-28 17:38 ` Andrew Lunn
2017-11-28 17:38 ` Andrew Lunn
2017-11-28 17:38 ` Andrew Lunn
2017-11-29 9:02 ` Corentin Labbe
2017-11-29 9:02 ` Corentin Labbe
2017-11-29 9:02 ` Corentin Labbe
2017-11-29 15:37 ` Andrew Lunn [this message]
2017-11-29 15:37 ` Andrew Lunn
2017-11-29 15:37 ` Andrew Lunn
2017-11-29 15:41 ` [PATCH] net: stmmac: dwmac-sun8i: fix allwinner, leds-active-low handling Chen-Yu Tsai
2017-11-29 15:41 ` [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling Chen-Yu Tsai
2017-11-29 15:41 ` Chen-Yu Tsai
2017-11-29 15:46 ` Andrew Lunn
2017-11-29 15:46 ` Andrew Lunn
2017-11-29 15:46 ` Andrew Lunn
2017-11-29 15:50 ` [PATCH] net: stmmac: dwmac-sun8i: fix allwinner, leds-active-low handling Chen-Yu Tsai
2017-11-29 15:50 ` [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling Chen-Yu Tsai
2017-11-29 15:50 ` Chen-Yu Tsai
2017-11-29 15:47 ` Maxime Ripard
2017-11-29 15:47 ` Maxime Ripard
2017-11-29 15:47 ` Maxime Ripard
2017-11-30 14:45 ` David Miller
2017-11-30 14:45 ` David Miller
2017-11-30 14:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129153712.GA24881@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.